Haguichi

Untranslated .desktop and .appdata files

Bug #1753846 reported by Piotr Drąg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Haguichi
Fix Released
Low
Stephen Brandt
Haguichi 1.4.1 "Kronos"

Bug Description

These files are not listed in po/POTFILES.in, so they are not translatable:

data/com.github.ztefn.haguichi-autostart.desktop.in.in
data/com.github.ztefn.haguichi.appdata.xml.in
data/com.github.ztefn.haguichi.desktop.in.in

AppData is also not internationalized in data/meson.build.

Piotr Drąg (piotrdrag)
summary: - Missing files from po/POTFILES.in
+ Untranslated .desktop and .appdata files
Revision history for this message
Stephen Brandt (ztefn) wrote :

Well, the "Comment" field for the desktop files is actually merged in (the translation string is included in src/text.vala) automatically when building using the i18n.merge_file statements in data/meson.build.

I haven't added the desktop file them selfs to po/POTFILES.in on purpose because it would add many useless fields too like "Icon", "Categories", etc. But if you have a need for other specific fields to be translated (like "Keywords" or maybe the rarely used "GenericName") let me know and I'll consider adding.

AppData is indeed not translatable currently. Would be a good idea to make "summary" and "description" nodes translatable.

Changed in haguichi:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Stephen Brandt (ztefn)
milestone: none → 1.4.1
Revision history for this message
Piotr Drąg (piotrdrag) wrote :

gettext is automatically extracting only useful fields from .desktop files, like Name, GenericName, Comment, and Keywords. Currently it extracts also Icon, but that’s a known bug (https://savannah.gnu.org/support/?108887). Categories and others are *not* extracted.

gettext is able to extract all translatable strings from AppData files as well.

Revision history for this message
Stephen Brandt (ztefn) wrote :

You may knock yourself out now!

Changed in haguichi:
status: Triaged → Fix Committed
Revision history for this message
Piotr Drąg (piotrdrag) wrote :

Thanks, I appreciate it!

Stephen Brandt (ztefn)
Changed in haguichi:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.