[regression] Video playback in totem is corrupted in X11

Status changed to 'Confirmed' because the bug affects multiple users.

Seems I can play a vid directly with gstreamer so maybe issue is with totem?
ex.
~$ gst-launch-1.0 playbin uri=file:///home/doug/Desktop/amostviolentyear-nowplaying_h1080p.mkv
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
Got context from element 'vaapisink0': gst.vaapi.Display=context, gst.vaapi.Display=(GstVaapiDisplay)"\(GstVaapiDisplayGLX\)\ vaapidisplayglx1";
Redistribute latency...
Got context from element 'playsink': gst.vaapi.Display=context, gst.vaapi.Display=(GstVaapiDisplay)"\(GstVaapiDisplayGLX\)\ vaapidisplayglx1";
Redistribute latency...
Pipeline is PREROLLED ...
Setting pipeline to PLAYING ...
New clock: GstPulseSinkClock
...

Status changed to 'Confirmed' because the bug affects multiple users.

Oh, that's new. Confirmed!

Totem didn't really change since 17.10, there was a no change rebuild for a library transition and another upload to remove the patch that made it use the old style decoration/menubar under Unity, so it's not really likely totem is the issue or maybe the impact of a rebuild with the new toolchain? In any case it should be easy enough to try to previous version on bionic

It's possible that this broke on the switch to libva2 which would be somewhat hard to test on a current 18.04 image.(not impossible just hard due to extensive amount of packages involved..
To note: parole works fine with the gst-vaapi plugin.

Going the other way, i.e. 17.10 updated, then slowly upgraded to bionic found this.
Updating totem, the eventually all of gstreamer inc. the vaapi plugin, installing libva2 packages produced no issues & did provide vaapi in totem once libva was fully on bionic versions. (restarts after all changes..
Updating libdrm2 caused no issues.
However as soon as this group was updated & a reboot corruption in totem occurred

Upgraded the following packages:
libdrm-amdgpu1 (2.4.83-1) to 2.4.89-1
libegl1-mesa (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1
libgbm1 (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1
libgl1-mesa-dri (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1
libgl1-mesa-glx (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1
libglapi-mesa (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1
libgles2-mesa (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1
libmirclient9 (0.28.0+17.10.20171011.1-0ubuntu1) to 0.29.0-0ubuntu1
libmircommon7 (0.28.0+17.10.20171011.1-0ubuntu1) to 0.29.0-0ubuntu1
libmircore1 (0.28.0+17.10.20171011.1-0ubuntu1) to 0.29.0-0ubuntu1
libmirprotobuf3 (0.28.0+17.10.20171011.1-0ubuntu1) to 0.29.0-0ubuntu1
libwayland-egl1-mesa (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1
mesa-va-drivers (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1
mesa-vdpau-drivers (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1

Downgrading mesa to 17.10 proposed again then upgrading in smallest groups possible (libegl1-mesa, libgl1-mesa-dri & deps first) it's this final 3 group that starts the corruption

Upgraded the following packages:
libgl1-mesa-glx (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1
libglapi-mesa (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1
libgles2-mesa (17.2.8-0ubuntu0~17.10.1) to 17.3.3-0ubuntu1

Thanks. Yeah I knew it was working till recently so suspected the Mesa update caused it.

Status changed to 'Confirmed' because the bug affects multiple users.

OK, so it sounds like the regression probably occurred in Mesa 17.3 recently, and it looks like it only affects clutterautovideosink (used by Totem) in Xorg sessions.

THESE WORK:

gst-launch-1.0 filesrc location=bbb_sunflower_1080p_60fps_normal.mp4 ! qtdemux ! vaapidecodebin ! glimagesink

gst-launch-1.0 filesrc location=bbb_sunflower_1080p_60fps_normal.mp4 ! qtdemux ! vaapidecodebin ! ximagesink

gst-launch-1.0 filesrc location=bbb_sunflower_1080p_60fps_normal.mp4 ! qtdemux ! vaapidecodebin ! xvimagesink

THIS DOESN'T WORK:

gst-launch-1.0 filesrc location=bbb_sunflower_1080p_60fps_normal.mp4 ! qtdemux ! vaapidecodebin ! clutterautovideosink

Although this does work:

gst-launch-1.0 filesrc location=bbb_sunflower_1080p_60fps_normal.mp4 ! qtdemux ! avdec_h264 ! clutterautovideosink

So it's the combination vaapidecodebin + clutterautovideosink that doesn't work any more.

Similarly to comment #13

THESE WORK:

gst-play-1.0 --videosink glimagesink bbb_sunflower_1080p_60fps_normal.mp4
gst-play-1.0 --videosink xvimagesink bbb_sunflower_1080p_60fps_normal.mp4
gst-play-1.0 --videosink ximagesink bbb_sunflower_1080p_60fps_normal.mp4

THIS DOESN'T:

gst-play-1.0 --videosink clutterautovideosink bbb_sunflower_1080p_60fps_normal.mp4

WORKAROUND:

Install these:

https://launchpad.net/ubuntu/+source/mesa/17.2.4-0ubuntu2/+build/13697262/+files/libgl1-mesa-glx_17.2.4-0ubuntu2_amd64.deb

https://launchpad.net/ubuntu/+source/mesa/17.2.4-0ubuntu2/+build/13697262/+files/libglapi-mesa_17.2.4-0ubuntu2_amd64.deb

To undo the above workaround you can do this:

sudo apt install --reinstall libgl1-mesa-glx/bionic libglapi-mesa/bionic

An other similar issue on Xenial which probably use mesa 17.2.4 (proposed not enabled)
lp:1746771

Verified that the patch in fd works in mesa 17.3.3. People may test here: https://launchpad.net/~shemgp/+archive/ubuntu/testing

Although, totem still runs at like 10~18% CPU while mpv is lower at 3~5%.

@shemgp
thanks for the ppa, and pointing to mpv, i was not aware of that app

Enabled the ppa on Bionic, and upgraded the system with your packages. Restarted the gnome-shell session (alt+F2+r), then started gtkorphan that was previously exposing a dropdown black menu: but no luck, the problem persist.

oops

forget the #20 comment above; i've answered to the wrong report

With shemgp's mesa upgrade, totem is playing as expected.
Hope upstream/ubuntu will accept that version/change

Similar upstream report: https://bugzilla.gnome.org/show_bug.cgi?id=792227

WORKAROUND (1):

Install these two together:
https://launchpad.net/ubuntu/+source/mesa/17.2.4-0ubuntu2/+build/13697262/+files/libgl1-mesa-glx_17.2.4-0ubuntu2_amd64.deb
https://launchpad.net/ubuntu/+source/mesa/17.2.4-0ubuntu2/+build/13697262/+files/libglapi-mesa_17.2.4-0ubuntu2_amd64.deb

WORKAROUND (2):

sudo apt remove gstreamer1.0-vaapi

WORKAROUND (3):

Log in to "Ubuntu on Wayland" instead of "Ubuntu".

A fix is in bionic proposed:
https://launchpad.net/ubuntu/+source/mesa/18.0.0~rc4-1ubuntu1

@Daniel

mesa 18 have been successfully built , but the packages still have not landed into 'proposed' archive.

Still pending publication https://launchpad.net/ubuntu/+source/mesa

Packages landed now, and upgrade is ok (if purging previous shemgp ppa first, in case of use)

mesa (18.0.0~rc4-1ubuntu1) bionic; urgency=medium

  * Merge with Debian experimental.
  * Stop using alternatives, not needed anymore with libglvnd.
  * patches: Mir patches updated.
  * dri3-reinstate-get_dri_screen-callback.diff: Fix a regression in
    accelerated video playback. (LP: #1747744)
  * control: Add nvidia-304/340/384 to libegl-mesa0, libgles2-mesa and
    libglx-mesa0 Breaks.

 -- Timo Aaltonen <email address hidden> Tue, 13 Feb 2018 17:56:35 +0200

And totem reads video without problem with mesa 18

Clearly cant blame totem.

don't jump the gun, mesa hasn't landed in bionic yet and won't land before nvidia is fixed to work with libglvnd..

Please don't close the totem task. It is there to help other people find this bug while it's open. That's all.

This bug was fixed in the package mesa - 18.0.0~rc4-1ubuntu3

---------------
mesa (18.0.0~rc4-1ubuntu3) bionic; urgency=medium

  * dont-enable-10bpc-by-default.diff: Replace the drirc hack, just flip
    the default to not enable 10bpc configs by default for gallium drivers.
    (LP: #1752123)

 -- Timo Aaltonen <email address hidden> Wed, 28 Feb 2018 19:34:58 +0200