Update jquery to version 3.3.1

Bug #1741987 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

jQuery 3.3.1 is available

http://jquery.com/download/

description: updated
Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
milestone: none → 18.04.0
Changed in mahara:
status: Confirmed → In Progress
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 18.04.0 → 18.10.0
summary: - Update jquery to version 3.2.1
+ Update jquery to version 3.3.1
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8824

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8825

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8937

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8958

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

I attached the checklist of changes I looked for while upgrading Mahara core code

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8971

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8937
Committed: https://git.mahara.org/mahara/mahara/commit/fac1d239eb65918eb5ab534f18657c46f0463ced
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit fac1d239eb65918eb5ab534f18657c46f0463ced
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jun 1 13:58:58 2018 +1200

Bug 1741987: Update jquery - Attributes

Attributes
Breaking change: .removeAttr() no longer sets properties to false
- replace removeAttr with checked, selected, readonly or disabled -migration tool also complained about this last one- and replace with .prop("attr", false)
Breaking change: select-multiple with nothing selected returns an empty array
- could not find any select multiple elements
Deprecated: .toggleClass() with no arguments and .toggleClass( Boolean )
- there are no .toggleClass() or toggleClass( Boolean ) in core

behatnotneeded

Change-Id: I20c941b1bcd9b1be3ae22907ab83b59b157fbd88

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8825
Committed: https://git.mahara.org/mahara/mahara/commit/3d1abcc2cfd455889a6a2afabdacfba7a13c264a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3d1abcc2cfd455889a6a2afabdacfba7a13c264a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri May 4 15:39:54 2018 +1200

Bug 1741987: Update jquery - Events

Event
Breaking change: .load(), .unload(), and .error() removed
Breaking change: .on("ready", fn) removed
Breaking change: event.pageX and event.pageY normalization removed
Breaking change: jQuery.event.props and jQuery.event.fixHooks removed
Breaking change: Delegated events with bad selectors throw immediately
Deprecated: .bind() and .delegate()
no calls to .bind() for events in core.
Only calls to bind() refer to the js bind of arguments to functions.
no calls to unbind() for event in core.
Only calls to unbind refer to the unbind method defined in
formChangeManager not related to the jQuery method.

Warnings fix
JQMIGRATE: jQuery.fn.click() event shorthand is deprecated
- also applies to the other event shorthands, including:
blur, focus, focusin, focusout, resize, scroll, dblclick, mousedown,
mouseup, mousemove, mouseover, mouseout, mouseenter, mouseleave,
change, select, submit, keydown, keypress, keyup, and contextmenu.

JQMIGRATE: jQuery.fn.hover() is deprecated
JQMIGRATE: jQuery(window).on('load'...) called after load event occurred
 (for FileBrowser we can see this error when editing a block in a page)

behatnotneeded

Change-Id: I1a50050f882b864ad63d273de160e0b441a77705

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8958
Committed: https://git.mahara.org/mahara/mahara/commit/841c042bb7a380c14e2636c242e975112c69d1b3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 841c042bb7a380c14e2636c242e975112c69d1b3
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Jun 14 09:16:31 2018 +1200

Bug 1741987: Update jquery - Core

Deprecated: document-ready handlers other than jQuery(function)
Breaking change: Deprecated .size() removed

behatnotneeded

Change-Id: I7c61090a3362586571855fc081847c084e398c33

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8824
Committed: https://git.mahara.org/mahara/mahara/commit/46ac2ef605f0b80615ed522f3d10ede729b5fb2c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 46ac2ef605f0b80615ed522f3d10ede729b5fb2c
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri May 4 13:26:30 2018 +1200

Bug 1741987: Update jquery to version 3.3.1

behatnotneeded

Change-Id: If5d5c094badb17e019224816f4c6b7beaf5506a7

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8971
Committed: https://git.mahara.org/mahara/mahara/commit/144e6b6335f8a7d484cdddf397f65769112e5fe7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 144e6b6335f8a7d484cdddf397f65769112e5fe7
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jun 22 12:39:44 2018 +1200

Bug 1741987: Update jquery - tinymce/imagebrowser

behatnotneeded

Change-Id: I0ac194b7d87298f49a0e0b2f926e7312febf17a3

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.