Artful: Fix FTBS on test-rebuild due to gcc-7

Bug #1724857 reported by Christian Ehrhardt 
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libmemcached (Ubuntu)
Fix Released
Undecided
Unassigned
Artful
Fix Released
Undecided
Unassigned

Bug Description

On the test rebuild run [1] it was spotted that recently memcached does no more build [2].
This is due to gcc-7 having new ISO C++ checks we need to pass.

This can easily be solved and I'll push an MP for review soon.

[1]: http://qa.ubuntuwire.org/ftbfs/rebuilds/test-rebuild-20170922-artful.html
[2]: https://launchpad.net/ubuntu/+archive/test-rebuild-20170922/+build/13448493/+files/buildlog_ubuntu-artful-amd64.libmemcached_1.0.18-4.1_BUILDING.txt.gz

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Fix confirmed working in [1], now cleaning up branches for review.

[1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/2999/+packages

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Reworked MP to use the fix in Debian.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changes (in 2nd form) reviewed, approved and now uploaded for Artful.

This might race with BB opening and then needs another version (actually the version is fine but it needs to be B... then, and artful get an SRU version number).
Please let me know if it collides, otherwise this should easily go in before without issues.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello ChristianEhrhardt, or anyone else affected,

Accepted libmemcached into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libmemcached/1.0.18-4.1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libmemcached (Ubuntu Artful):
status: New → Fix Committed
tags: added: verification-needed verification-needed-artful
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Builds fine now, no further breakage seen (I'm not the best tester, but this was mostly for the FTBFS anyway) - set verified.

tags: added: verification-done verification-done-artful
removed: verification-needed verification-needed-artful
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libmemcached - 1.0.18-4.1ubuntu1

---------------
libmemcached (1.0.18-4.1ubuntu1) artful; urgency=medium

  * Fix FTBFS with gcc-7 (LP: #1724857)
    - d/p/fix-gcc7-build.diff: fix comparison to match ISO requirements, patch
      from debian can be dropped on next merge.

 -- Christian Ehrhardt <email address hidden> Thu, 19 Oct 2017 15:07:16 +0200

Changed in libmemcached (Ubuntu):
status: New → Fix Released
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Please note that this was accepted into bionic but is still in proposed on artful.
Dep8 tests look good, maybe for the timing (6 days in SRU).

But to be clear this needs "another" accept into artful.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libmemcached - 1.0.18-4.1ubuntu1

---------------
libmemcached (1.0.18-4.1ubuntu1) artful; urgency=medium

  * Fix FTBFS with gcc-7 (LP: #1724857)
    - d/p/fix-gcc7-build.diff: fix comparison to match ISO requirements, patch
      from debian can be dropped on next merge.

 -- Christian Ehrhardt <email address hidden> Thu, 19 Oct 2017 15:07:16 +0200

Changed in libmemcached (Ubuntu Artful):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for libmemcached has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.