The Precision Touchpad(PTP) button sends incorrect event code
Bug #1708372 reported by
AceLan Kao
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
HWE Next |
Fix Released
|
Undecided
|
AceLan Kao | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
AceLan Kao | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
The touchpad right button should send 273(BTN_RIGHT),
and the left button should send 272(BTN_LEFT)
But the touchpad right button sends 274(BTN_MIDDLE),
and the left button sends 273 (BTN_RIGHT)
[Fix]
The fix is pretty simple to just decrease the event code by 1.
[Test Case]
Verified on the machine has this issue, and confirm this patch works.
[Regression Potential]
The patch has strict if statement, so it won't affect other touchpad devices.
And no more rework on this code snip after this commit.
CVE References
Changed in linux (Ubuntu Xenial): | |
status: | New → Fix Committed |
Changed in linux (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in hwe-next: | |
status: | New → Fix Committed |
assignee: | nobody → AceLan Kao (acelankao) |
tags: |
added: verification-done-xenial removed: verification-needed-xenial |
Changed in hwe-next: | |
status: | Fix Committed → Fix Released |
Changed in linux (Ubuntu): | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
commit 504c932c7c47a6b 4c572302a13873f 7d83af1ff3
Author: Masaki Ota <email address hidden>
Date: Fri Jun 16 09:29:39 2017 +0900
HID: multitouch: Support PTP Stick and Touchpad device
Support PTP Stick and Touchpad device. This Touchpad is Precision Touchpad
(PTP), and Stick Pointer data is the same as Mouse; Stick Pointer works as
Mouse.
[<email address hidden>: changelog deuglification]
Signed-off-by: Masaki Ota <email address hidden>
Reviewed-by: Benjamin Tissoires <email address hidden>
Signed-off-by: Jiri Kosina <email address hidden>