Launchpad itself

Bug links inside diffs in merge proposals are not clickable

Bug #1678036 reported by Robie Basak
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

My use case is:

I'm reviewing a merge proposal for a change to Ubuntu (new git workflow stuff). For example: https://code.launchpad.net/~powersj/ubuntu/+source/tomcat7/+git/tomcat7/+merge/319500

I need to follow the bug links to review the corresponding bugs.

I double click on the bug number to select the whole word so that I can copy it to the clipboard. Expected: bug number text selected. Actual: an inline comment dropdown appears, but I did not want that.

Could we perhaps bypass this by scanning for and having "LP: #XXXX" automatically detected and converted to a hyperlink?

Importance: Wishlist expected but I cannot set that.

Thanks!

Revision history for this message
Colin Watson (cjwatson) wrote :

We'd have to be quite careful about this to avoid LP's standard linkification code doing more than we want and making it difficult to see the raw text of diffs.

I would note that this would have been much easier for you if the commit message had simply quoted the bug numbers in the proper style (https://help.launchpad.net/Code/Git#Linking_to_bugs), or at least if the submitter of the MP had linked it to the bugs after the fact. That's also better because the links will be bidirectional, i.e. the bug will also link back to the MP.

tags: added: code-review lp-code ui
Changed in launchpad:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Robie Basak (racb) wrote :

> I would note that this would have been much easier for you if the commit message had simply quoted the bug numbers in the proper style...

That's an interesting point, thanks. Currently since our goal is a correct upload, we're not necessarily always doing this and don't have it documented in our process that we should.

However, I'd note that to review an SRU it's important that I review the set of bug links specifically from debian/changelog, rather than the set of bug links in commit messages. As part of the review, it matters if there are typos, missing or extraneous bug links in debian/changelog itself (and I've seen this happen). This could be mitigated by adding a cross-checking of this to my upcoming linting tool.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.