tripleo

Lack of default for NovaPCIPassthrough breaks the UI JSON validation

Bug #1645266 reported by Julie Pichon on 2016-11-28

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Medium	Florian Fuchs	tripleo ocata-2 "ocata-2"

Bug Description

The NovaPCIPassthrough doesn't seem to have a default set, and so fails the UI validation for "valid JSON strings" before the user even tries to modify it.

Steps to reproduce
------------------
1. Click on the pencil besides the Compute role to edit it
2. Services -> OS::TripleO::Services::NovaCompute

Expected result
---------------
3. Every parameter is displayed with no form validation failures

Actual result
-------------
3. NovaPCIPassthrough is shown in red with "Please enter a valid JSON string." It's not possible to save any change until this is resolved.

Additional information
-----------------------
See related bug 1638523

Tags:

Julie Pichon (jpichon) on 2016-11-28

summary:

- No valid default for NovaPCIPassthrough
+ Lack of default for NovaPCIPassthrough breaks the UI JSON validation

Florian Fuchs (flo-fuchs) on 2016-11-28

Changed in tripleo:
assignee:	nobody → Florian Fuchs (flo-fuchs)

Revision history for this message

Julie Pichon (jpichon) wrote on 2016-11-28:

The default is explicitly set to an empty string: https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/nova-compute.yaml#L43-L55

tags:

removed: tripleo-heat-templates

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-28: Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/403634

Changed in tripleo:
status:	Triaged → In Progress

Julie Pichon (jpichon) on 2016-11-28

tags:

added: newton-backport-potential

Emilien Macchi (emilienm) on 2016-11-29

Changed in tripleo:
milestone:	none → ocata-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-30: Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/403634
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=537618fed2c393cb1fbc0b52f40951dd66e3373c
Submitter: Jenkins
Branch: master

commit 537618fed2c393cb1fbc0b52f40951dd66e3373c
Author: Florian Fuchs <email address hidden>
Date: Mon Nov 28 12:25:48 2016 +0100

Relax JSON input validation

    Currently the JSON form input validator only passes if the value is a
    valid JSON string. This doesn't accout for cases where a paramater
    doesn't need to be set. This patch relaxes the validation rule so it
    also allows the value to be an empty string.

Change-Id: I4d135120ac3041b223986eef8f54c4de24f20379
Closes-Bug: #1645266

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-01: Fix proposed to tripleo-ui (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/405205

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-02: Fix merged to tripleo-ui (stable/newton)

Reviewed: https://review.openstack.org/405205
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=933c1fe214a5f4c516a63ecfb41f8becea0530fd
Submitter: Jenkins
Branch: stable/newton

commit 933c1fe214a5f4c516a63ecfb41f8becea0530fd
Author: Florian Fuchs <email address hidden>
Date: Mon Nov 28 12:25:48 2016 +0100

Relax JSON input validation

    Change-Id: I4d135120ac3041b223986eef8f54c4de24f20379
    Closes-Bug: #1645266
    (cherry picked from commit 537618fed2c393cb1fbc0b52f40951dd66e3373c)