Canonical System Image

enable android adbd properly in systemd

Bug #1627613 reported by You-Sheng Yang on 2016-09-26

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Canonical System Image	Fix Released	Undecided	Unassigned	Canonical System Image x1 "xenial bringup"
android-tools (Ubuntu)	New	Undecided	Unassigned
lxc-android-config (Ubuntu)	Fix Released	Undecided	Unassigned
upstart (Ubuntu)	New	Undecided	Unassigned

Bug Description

Currently android adbd has no systemd service file and the mechanism for related parts like usb state and mtp is void.

TODO: document https://wiki.canonical.com/PES/Engineering/Premium/PhoneArticles/MechanismsThatUseProperty

See original description

Tags:

Related branches

lp://staging/~vicamo/upstart/xenial-escape-systemd-strings

Merged into lp://staging/~ubuntu-core-dev/upstart/xenial at revision 1632

Łukasz Zemczak: Approve (not an upstart maintainer) on 2016-10-03

lp://staging/~vicamo/lxc-android-config/add-upstart-local-bridge

Merged into lp://staging/lxc-android-config at revision 26

Łukasz Zemczak: Approve on 2016-10-04

Ubuntu Phablet Team: Pending requested 2016-10-04

You-Sheng Yang (vicamo) on 2016-09-26

tags:

added: systemd

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2016-09-26:

"upstart-local-bridge[930]: Unit name <email address hidden>\x3d,adb.target is not valid."
So from systemd source, the allowed unit name is:

#define VALID_CHARS DIGITS LETTERS ":-_.\\"

upstart-local-bridge translates the event (name,value) pair to a unit name that doesn't conform to systemd's requirement.

You-Sheng Yang (vicamo) on 2016-09-26

description:

updated

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2016-09-29:

Patch for android-tools to enable adbd in eng build at boot.

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2016-09-29:

0001-install-systemd-service-files.patch Edit (4.0 KiB, text/plain)

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2016-09-29:

upstart-local-bridge Edit (322.5 KiB, application/octet-stream)

Prebuilt upstart-local-bridge binary from version 1.13.2-0ubuntu21.1

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2016-09-29:

The attachment "0001-install-systemd-service-files.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags:

added: patch

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2016-09-30:

upstart_1.13.2-0ubuntu21.1_arm64.deb Edit (345.5 KiB, application/x-debian-package)

Prebuilt package with https://code.launchpad.net/~vicamo/upstart/xenial-escape-systemd-strings applied.

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2016-09-30:

android-tools-adbd_5.1.1r36+git20160322-0ubuntu3.1~overlay1_arm64.deb Edit (49.5 KiB, application/x-debian-package)

Add prebuilt package with https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/1627613/+attachment/4750792/+files/0001-install-systemd-service-files.patch applied.

Revision history for this message

You-Sheng Yang (vicamo) wrote on 2016-09-30:

lxc-android-config_0.230+16.04.20160728-0ubuntu1_all.deb Edit (40.5 KiB, application/x-debian-package)

Add prebuilt lxc-android-config package with mp https://code.launchpad.net/~vicamo/lxc-android-config/add-upstart-local-bridge, https://code.launchpad.net/~vicamo/lxc-android-config/disable-systemd-alsa-restore/+merge/306587, https://code.launchpad.net/~vicamo/lxc-android-config/fix-systemd-service-startup/+merge/306435, https://code.launchpad.net/~vicamo/lxc-android-config/systemd-writable-paths/+merge/306184 applied.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-10-04:

This bug was fixed in the package lxc-android-config - 0.230+16.10.20161004-0ubuntu1

---------------
lxc-android-config (0.230+16.10.20161004-0ubuntu1) yakkety; urgency=medium

  [ You-Sheng Yang ]
  * Align to current upstart setup and run android container in the
    background. (LP: #1625916)
  * Add systemd upstart-local-bridge service (LP: #1627613)
  * Add writable path for systemd. (LP: #1625445)
  * Disable alsa-restore, alsa-state when lxc-android-config installed
    (LP: #1626012)

-- Łukasz Zemczak <email address hidden> Tue, 04 Oct 2016 08:15:25 +0000