python-pymysql fails to build on xenial and yakkety

Lars, could you advise please? I suspect the mysql_install_db invocation needs replacing with the new method?

Yes.
Ideally change to use mysqld --initialize:
https://dev.mysql.com/doc/refman/5.7/en/data-directory-initialization-mysqld.html

It should also be fixable by simply removing --force and --skip-name-resolve and adding --basedir=/usr to the mysql_install_db command

One addition: If the system relies on the database being created with passwordless root access, --insecure also needs to be added (otherwise a one-time random password will be generated and written to the error log)

Adding --insecure and --basedir=/usr and removing --force and --skip-name-resolve, plus removing --skip-grant from the following mysqld command, seems to fix it, but I'm getting a test failure:
test_issue_363, which I'm looking into

The patch fixes the use of mysql_install_db and mysqld in d/run_tests.sh and adds d/patches/mysql-5.7.patch to fix the failing test for issue_363

The attachment "Patch for test script and test failures" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

Any chance of a complete debdiff for this please Lars, with a debian/changelog entry? Then I can easily attribute you fully for the upload, which will help with getting you direct upload access in the future.

Yeah, will add that. Need to remove the comment about --force, too :)
Was testing out using mysqld --initialize instead of mysql_install_db, but it creates some extra complexity with the permissions for datadir, so at least for Xenial I think we'll stick to just changing the options used.

Suggested debdiff for yakkety

Since --skip-grant-tables is likely to be removed in the future, we instead specify the root user when connecting to the temporary database.

Suggested debdiff for xenial

The Xenial patch is a bit smaller since it changes --skip-grant to --skip-grant-tables instead of removing it (which requires specifying the root user later in the script).

Yakkety diff needs rechecking since the test failure has been fixed upstream

any update on this? the fix didn't land yet.

Subscribing ~ubuntu-sponsors.

ACK on the debdiff in comment #9. I removed the patch since it's no longer needed with 0.7.6. Uploaded to yakkety. Thanks!

The debdiff in comment #10 says it's for xenial, but it's for 0.7.5 which isn't in xenial at all.

Must have applied it to the wrong version. Will redo and upload another diff.

This bug was fixed in the package python-pymysql - 0.7.6-1ubuntu1

---------------
python-pymysql (0.7.6-1ubuntu1) yakkety; urgency=medium

  * Fix ftfs with MySQL 5.7
    - d/run_tests.sh was using old MySQL initialization. Updated for 5.7:
      - Switched mysql_install_db with mysqld --initialize
      - Removed deprecated option --skip-grant from mysqld
      - Added -uroot to client commands
    (LP: #1592664)

 -- Lars Tangvald <email address hidden> Tue, 05 Jul 2016 10:37:47 +0200

New patch for Xenial, for the correct version (0.7.2)

Debdiff in comment #19 looks good. Uploaded for processing by the SRU team.

Thanks!

Hello Matthias, or anyone else affected,

Accepted python-pymysql into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-pymysql/0.7.2-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

The fix for this bug has been awaiting testing feedback in the -proposed repository for xenial for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

New package 0.7.2-1ubuntu1 verified to build successfully on Xenial, and all tests pass (this is what failed previously, see [Test Case].
Also verified that the previous version still fails as described in the bug description.

(Sorry, I missed the comment asking for verification)

Setting it to verified since it was a build failure issue, and it builds in proposed now

This bug was fixed in the package python-pymysql - 0.7.2-1ubuntu1

---------------
python-pymysql (0.7.2-1ubuntu1) xenial; urgency=medium

  * Fix ftbfs for MySQL 5.7
   - Update database initialization in d/run_tests.sh for 5.7:
     - Switch mysql_install_db with mysqld --initialize
     - Replace --skip-grant with --skip-grant-tables (deprecated)
   - Added patch to fix test failure with 5.7
   (LP: #1592664)

 -- Lars Tangvald <email address hidden> Fri, 16 Sep 2016 07:14:50 +0200

The verification of the Stable Release Update for python-pymysql has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.