UCListItem doesn't handle Enter/Return/Space to click/trigger
Bug #1581027 reported by
Cris Dywan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Cris Dywan | ||
Bug Description
Just like UCAbstractButton, it should be possible to press Enter, Return or Space to invoke the clicked signal or trigger the action equivalent to a tap or click on the item.
Related branches
lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/acceptTheListItem
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 172 lines (+63/-19)3 files modifiedsrc/Ubuntu/Components/plugin/uclistitem.cpp (+23/-0)
src/Ubuntu/Components/plugin/uclistitem.h (+1/-0)
tests/unit_x11/tst_components/tst_focus.qml (+39/-19)
lp://staging/~osomon/webbrowser-app/listitems-now-handle-keyboard-activation
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 117 lines (+0/-27)7 files modifiedsrc/app/webbrowser/BookmarksFoldersView.qml (+0/-2)
src/app/webbrowser/BookmarksFoldersViewWide.qml (+0/-1)
src/app/webbrowser/DownloadsPage.qml (+0/-7)
src/app/webbrowser/ExpandedHistoryView.qml (+0/-2)
src/app/webbrowser/HistoryView.qml (+0/-2)
src/app/webbrowser/HistoryViewWide.qml (+0/-11)
src/app/webbrowser/NewTabView.qml (+0/-2)
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → In Progress |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → Medium |
| milestone: | none → 12 |
| status: | New → Fix Committed |
| importance: | Medium → High |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1995+
---------------
ubuntu-ui-toolkit (1.3.1995+
[ Albert Astals Cid ]
* Initialize two variables
physicall
m_
It's not really needed since it's only used in update() if start()
has been called that then initializes m_nextTimeoutTime
But it's always nice to initialize all members.
[ Zsombor Egri ]
* Move PropertyChange into UbuntuToolkit package.
[ Christian Dywan ]
* Merge tests/unit and tests/unit_x11. Fixes LP: #1273696
* UCListItem needs to handle click/trigger by keyboard. Fixes LP: #1581027
* Remove TARGET pointing at "gallery" script
qmake can't tell that it's not a generated file. Fixes LP: #1523093.
[ Zoltan Balogh ]
* Skip unit tests only on Yakketi. Fixes LP: #1588598
[ Tarmac, Zoltán Balogh ]
* OTA12-2016-06-07 landing
-- Zoltán Balogh <email address hidden> Tue, 07 Jun 2016 18:25:12 +0000