Ubuntu
nova package

nova-compute should depend on libvirt-bin.service instead of libvirtd.service

Bug #1567811 reported by Dr. Jens Harbott on 2016-04-08

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
libvirt (Ubuntu)	Fix Released	Undecided	Unassigned
Xenial	Fix Released	Low	Christian Ehrhardt 
nova (Ubuntu)	Fix Released	High	Unassigned	Ubuntu ubuntu-16.04

Bug Description

[Impact]

* libvirt service name was changed from libvirt-bin to libvirtd. Newer
   releases hold an alias to older libvirt-bin name. But any newer guide,
   backport to any other package and such might call the new libvirtd
   name. Yet in the Xenial release we have only the old name being
   libvirt-bin.

* This adds an alias libvirtd to Xenials libvirt-bin, to avoid issues in
maintenance and backports by matching the newer (and the Debian) name
of the service with the alias.

[Test Case]

* try to start it as libvirtd service like "service libvirtd status" just
as any newer guide and any user (or backport) coming from debian will
do.

[Regression Potential]

* Just as we want to prevent issues by inserting a service alias to the
new (and Debian) name there might be issues being caused by that. While
none came up in testing this is still possible.

[Other Info]

* Yes this is a preemptive fix, but suggested by smb who maintains
   libvirt for quite a while now and has lived through the pain when
   things are not fixed preemptively. So I hope this can still be
   considered as a valid SRU

-----

The service definition in /lib/systemd/system/nova-compute.service contains

After=libvirtd.service

however that service does not exist, the correct service name would be libvirt-bin.service. As a result, nova-compute is started too early and fails because it cannot talk to libvirtd after a reboot.

See original description

Tags:

Revision history for this message

James Page (james-page) wrote on 2016-04-08:

Debian-ism as we diff in libvirt from Debian here.

Changed in nova (Ubuntu):
status:	New → Triaged
importance:	Undecided → High
status:	Triaged → Fix Committed
milestone:	none → ubuntu-16.04

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-04-11:

This bug was fixed in the package nova - 2:13.0.0-0ubuntu2

---------------
nova (2:13.0.0-0ubuntu2) xenial; urgency=medium

* d/nova-compute.init.in: Switch dependency on libvirtd -> libvirt-bin
inline with libvirt packaging in Ubuntu (LP: #1567811).

-- James Page <email address hidden> Mon, 11 Apr 2016 11:15:06 +0100

Changed in nova (Ubuntu):
status:	Fix Committed → Fix Released

Christian Ehrhardt  (paelzer) on 2016-09-21

no longer affects:	nova (Ubuntu Xenial)
Changed in libvirt (Ubuntu):
status:	New → Fix Released
Changed in libvirt (Ubuntu Xenial):
status:	New → In Progress
importance:	Undecided → Low
assignee:	nobody → ChristianEhrhardt (paelzer)

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2016-09-21:

I just discussed this with Stefan Bader.
He already had a patch ready when I was cleaning up the git we maintain for Xenial.

In Yakkety we already have the service being libvirtd but with an compat alias to libvirt-bin.
That ensures either names work well in dependencies and eases the transition.

But on Xenial it still is libvirt-bin service. Depending on backports or other unmodified patches this might cause issues by something from Debian depending on libvirtd which wasn't adapted.
To also avoid these issues we add an libvirtd alias to the libvirt-bin service in xenial.

This will allow systemd services which were not modified when merging from Debian to correctly depend on libvirtd. Also will simplify things when we finally get rid of the special naming.

Attaching updated Debdiff for an Ack of SMB (the Author) before upload.
While he does so I'll run some tests against it - package to test is building at https://launchpad.net/~paelzer/+archive/ubuntu/qemu-machine-type-dev/+packages.

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2016-09-21:

debdiff for Stefan Bader (Author) to ack before upload Edit (2.2 KiB, text/plain)

Revision history for this message

Stefan Bader (smb) wrote on 2016-09-21:

Looks good to me -> ACK

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2016-09-21:

log from libvirt tests running against proposed 1.3.1-1ubuntu10.3 Edit (5.1 KiB, text/plain)

Christian Ehrhardt  (paelzer) on 2016-09-21

description:

updated

Revision history for this message

Chris J Arges (arges) wrote on 2016-09-21: Please test proposed package

Hello Dr., or anyone else affected,

Accepted libvirt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.3.1-1ubuntu10.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libvirt (Ubuntu Xenial):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Revision history for this message

Stefan Bader (smb) wrote on 2016-09-26:

Checked the libvirt package from proposed and "systemctl status" works with either libvirt-bin or libvirtd. Expected alias link in /etc/systemd/system exists.

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-10-04:

This bug was fixed in the package libvirt - 1.3.1-1ubuntu10.3

---------------
libvirt (1.3.1-1ubuntu10.3) xenial; urgency=medium

[ Stefan Bader ]
* Add alias for libvirtd.service into libvirt-bin.service (LP: #1567811)

-- Christian Ehrhardt <email address hidden> Wed, 21 Sep 2016 13:46:44 +0200

Changed in libvirt (Ubuntu Xenial):
status:	Fix Committed → Fix Released

Revision history for this message

Chris Halse Rogers (raof) wrote on 2016-10-04: Update Released

#10

The verification of the Stable Release Update for libvirt has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.