Astara

allocations config cannot be created when LB ports exist

Bug #1567163 reported by Adam Gandelman on 2016-04-07

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Astara	Fix Released	High	Adam Gandelman	Astara newton-1
	Mitaka	Fix Committed	High	Unassigned

Bug Description

When astara-orchestrator attempts to create allocation config for a LB appliance, it fails with the following trace:

2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 [req-475724e1-69dd-4951-97b4-3447266770af - - - - -] ConfigureInstance.execute() failed for action: update
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 Traceback (most recent call last):
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/state.py", line 462, in update
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 worker_context,
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/state.py", line 347, in execute
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 self.instance.configure(worker_context)
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/instance_manager.py", line 69, in wrapper
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 state = f(self, *args, **kw)
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/instance_manager.py", line 95, in wrapper
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 return f(self, worker_context, *args, **kw)
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/instance_manager.py", line 671, in configure
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 self.state = self.instances.configure(worker_context)
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/instance_manager.py", line 314, in configure
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 _generate_interface_map(inst, interfaces)
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/drivers/router.py", line 166, in build_config
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 iface_map
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/api/config/router.py", line 55, in build_config
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 interfaces
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/api/config/router.py", line 151, in generate_network_config
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 for p in router.internal_ports)
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/api/config/router.py", line 151, in <genexpr>
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 for p in router.internal_ports)
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/api/config/common.py", line 33, in network_config
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 network_ports=network_ports)
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/api/config/common.py", line 46, in _make_network_config_dict
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 'allocations': _allocation_config(network_ports, subnets_dict)}
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/api/config/common.py", line 85, in _allocation_config
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 for fixed in port.fixed_ips
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 File "/var/lib/neutron/master-runtime/local/lib/python2.7/site-packages/astara/api/config/common.py", line 85, in <dictcomp>
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 for fixed in port.fixed_ips
2016-04-07 00:45:35.753 24733 ERROR ak-router-23ab25ef-0a70-435d-a282-9c78197a2940 KeyError: u'00000000-0000-0000-0000-000000000000'

Adam Gandelman (gandelman-a) on 2016-04-07

Changed in astara:
milestone:	none → newton-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-07: Fix proposed to astara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/302489

Changed in astara:
status:	New → In Progress

Adam Gandelman (gandelman-a) on 2016-04-07

Changed in astara:
importance:	Undecided → High
assignee:	nobody → Adam Gandelman (gandelman-a)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-11: Fix merged to astara (master)

Reviewed: https://review.openstack.org/302489
Committed: https://git.openstack.org/cgit/openstack/astara/commit/?id=968c7da141b28d52480fc8aa83f407ae5a76191a
Submitter: Jenkins
Branch: master

commit 968c7da141b28d52480fc8aa83f407ae5a76191a
Author: Adam Gandelman <email address hidden>
Date: Wed Apr 6 18:28:19 2016 -0700

Skip all types of service ports when creating allocation config

    When astara creates allocation config, it has always skipped
    service ports (historically VRRP ports), but it currently does not
    skip LB ports. This adds some constants where we can define astara's
    service port labels and expand in the future, and takes these into
    account when deciding which ports to leave out of allocation config.

Change-Id: I6d815b1e7e6e24120ad7fd9becc94a216bfb625b
Closes-bug: #1567163

Changed in astara:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-12: Fix merged to astara (stable/mitaka)

Reviewed: https://review.openstack.org/304695
Committed: https://git.openstack.org/cgit/openstack/astara/commit/?id=2991fe157ef4502c4b3d1a266526b672db4e9c22
Submitter: Jenkins
Branch: stable/mitaka

commit 2991fe157ef4502c4b3d1a266526b672db4e9c22
Author: Adam Gandelman <email address hidden>
Date: Wed Apr 6 18:28:19 2016 -0700

Skip all types of service ports when creating allocation config

    Change-Id: I6d815b1e7e6e24120ad7fd9becc94a216bfb625b
    Closes-bug: #1567163
    (cherry picked from commit 968c7da141b28d52480fc8aa83f407ae5a76191a)

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-06-02: Fix included in openstack/astara 9.0.0.0b1

This issue was fixed in the openstack/astara 9.0.0.0b1 development milestone.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.