fixes for thunderx nic in multiqueue mode

Bug #1567091 reported by dann frazier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
High
dann frazier
Xenial
Fix Released
High
dann frazier

Bug Description

There are a number of bug fixes in the thunderx nic driver for multi-queue support that have landed upstream since 4.4:

commit 4fbe366ce304d836d53685c1dd26865dc1fea66c
Merge: 1eea84b ad2eceb
Author: David S. Miller <email address hidden>
Date: Wed Feb 17 22:24:57 2016 -0500

    Merge branch 'thunderx-fixes'

    Sunil Goutham says:

    ====================
    net: thunderx: Miscellaneous fixes

    This patch series fixes couple of issues w.r.t multiqset mode
    and receive packet statastics.
    ====================

    Signed-off-by: David S. Miller <email address hidden>

commit ad2ecebd67d8a80fe5412d11df375a5ed2db7cd1
Author: Sunil Goutham <email address hidden>
Date: Tue Feb 16 16:29:51 2016 +0530

    net: thunderx: Fix receive packet stats

    Counting rx packets for every CQE_RX in CQ irq handler is incorrect.
    Synchronization is missing when multiple queues are receiving packets
    simultaneously. Like transmit packet stats use HW stats here.

    Also removed unused 'cqe_type' parameter in nicvf_rcv_pkt_handler().

    Signed-off-by: Sunil Goutham <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>

commit 8d210d54c5250c52b69266f299e64fe8356f9453
Author: Sunil Goutham <email address hidden>
Date: Tue Feb 16 16:29:50 2016 +0530

    net: thunderx: Fix for HW TSO not enabled for secondary qsets

    For secondary Qsets 'hw_tso' is not getting set as probe() returns
    much earlier. Fixed it by moving silicon revision check.

    Signed-off-by: Sunil Goutham <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>

commit 6a9bab79bb79bd9b2eda16f0aba1b4c43f677be9
Author: Sunil Goutham <email address hidden>
Date: Tue Feb 16 16:29:49 2016 +0530

    net: thunderx: Fix for multiqset not configured upon interface toggle

    When a interface is assigned morethan 8 queues and the logical interface
    is toggled i.e down & up, additional queues or qsets are not initialized
    as secondary qset count is being set to zero while tearing down.

    Signed-off-by: Sunil Goutham <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>

CVE References

Tim Gardner (timg-tpi)
Changed in linux (Ubuntu Xenial):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.5 KiB)

This bug was fixed in the package linux - 4.4.0-21.37

---------------
linux (4.4.0-21.37) xenial; urgency=low

  [ Tim Gardner ]

  * Release Tracking Bug
    - LP: #1571791

  * linux: MokSBState is ignored (LP: #1571691)
    - SAUCE: (noup) MODSIGN: Import certificates from UEFI Secure Boot
    - SAUCE: (noup) efi: Disable secure boot if shim is in insecure mode
    - SAUCE: (noup) Display MOKSBState when disabled

linux (4.4.0-20.36) xenial; urgency=low

  [ Tim Gardner ]

  * Release Tracking Bug
    - LP: #1571069

  * sysfs mount failure during stateful lxd snapshots (LP: #1570906)
    - SAUCE: kernfs: Do not match superblock in another user namespace when
      mounting

  * Kernel Panic in Ubuntu 16.04 netboot installer (LP: #1570441)
    - x86/topology: Fix logical package mapping
    - x86/topology: Fix Intel HT disable
    - x86/topology: Use total_cpus not nr_cpu_ids for logical packages
    - xen/apic: Provide Xen-specific version of cpu_present_to_apicid APIC op
    - x86/topology: Fix AMD core count

  * [regression]: Failed to call clock_adjtime(): Invalid argument
    (LP: #1566465)
    - ntp: Fix ADJ_SETOFFSET being used w/ ADJ_NANO

linux (4.4.0-19.35) xenial; urgency=low

  [ Tim Gardner ]

  * Release Tracking Bug
    - LP: #1570348

  * CVE-2016-2847 (LP: #1554260)
    - pipe: limit the per-user amount of pages allocated in pipes

  * xenial kernel crash on HP BL460c G7 (qla24xx problem?) (LP: #1554003)
    - SAUCE: (noup) qla2xxx: Add irq affinity notification V2

  * arm64: guest hangs when ntpd is running (LP: #1549494)
    - SAUCE: (noup) KVM: arm/arm64: Handle forward time correction gracefully

  * linux: Enforce signed module loading when UEFI secure boot (LP: #1566221)
    - [Config] CONFIG_EFI_SECURE_BOOT_SIG_ENFORCE=y

  * s390/cpumf: Fix lpp detection (LP: #1555344)
    - s390/facilities: use stfl mnemonic instead of insn magic
    - s390/facilities: always use lowcore's stfle field for storing facility bits
    - s390/cpumf: Fix lpp detection

  * s390x kernel image needs weightwatchers (LP: #1536245)
    - [Config] s390x: Use compressed kernel bzImage

  * Surelock GA2 SP1: surelock02p05: Not seeing sgX devices for LUNs after
    upgrading to Ubuntu 16.04 (LP: #1567581)
    - Revert "UBUNTU: SAUCE: (noup) powerpc/pci: Assign fixed PHB number based on
      device-tree properties"

  * Backport upstream bugfixes to ubuntu-16.04 (LP: #1555765)
    - cpufreq: powernv: Define per_cpu chip pointer to optimize hot-path
    - Revert "cpufreq: postfix policy directory with the first CPU in related_cpus"
    - cpufreq: powernv: Add sysfs attributes to show throttle stats

  * systemd-modules-load.service: Failing due to missing module 'ib_iser' (LP: #1566468)
    - [Config] Add ib_iser to generic inclusion list

  * thunderx nic performance improvements (LP: #1567093)
    - net: thunderx: Set recevie buffer page usage count in bulk
    - net: thunderx: Adjust nicvf structure to reduce cache misses

  * fixes for thunderx nic in multiqueue mode (LP: #1567091)
    - net: thunderx: Fix for multiqset not configured upon interface toggle
    - net: thunderx: Fix for HW TSO not enabled for secondary qsets
    - net: thund...

Read more...

Changed in linux (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.