Mahara

Allowing $cfg setting to be json

Bug #1565546 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 16.04.0
16.04
Fix Released
Medium
Robert Lyon
Mahara 16.04.0
16.10
Fix Released
Medium
Unassigned
Mahara 16.10.0

Bug Description

Mahara 16.04

Having an array in a config value can cause problems when the deployment tool doesn't understand arrays. It would be better to be able to use json encoded strings.

1) Allowing $CFG to accept json encoded strings and to be decoded back to php
2) Making the $cfg->openbadgedisplayer_source a json encoded string

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Patch: https://reviews.mahara.org/#/c/6296/

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6296
Committed: https://git.mahara.org/mahara/mahara/commit/af64abec2461ed0aedd85a2d6d287650d15a9203
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit af64abec2461ed0aedd85a2d6d287650d15a9203
Author: Robert Lyon <email address hidden>
Date: Fri Apr 1 11:27:52 2016 +1300

Bug 1565546: Allowing $cfg setting to be json

1) Allowing $CFG to accept json encoded strings and to be decoded back to php
2) Making the $cfg->openbadgedisplayer_source a json encoded string
3) Allowing the openbadges have the defaults only on one place and warn when they are missing

behatnotneeded

Change-Id: Ica0349d6343d9f608b2272117d7412b288799278
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6406

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6406
Committed: https://git.mahara.org/mahara/mahara/commit/f65f4c192cc0c3e407ef71358f604de9d8785fe8
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit f65f4c192cc0c3e407ef71358f604de9d8785fe8
Author: Robert Lyon <email address hidden>
Date: Fri Apr 1 11:27:52 2016 +1300

Bug 1565546: Allowing $cfg setting to be json

1) Allowing $CFG to accept json encoded strings and to be decoded back to php
2) Making the $cfg->openbadgedisplayer_source a json encoded string
3) Allowing the openbadges have the defaults only on one place and warn when they are missing

behatnotneeded

Change-Id: Ica0349d6343d9f608b2272117d7412b288799278
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit af64abec2461ed0aedd85a2d6d287650d15a9203)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.