4 webbrowser-app unit test failures with staging UITK
Bug #1554447 reported by
Olivier Tilloy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Critical
|
Zoltan Balogh | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Critical
|
Zsombor Egri | ||
ubuntu-ui-toolkit (Ubuntu RTM) |
Fix Released
|
Critical
|
Unassigned | ||
webbrowser-app (Ubuntu) |
Invalid
|
Undecided
|
Unassigned |
Bug Description
Running webbrowser-app’s unit tests with the latest staging branch of the UITK as of today (lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging at revision 1885), I’m seeing 4 unit test failures (see full log attached).
Looking into those failures, it appears that they all have the same root cause: they expect a KeyUp/KeyDown event to transfer active focus from a listview to another element, and that doesn’t happen. https:/
Related branches
lp://staging/~zsombi/ubuntu-ui-toolkit/listViewProxyBug
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Tim Peeters: Approve
- Olivier Tilloy (community): Approve
-
Diff: 74 lines (+40/-2)2 files modifiedsrc/Ubuntu/Components/plugin/privates/listviewextensions.cpp (+4/-2)
tests/unit_x11/tst_components/tst_listitem_focus.qml (+36/-0)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → Critical |
assignee: | nobody → Zsombor Egri (zsombi) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
status: | New → Fix Committed |
importance: | Undecided → Critical |
affects: | ubuntu-ui-toolkit (Ubuntu) → canonical-devices-system-image |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → Critical |
status: | New → Fix Committed |
Changed in canonical-devices-system-image: | |
assignee: | Zsombor Egri (zsombi) → Zoltan Balogh (bzoltan) |
status: | Fix Committed → In Progress |
milestone: | none → 11 |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Changed in webbrowser-app (Ubuntu): | |
status: | New → Invalid |
To post a comment you must log in.
Without further investigation, the following patch fixes 3 of the 4 failures (I haven’t checked whether it doesn’t break other things in the UITK though):
=== modified file 'src/Ubuntu/ Components/ plugin/ privates/ listviewextensi ons.cpp' Components/ plugin/ privates/ listviewextensi ons.cpp 2016-03-01 15:08:08 +0000 Components/ plugin/ privates/ listviewextensi ons.cpp 2016-03-08 09:55:06 +0000 dex();
--- src/Ubuntu/
+++ src/Ubuntu/
@@ -141,11 +141,12 @@
int currentIndex = this->currentIn
int count = this->count();
+ int oldIndex = currentIndex;
currentIndex = qBound<int>(0, forwards ? currentIndex - 1 : currentIndex + 1, count - 1);
setCurrentInd ex(currentIndex );
setKeyNavigat ionForListView( true);
if (currentIndex >= 0 && count > 0) {
}
- return true;
+ return (oldIndex != currentIndex);
}