[regression] favicons not stored in the history database
Bug #1549780 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Bill Filler | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy | ||
Bug Description
This appears to be a rather recent regression: if I open the history view all entries before the 1st of February have icons, entries newer than that don’t.
At a first glance, there’s no related change in webbrowser-app’s code base that could possibly explain this regression.
However this would more or less coincide with when oxide 1.12 was released. I wonder if the regression could possibly be in oxide.
Related branches
lp://staging/~osomon/webbrowser-app/historyUpdateOnLoadCommitted
- Riccardo Padovani (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 391 lines (+229/-40)6 files modifiedsrc/app/webbrowser/Browser.qml (+29/-2)
src/app/webbrowser/history-model.cpp (+37/-1)
src/app/webbrowser/history-model.h (+2/-1)
tests/autopilot/webbrowser_app/tests/http_server.py (+32/-1)
tests/autopilot/webbrowser_app/tests/test_history.py (+80/-34)
tests/unittests/history-model/tst_HistoryModelTests.cpp (+49/-1)
Revision history for this message
| Olivier Tilloy (osomon) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Olivier Tilloy (osomon) |
| importance: | Undecided → High |
| status: | New → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | New → Fix Committed |
| importance: | Undecided → High |
| assignee: | nobody → Bill Filler (bfiller) |
| milestone: | none → ww08-2016 |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
What I’m seeing happen is that we get a LoadSucceeded event from oxide, which triggers an insertion in the history database, but at that point in time the 'icon' property of the webview is empty. A few milliseconds afterwards, the 'icon' property is updated.