[webapp-container] Outside links don't always open in overlay
Bug #1548575 reported by
Michael Terry
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Medium
|
David Barth | ||
Ubuntu UX |
New
|
Undecided
|
Unassigned | ||
webapps-sprint |
Fix Released
|
Medium
|
Alexandre Abreu | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Alexandre Abreu |
Bug Description
I made two webapps. In one, outside links always open in a container overlay. In the other, they open in the browser app.
I *think* the only difference is that the overlay-webapp happens to use target=_blank for the links, while the browser-webapp doesn't.
I personally think that both types of outside links should open in an overlay. If you agree and this is simply a bug, let's fix it.
If it's not a bug, can there be a commandline option to override this behavior (i.e. control whether outside links open in an overlay or not)?
Related branches
lp://staging/~abreu-alexandre/webbrowser-app/command-line-option-external-urls-in-overlay
- Alberto Mardegan (community): Approve
- David Barth (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 272 lines (+82/-17)9 files modifiedsrc/app/webcontainer/PopupWindowController.qml (+2/-2)
src/app/webcontainer/PopupWindowOverlay.qml (+7/-4)
src/app/webcontainer/WebApp.qml (+1/-0)
src/app/webcontainer/WebViewImplOxide.qml (+19/-9)
src/app/webcontainer/WebappContainerWebview.qml (+3/-1)
src/app/webcontainer/webapp-container.cpp (+5/-0)
src/app/webcontainer/webapp-container.h (+1/-0)
src/app/webcontainer/webapp-container.qml (+2/-0)
tests/autopilot/webapp_container/tests/test_url_patterns.py (+42/-1)
Changed in webbrowser-app (Ubuntu): | |
assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
Changed in webapps-sprint: | |
milestone: | none → sprint-19 |
assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
Changed in webapps-sprint: | |
status: | New → In Progress |
Changed in webbrowser-app (Ubuntu): | |
status: | New → In Progress |
Changed in webbrowser-app (Ubuntu): | |
importance: | Undecided → Medium |
Changed in webapps-sprint: | |
importance: | Undecided → Medium |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → Medium |
assignee: | nobody → David Barth (dbarth) |
milestone: | none → 11 |
Changed in webapps-sprint: | |
status: | In Progress → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
It is not a bug it is the intended behavior, the decision to change the behavior to open an overlay in all the highlighted situations does not seem as obvious to me since the websites intent is slightly different in the two cases.
A command line option might be a good intermediate solution until we have a more definitive answer.