Some scopes are not ready for changes in search semantics
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Alejandro J. Cura | ||
Ubuntu Rest Scopes |
New
|
Undecided
|
Unassigned | ||
unity-scope-click (Ubuntu) |
Fix Released
|
High
|
Paweł Stołowski |
Bug Description
Some scopes are still not updated to correctly handle the change in search semantics (to be released with support for filters), that is to allow searching inside departments and displaying departments if search string is not empty (rather than doing search "globally", and only allow departments to be browsed).
This bug is to track any remaining scopes that needs updating.
Long explanation:
The change is in the semantics of the search in the UI. In the
old designs search was designed to be "global", i.e. if you
start typing, departments menu disappears and the search is
"broad". Departments were meant to be used and displayed only
for browsing, i.e. when search query is empty and departments
navigation is used. This search semantics is partially
reflected in the search logic of some scopes.
In the new approach unity shell plugin will no longer reset
current department to "root" nor hide departments menu when
you start typing a query, meaning you can search inside
departments. Some scopes may not expect this and have a simple
search logic along these lines (pseudo-code for better
clarity):
if (search_
} else { // empty search string
}
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- dobey (community): Approve
-
Diff: 514 lines (+132/-57)13 files modifiedlibclickscope/click/index.cpp (+2/-2)
libclickscope/click/index.h (+1/-1)
libclickscope/click/interface.cpp (+1/-1)
libclickscope/tests/integration/webclient_integration.cpp (+1/-1)
libclickscope/tests/test_index.cpp (+9/-9)
scope/clickapps/apps-query.cpp (+3/-5)
scope/clickstore/store-query.cpp (+18/-2)
scope/clickstore/store-query.h (+1/-0)
scope/tests/test_apps_query.cpp (+34/-18)
scope/tests/test_helpers.h (+22/-4)
scope/tests/test_query.cpp (+40/-12)
tests/scope-harness/tests/test_apps.py (+0/-1)
tests/scope-harness/tests/test_store.py (+0/-1)
Changed in unity-scope-click (Ubuntu): | |
importance: | Undecided → High |
assignee: | nobody → Pawel Stolowski (stolowski) |
status: | New → Confirmed |
status: | Confirmed → In Progress |
description: | updated |
description: | updated |
description: | updated |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Alejandro J. Cura (alecu) |
importance: | Undecided → High |
milestone: | none → ww08-2016 |
status: | New → Triaged |
Changed in canonical-devices-system-image: | |
status: | Triaged → In Progress |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
This bug was fixed in the package unity-scope-click - 0.1.1+16. 04.20160321- 0ubuntu1
--------------- 16.04.20160321- 0ubuntu1) xenial; urgency=medium
unity-scope-click (0.1.1+
[ Pawel Stolowski ]
* Always push departments (departments should be available also in
search mode) and allow searching inside departments. (LP: #1541025)
-- Michael Zanetti <email address hidden> Mon, 21 Mar 2016 10:00:50 +0000