Ubuntu
unity-scopes-shell package

Dash doesn't accept input (appears frozen) after youtube scope auth

Bug #1534541 reported by Paweł Stołowski
44
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Michał Sawicz
Canonical System Image 10 "OTA10"
Mir
Invalid
Undecided
Unassigned
ubuntu-system-settings-online-accounts (Ubuntu)
Invalid
Undecided
Unassigned
unity-scopes-shell (Ubuntu)
Invalid
Critical
Unassigned
unity8 (Ubuntu)
Fix Released
Critical
Nick Dedekind

Bug Description

1. Make sure youtube scope is not favorited.
2. Remove Google account from Accounts settings.
3. Open youtube scope via Manage Dash
4. Hit the orange 'Log-in to..' button
5. Authenticate with google.
6. Wait till youtube results are refreshed.

The dash appears frozen now. It doesn't crash though, in fact the process is running and the dash responds to the dbus signal which invalidates current scope and forces a refresh (tested with dbus-send --session --type=signal '/com/canonical/unity/scopes' com.canonical.unity.scopes.InvalidateResults string:'clickscope').

Note, the launcher as well as apps still receive input and work ok.

See original description
Tags: testcase

Related branches

lp://staging/~nick-dedekind/unity8/1534541.zombie-session
Albert Astals Cid (community): Approve
Marcus Tomlinson (community): Approve
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Unity8 CI Bot: Needs Fixing (continuous-integration)
Diff: 203 lines (+53/-29)
5 files modified
qml/Stages/SessionContainer.qml (+2/-0)
tests/mocks/Unity/Application/ApplicationTestInterface.cpp (+4/-4)
tests/mocks/Unity/Application/ApplicationTestInterface.h (+2/-2)
tests/qmltests/Stages/RecursingChildSessionControl.qml (+3/-3)
tests/qmltests/Stages/tst_SessionContainer.qml (+42/-20)
lp://staging/~ci-train-bot/unity8/unity8-ubuntu-xenial-landing-064
Unity Team: Pending requested
Diff: 10220 lines (+4844/-1194)
151 files modified
CMakeLists.txt (+1/-1)
cmake/modules/QmlTest.cmake (+1/-1)
data/com.canonical.Unity8.gschema.xml (+11/-0)
data/unity8-dash.conf (+1/-0)
debian/changelog (+91/-0)
debian/control (+7/-6)
debian/unity8-common.udev (+2/-0)
debian/unity8-doc.install (+1/-0)
doc/devices.conf (+30/-0)
plugins/AccountsService/AccountsService.cpp (+244/-397)
plugins/AccountsService/AccountsService.h (+26/-21)
plugins/AccountsService/AccountsServiceDBusAdaptor.cpp (+11/-4)
plugins/AccountsService/AccountsServiceDBusAdaptor.h (+5/-6)
plugins/Dash/AudioProgressBar.qml (+1/-0)
plugins/Dash/CardCreator.js (+69/-34)
plugins/Dash/CardCreatorCache.qml (+3/-3)
plugins/Dash/plugin.cpp (+6/-6)
plugins/GlobalShortcut/globalshortcutregistry.cpp (+4/-4)
plugins/IntegratedLightDM/liblightdm/CMakeLists.txt (+16/-3)
plugins/IntegratedLightDM/liblightdm/UsersModel.cpp (+4/-18)
plugins/IntegratedLightDM/liblightdm/UsersModel.h (+1/-1)
plugins/IntegratedLightDM/liblightdm/UsersModelPrivate.cpp (+44/-10)
plugins/IntegratedLightDM/liblightdm/UsersModelPrivate.h (+15/-3)
plugins/Unity/Indicators/indicatorsmanager.cpp (+2/-2)
plugins/Unity/Indicators/rootstateparser.h (+1/-0)
plugins/Unity/Launcher/desktopfilehandler.cpp (+2/-2)
plugins/Unity/Launcher/launcheritem.cpp (+1/-0)
plugins/Unity/Launcher/launcheritem.h (+1/-1)
plugins/Unity/Launcher/launchermodel.cpp (+15/-5)
plugins/Unity/Launcher/launchermodel.h (+1/-1)
plugins/Utils/CMakeLists.txt (+1/-0)
plugins/Utils/deviceconfigparser.cpp (+150/-0)
plugins/Utils/deviceconfigparser.h (+62/-0)
plugins/Utils/plugin.cpp (+2/-0)
po/unity8.pot (+29/-27)
qml/Components/EdgeBarrier.qml (+1/-1)
qml/Components/InputMethod.qml (+1/-9)
qml/Components/Lockscreen.qml (+86/-100)
qml/Components/ModeSwitchWarningDialog.qml (+1/-1)
qml/Components/PassphraseLockscreen.qml (+5/-4)
qml/Components/PhysicalKeysMapper.qml (+24/-0)
qml/Components/PinLockscreen.qml (+22/-1)
qml/Components/ShellDialog.qml (+8/-0)
qml/Dash/CardCarousel.qml (+0/-1)
qml/Dash/CardGrid.qml (+0/-1)
qml/Dash/CardHorizontalList.qml (+0/-1)
qml/Dash/CardTool.qml (+2/-26)
qml/Dash/CardVerticalJournal.qml (+0/-1)
qml/Dash/Dash.qml (+11/-11)
qml/Dash/GenericScopeView.qml (+2/-0)
qml/Dash/Previews/PreviewHeader.qml (+37/-9)
qml/Dash/Previews/PreviewOverlay.qml (+1/-1)
qml/Dash/Previews/PreviewSharing.qml (+17/-7)
qml/Dash/ScopesListCategoryItem.qml (+8/-4)
qml/DeviceConfiguration.qml (+56/-18)
qml/DisabledScreenNotice.qml (+44/-20)
qml/Greeter/CoverPage.qml (+13/-2)
qml/Greeter/Infographics.qml (+2/-1)
qml/Greeter/NarrowView.qml (+14/-1)
qml/Launcher/Launcher.qml (+144/-11)
qml/Launcher/LauncherDelegate.qml (+55/-20)
qml/Launcher/LauncherPanel.qml (+122/-51)
qml/Launcher/graphics/launcher-app-focus-ring.svg (+12/-0)
qml/Notifications/Notification.qml (+6/-2)
qml/OrientedShell.qml (+26/-1)
qml/Panel/Handle.qml (+2/-2)
qml/Panel/Indicators/MenuItemFactory.qml (+0/-1)
qml/Panel/IndicatorsMenu.qml (+1/-1)
qml/Panel/Panel.qml (+5/-1)
qml/ScopeTool.qml (+0/-8)
qml/Shell.qml (+51/-1)
qml/Stages/AbstractStage.qml (+3/-1)
qml/Stages/DesktopSpread.qml (+64/-17)
qml/Stages/DesktopSpreadDelegate.qml (+15/-1)
qml/Stages/DesktopStage.qml (+34/-34)
qml/Stages/PhoneStage.qml (+77/-3)
qml/Stages/SpreadDelegate.qml (+20/-0)
qml/Stages/TabletStage.qml (+83/-3)
qml/Stages/WindowResizeArea.qml (+8/-5)
src/CMakeLists.txt (+1/-1)
src/CachingNetworkManagerFactory.cpp (+2/-2)
src/CachingNetworkManagerFactory.h (+3/-2)
src/Dash/CMakeLists.txt (+1/-1)
tests/autopilot/unity8/dash.py (+1/-2)
tests/autopilot/unity8/shell/tests/test_helpers.py (+0/-2)
tests/mocks/GSettings.1.0/fake_gsettings.cpp (+64/-0)
tests/mocks/GSettings.1.0/fake_gsettings.h (+18/-0)
tests/mocks/IntegratedLightDM/liblightdm/UsersModel.cpp (+0/-14)
tests/mocks/Unity/Application/MirSurface.cpp (+6/-2)
tests/mocks/Unity/Application/MirSurface.h (+2/-1)
tests/mocks/Unity/Application/SurfaceManager.cpp (+8/-9)
tests/mocks/Unity/Application/SurfaceManager.h (+3/-3)
tests/mocks/Unity/Application/VirtualKeyboard.cpp (+3/-2)
tests/mocks/Unity/Application/VirtualKeyboard.h (+1/-1)
tests/mocks/Unity/Application/plugin.cpp (+2/-1)
tests/mocks/Unity/Launcher/MockLauncherModel.cpp (+2/-0)
tests/mocks/Utils/CMakeLists.txt (+1/-0)
tests/mocks/Utils/plugin.cpp (+2/-0)
tests/plugins/AccountsService/CMakeLists.txt (+5/-0)
tests/plugins/AccountsService/PropertiesServer.cpp (+16/-4)
tests/plugins/AccountsService/PropertiesServer.h (+2/-1)
tests/plugins/AccountsService/UscServer.cpp (+28/-0)
tests/plugins/AccountsService/UscServer.h (+39/-0)
tests/plugins/AccountsService/client.cpp (+63/-9)
tests/plugins/AccountsService/interfaces.xml (+16/-0)
tests/plugins/AccountsService/server.cpp (+12/-0)
tests/plugins/Dash/cardcreator/1.res (+4/-6)
tests/plugins/Dash/cardcreator/1.res.cardcreator (+119/-0)
tests/plugins/Dash/cardcreator/10.res (+3/-5)
tests/plugins/Dash/cardcreator/10.res.cardcreator (+137/-0)
tests/plugins/Dash/cardcreator/11.res (+5/-7)
tests/plugins/Dash/cardcreator/11.res.cardcreator (+210/-0)
tests/plugins/Dash/cardcreator/2.res (+3/-5)
tests/plugins/Dash/cardcreator/2.res.cardcreator (+136/-0)
tests/plugins/Dash/cardcreator/3.res (+3/-5)
tests/plugins/Dash/cardcreator/3.res.cardcreator (+137/-0)
tests/plugins/Dash/cardcreator/4.res (+3/-5)
tests/plugins/Dash/cardcreator/4.res.cardcreator (+109/-0)
tests/plugins/Dash/cardcreator/5.res (+5/-7)
tests/plugins/Dash/cardcreator/5.res.cardcreator (+156/-0)
tests/plugins/Dash/cardcreator/6.res (+2/-4)
tests/plugins/Dash/cardcreator/6.res.cardcreator (+126/-0)
tests/plugins/Dash/cardcreator/7.res (+3/-5)
tests/plugins/Dash/cardcreator/7.res.cardcreator (+149/-0)
tests/plugins/Dash/cardcreator/8.res (+3/-5)
tests/plugins/Dash/cardcreator/8.res.cardcreator (+107/-0)
tests/plugins/Dash/cardcreator/9.res (+4/-5)
tests/plugins/Dash/cardcreator/9.res.cardcreator (+119/-0)
tests/plugins/Dash/cardcreatortest.cpp (+35/-25)
tests/plugins/Dash/cardcreatortest.qml (+4/-4)
tests/plugins/IntegratedLightDM/CMakeLists.txt (+25/-0)
tests/plugins/IntegratedLightDM/integrated.cpp (+91/-0)
tests/plugins/Utils/CMakeLists.txt (+7/-1)
tests/plugins/Utils/DeviceConfigParserTest.cpp (+70/-0)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/Components/tst_Lockscreen.qml (+14/-7)
tests/qmltests/Dash/Previews/tst_PreviewHeader.qml (+18/-1)
tests/qmltests/Dash/Previews/tst_PreviewSharing.qml (+17/-3)
tests/qmltests/Dash/tst_CardTool.qml (+4/-4)
tests/qmltests/Dash/tst_Dash.qml (+89/-0)
tests/qmltests/Greeter/tst_NarrowView.qml (+9/-0)
tests/qmltests/Launcher/tst_Launcher.qml (+254/-18)
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml (+2/-4)
tests/qmltests/Stages/tst_DesktopStage.qml (+2/-1)
tests/qmltests/Stages/tst_PhoneStage.qml (+19/-6)
tests/qmltests/Stages/tst_SpreadDelegate.qml (+7/-0)
tests/qmltests/Stages/tst_TabletStage.qml (+19/-1)
tests/qmltests/tst_DeviceConfiguration.qml (+49/-0)
tests/qmltests/tst_DisabledScreenNotice.qml (+76/-2)
tests/qmltests/tst_OrientedShell.qml (+1/-1)
tests/qmltests/tst_Shell.qml (+243/-61)
Revision history for this message
Paweł Stołowski (stolowski) wrote :
Changed in unity-scopes-shell (Ubuntu):
importance: Undecided → Critical
Paweł Stołowski (stolowski)
summary: - Dash doesn't accept input (appears frozen) after scope auth
+ Dash doesn't accept input (appears frozen) after youtube scope auth
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
importance: Undecided → Critical
assignee: nobody → kevin gunn (kgunn72)
status: New → Confirmed
Changed in unity-scopes-shell (Ubuntu):
status: New → Confirmed
Changed in canonical-devices-system-image:
milestone: none → ww02-2016
Paweł Stołowski (stolowski)
description: updated
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Confirmed on latest rc-proposed (krillin 231). The dash doesn't receive any input but the launcher, the indicators, the greeter or any app launched from the launcher work fine.

tags: added: testcase
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Some more observations / remarks:

- I cannot reproduce it with Facebook scope (which uses similiar auth scenario - i.e. a special card in the scope search results, as opposed to authentication from a preview).
- I cannot reproduce it with Ubuntu Store scope (which uses different auth scenario - from a preview).
- I'm able to reproduce with Youtube scope every time.

In all authentication scenarios the dash calls into online accounts api. For the duration of authentication (i.e. when the auth prompt is displayed), the dash runs a QEventLoop with disabled input processing, so that it's not possible to interact with the dash until auth fails or succeeds:

    QEventLoop loop;
    connect(&future_watcher, &QFutureWatcher<void>::finished, &loop, &QEventLoop::quit);
    loop.exec(QEventLoop::ProcessEventsFlag::ExcludeUserInputEvents);

This loop is stopped as soon as auth API finishes processing the prompt (see http://bazaar.launchpad.net/~unity-team/unity-scopes-shell/trunk/view/head:/src/Unity/logintoaccount.cpp).

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

This issue is reproducible on OTA8.5. Given that it is not a regression and a very specific case, I'm dropping the priority and targeting to next OTA.

Changed in canonical-devices-system-image:
importance: Critical → High
milestone: ww02-2016 → ww08-2016
Revision history for this message
Paweł Stołowski (stolowski) wrote :
Revision history for this message
Paweł Stołowski (stolowski) wrote :
Revision history for this message
Paweł Stołowski (stolowski) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: New → Confirmed
Changed in unity8 (Ubuntu):
status: New → Confirmed
Revision history for this message
Alberto Mardegan (mardy) wrote :

I've marked bug 1536100 as a duplicate of this bug, even though that case is quite different: there, it's the Facebook webapp with is not receiving using input after the trusted session terminates.

I don't think that Online Accounts or Oxide can do anything to cause the input to be blocked for *another* process (OA and oxide run in the process that is shown in the trusted session, which should not be able to cause any harm to the initiator of the trusted session, which in this case is the dash).

I'm adding the mir project for investigation.

Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Alberto Mardegan (mardy) wrote :

Have no idea what happened to my comment :-) I meant: "...there, it's the Facebook webapp which is not receiving user input..."

Revision history for this message
Evgeny (zhenchik35026) wrote :

I have simmilar bug when exiting fullscreen mode on youtube. Everything freezes, but I still can move mouse and do ctrl+alt+f1.

Revision history for this message
kevin gunn (kgunn72) wrote :

we did just release mir0.19 on friday. it was a nontrivial release with bug fixes around input as well.
It would be good to confirm you still see this bug today.

Changed in mir:
status: New → Incomplete
Changed in unity8 (Ubuntu):
assignee: nobody → Nick Dedekind (nick-dedekind)
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

It is still an issue on
current build number: 237
device name: arale
channel: ubuntu-touch/rc-proposed/meizu.en

Changed in mir:
status: Incomplete → Confirmed
Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Please do this to help us debug the situation:

   restart unity8-dash MIR_CLIENT_INPUT_RECEIVER_REPORT=log

Now log in to the device and tail -f unity8-dash.log You should see the input events coming in. Now reproduce the bug. Do the input events keep getting logged?

Changed in mir:
status: Confirmed → Incomplete
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

No events from the client input receiver. or the unity8 server input log; so it seems it's a u8/qtmir issue.

Changed in unity8 (Ubuntu):
importance: Undecided → Critical
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Oh I missed "Note, the launcher as well as apps still receive input and work ok." which makes it very likely Mir is not involved in this bug.

Changed in mir:
status: Incomplete → Invalid
Marcus Tomlinson (marcustomlinson)
Changed in unity-scopes-shell (Ubuntu):
status: Confirmed → Invalid
Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: Confirmed → Invalid
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Nick's branch indeed fixes the issue. Thanks Nick!

Daniel van Vugt (vanvugt)
Changed in unity8 (Ubuntu):
status: Confirmed → In Progress
Michał Sawicz (saviq)
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
assignee: kevin gunn (kgunn72) → Michał Sawicz (saviq)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.11+16.04.20160212-0ubuntu1

---------------
unity8 (8.11+16.04.20160212-0ubuntu1) xenial; urgency=medium

  [ Albert Astals Cid ]
  * Do not use components in card creator generated code
  * Forward the makesurevisible signal from the inner preview widget
  * Make fallback also be fallback when the image is empty and not only
    on error (LP: #1531913)
  * Make the artShapeSize assignment be updated when using dynamic grid
    units
  * Visual improvements to the dash audio play cards
  * We don't use the unity-scope-scopes anymore (LP: #1439172)

  [ Andrea Cimitan ]
  * only request a bigger image if zoomable widget data property is
    true, otherwise just leave the screen size (LP: #1536814)

  [ CI Train Bot ]
  * Update translation template

  [ Daniel d'Andrada ]
  * Set initial surface size (LP: #1532974)

  [ Daniel d'Andrada, Michał Sawicz ]
  * Window Size Hints

  [ Florian Boucault ]
  * Splash screen: delay showing the ActivityIndicator by 2 seconds.

  [ Lukáš Tinkl ]
  * Replace the word "phone" with a more generic term "device" in the
    welcome wizard (LP: #1294732, #1543527)

  [ Michael Terry ]
  * Have the tablet greeter set appropriate OSK hints if the user has a
    passcode instead of a passphrase. (LP: #1544173)

  [ Michael Zanetti ]
  * Don't eat mouse events in the edgebarrer

  [ Michał Sawicz ]
  * Bump unity-api dependencies

  [ Nick Dedekind ]
  * Added support for secondary indicator actions (LP: #1398888)
  * Remove zombie if they're not animated. (LP: #1534541)
  * Removed unused panel resources

  [ Ted Gould ]
  * Start the indicators after Unity8 starts instead of before

 -- Michał Sawicz <email address hidden> Fri, 12 Feb 2016 00:12:41 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Michał Sawicz (saviq)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.