Shortcuts still active in settings page
Bug #1524353 reported by
Michael Sheldon
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Medium
|
Bill Filler | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Olivier Tilloy |
Bug Description
Steps to reproduce
1) Open a couple of new tabs
2) Go to the settings page
3) Press Ctrl-W
4) Close the settings page
Expected result
All the tabs you opened should still be there
Actual result
A tab was closed in the background when you pressed Ctrl-W
Related branches
lp://staging/~osomon/webbrowser-app/keyboard-shortcuts-focus-fixes
- Ugo Riboni (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 333 lines (+93/-48)2 files modifiedsrc/app/webbrowser/Browser.qml (+52/-47)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+41/-1)
Changed in webbrowser-app (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in webbrowser-app (Ubuntu): | |
status: | Triaged → In Progress |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → Medium |
assignee: | nobody → Bill Filler (bfiller) |
milestone: | none → ww02-2016 |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think this is a regression introduced by https:/ /bazaar. launchpad. net/~phablet- team/webbrowser -app/trunk/ revision/ 1280.
The Chrome instance used to be parented to a FocusScope which wasn’t visible when the settings page was, but it was moved out of that focus scope. The relevant keyboard shortcuts are disabled when the chrome isn’t visible, but that condition is not valid any longer, it needs to be updated.