Ubuntu
indicator-sound package

Doesn't update range when volume boost option is enabled

Bug #1512798 reported by Sebastien Bacher
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Alejandro J. Cura
Canonical System Image ww02-2016 "ota9"
indicator-sound (Ubuntu)
Fix Released
High
Xavi Garcia
Xenial
Fix Released
High
Xavi Garcia

Bug Description

Using wily on unity7
- open unity-control-center
- go the sound panel
- enable the over 100% option

The indicator slider and notifications when mouse wheel scrolling over the indicator don't reflect the new range, that regressed with that upload

" [ Charles Kerr ]
  * When showing a "Loud volumes can damage your hearing" confirmation
    warning, clamp the volume until the user hits "OK". (LP: #1481913)"

Related branches

lp://staging/~xavi-garcia-mena/indicator-sound/bug-1512798-reenable-amplified-volume
Charles Kerr (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 73 lines (+28/-1)
2 files modified
src/service.vala (+26/-0)
src/volume-control.vala (+2/-1)
lp://staging/~xavi-garcia-mena/indicator-sound/action-sync-volume
Nick Dedekind (community): Approve
Charles Kerr (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 627 lines (+307/-25)
13 files modified
src/service.vala (+30/-9)
src/sound-menu.vala (+7/-4)
src/volume-control-pulse.vala (+20/-0)
src/volume-control.vala (+7/-0)
tests/CMakeLists.txt (+2/-2)
tests/dbus-types/CMakeLists.txt (+3/-1)
tests/dbus-types/dbus-action-result.cpp (+93/-0)
tests/dbus-types/dbus-action-result.h (+50/-0)
tests/dbus-types/dbus-types.h (+2/-0)
tests/dbus-types/org.gtk.Actions.xml (+5/-0)
tests/integration/indicator-sound-test-base.cpp (+66/-0)
tests/integration/indicator-sound-test-base.h (+6/-0)
tests/integration/test-indicator.cpp (+16/-9)
Sebastien Bacher (seb128)
Changed in indicator-sound (Ubuntu):
importance: Undecided → High
tags: added: rls-x-incoming
Charles Kerr (charlesk)
Changed in indicator-sound (Ubuntu):
assignee: nobody → Xavi Garcia (xavi-garcia-mena)
Will Cooke (willcooke)
tags: removed: rls-x-incoming
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in indicator-sound (Ubuntu):
status: New → Confirmed
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Alejandro J. Cura (alecu)
milestone: none → ww02-2016
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.8 KiB)

This bug was fixed in the package indicator-sound - 12.10.2+16.04.20160105.2-0ubuntu1

---------------
indicator-sound (12.10.2+16.04.20160105.2-0ubuntu1) xenial; urgency=medium

  [ Xavi Garcia Mena ]
  * Adds an action to signal the UI to sync the current volume when we
    are waiting for the user to confirm or reject the high volume
    notification. (LP: #1520548, #1512798)
  * This branch just readds the OSD notifications code, that was
    reverted in trunk as the corresponding silo was also rolled back
    after landing.
  * This branch re-adds the integration tests using gmenuharness. Added
    OSD notifications to show output source when the volume or source
    change (LP: #1382548, LP: #1415480, LP: #1484589) debian/control:
    Added the following build dependencies: cmake-extras (>= 0.4),
    google-mock (>= 1.6.0+svn437), libqtdbusmock1-dev (>= 0.3),
    libqtdbustest1-dev, libunity-api-dev, pulseaudio, qt5-default,
    qtbase5-dev, qtbase5-dev-tools, qtdeclarative5-dev, qtdeclarative5-
    dev-tools Added gmenuharness library for integration tests support.
    New Files: src/gmenuharness/CMakeLists.txt
    src/gmenuharness/MatchResult.cpp src/gmenuharness/MatchUtils.cpp
    src/gmenuharness/MenuItemMatcher.cpp
    src/gmenuharness/MenuMatcher.cpp
    include/unity/gmenuharness/MatchResult.h
    include/unity/gmenuharness/MatchUtils.h
    include/unity/gmenuharness/MenuItemMatcher.h
    include/unity/gmenuharness/MenuMatcher.h Added integration tests
    using gmenuharness New Files: tests/dbus-types/CMakeLists.txt
    tests/dbus-types/com.ubuntu.AccountsService.Sound.xml tests/dbus-
    types/dbus-types.h tests/dbus-
    types/org.PulseAudio.Ext.StreamRestore1.xml tests/dbus-
    types/org.freedesktop.Accounts.xml tests/dbus-
    types/org.freedesktop.DBus.Properties.xml tests/dbus-
    types/org.freedesktop.Notifications.xml tests/dbus-
    types/org.gtk.Actions.xml tests/dbus-types/pulseaudio-volume.cpp
    tests/dbus-types/pulseaudio-volume.h
    tests/integration/CMakeLists.txt tests/integration/indicator-sound-
    test-base.cpp tests/integration/indicator-sound-test-base.h
    tests/integration/main.cpp tests/integration/test-indicator.cpp
    tests/integration/touch-stream-restore.table
    tests/integration/utils/dbus-pulse-volume.cpp
    tests/integration/utils/dbus-pulse-volume.h
    tests/integration/utils/get-volume.cpp tests/integration/utils/set-
    volume.cpp tests/service-mocks/CMakeLists.txt tests/service-
    mocks/DBusPropertiesNotifier.cpp tests/service-
    mocks/DBusPropertiesNotifier.h tests/service-mocks/accounts-
    mock/AccountsDefs.h tests/service-mocks/accounts-
    mock/AccountsMock.cpp tests/service-mocks/accounts-
    mock/AccountsMock.h tests/service-mocks/accounts-
    mock/AccountsServiceSoundMock.cpp tests/service-mocks/accounts-
    mock/AccountsServiceSoundMock.h tests/service-mocks/accounts-
    mock/CMakeLists.txt tests/service-mocks/accounts-
    mock/com.ubuntu.AccountsService.Sound.Mock.xml tests/service-
    mocks/accounts-mock/main.cpp tests/service-mocks/accounts-
    mock/org.freedesktop.Accounts.Mock.xml tests/service-mocks/media-
    player-mpris-mock/CMakeLists.txt tests/ser...

Read more...

Changed in indicator-sound (Ubuntu Xenial):
status: Confirmed → Fix Released
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.