Regression with linked / dynamic offsets (rev >= 14156)

Bug #1507049 reported by su_v
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
Unassigned

Bug Description

Linked or dynamic offsets e.g. of a rectangle in current trunk lack precision, AFAICT (based on tests with archived builds) after the changes in rev 14156 for bug #384688:
https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/14156

Steps to reproduce:
1) launch current trunk with default new prefs, default doc
2) draw a rectangle
3) create linked offset
4) convert to path
5) switch to the node tool to visualize the nodes of the linked offset converted to path

The attached drawing shows a linked offset (radius 20) of duplicated rectangles, created and converted to path with rev 14153 and 14159 on OS X 10.7.5: the results with r14159 are much more imprecise than with r14153.

Tests done with latest trunk r14419 and archived trunk builds on OS X 10.7.5

Todo:
- investigate the scope of regression (types of original shapes, object size, document scale, offset radius ...)

=====
See also:
http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/954/focus=957
(or http://sourceforge.net/p/inkscape/mailman/message/8200775/ )
«the "imprecise" algo is now the more precise one; the problem whith the old "precise" is that sometimes it doesn't produce the mathematically correct offset, but is faster.»

Tags: regression
Revision history for this message
su_v (suv-lp) wrote :
Revision history for this message
su_v (suv-lp) wrote :

A few more examples (open in Inkscape trunk, zoom in to 200% or closer, and compare results from 14153 (green stroke) with r14159 (red stroke)).

Revision history for this message
su_v (suv-lp) wrote :
Revision history for this message
su_v (suv-lp) wrote :

On 2015-10-17 24:56 (+0200), ~suv wrote:
> AFAICT (based on tests with archived builds) after the changes in rev
> 14156 for bug #384688

Side-effect of rev 14156 also confirmed with current trunk r14419: reverting the changes from rev 14156 restores the expected behavior (precision) of dynamic/linked offsets of shapes like rectangles and polygons/stars.

su_v (suv-lp)
description: updated
description: updated
description: updated
Revision history for this message
jazzynico (jazzynico) wrote :

Confirmed on Xubuntu 15.10, Inkscape trunk rev. 14496.

Changed in inkscape:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
su_v (suv-lp) wrote :

In case anyone decides to revert r14156, please comment the change in the source file, as discussed last year on irc:

> 11:09 su_v : tbah: would you consider reverting !revno 14156 ?
> 11:09 InkBot : Revision 14156: tavmjong-free 2015-05-16 Potential fix for 384688 (A linked offset to a text object is malformed...)
> 11:09 InkBot : https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/14156/
> 11:09 su_v : !bug 1507049
> 11:09 InkBot : Bug #1507049: "Regression with linked / dynamic offsets (rev >= 14156)"
> 11:09 InkBot : https://launchpad.net/bugs/1507049
> 15:35 tbah : su_v: Sure... if the "faster" code is better then go ahead and revert it... but put a comment in the code. I won't have time to look at it myself for a few days.

Revision history for this message
su_v (suv-lp) wrote :

Regression is still present in current trunk (r14723) - see also recent thread on inkscape-devel:
http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/47717

Revision history for this message
Jabiertxof (jabiertxof) wrote :

I think this bug is more important than #384688. And if the goal is remove Livarot, I think is better is better put a comment and revert the one line revision 14156, and look for another non livarot solution for SPOffset.
I request for revert on the mailing list.

Revision history for this message
su_v (suv-lp) wrote :

@jazzynico - could you please close this report as 'Fix Released' per rev 14741 and remove the milestone?
Related earlier bug #384688 had not been closed based on the (now reverted) commit - no action to be taken there AFAICT, apart from possibly discussing whether to add back the 'blocker' tag for next major release.

Revision history for this message
jazzynico (jazzynico) wrote :

Done!

Changed in inkscape:
milestone: 0.92 → none
status: Triaged → Fix Released
Revision history for this message
Jabiertxof (jabiertxof) wrote :

Sorry I forget do it when revert.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.