Ubuntu
webbrowser-app package

Tab close buttons should use haptics

Bug #1505725 reported by Michael Terry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Medium
Bill Filler
Canonical System Image ww46-2015 "ota8"
webbrowser-app (Ubuntu)
Fix Released
Medium
Ugo Riboni

Bug Description

The tab close buttons should use haptics to indicate a successful button press, like most other buttons on the phone do.

Related branches

lp://staging/~uriboni/webbrowser-app/tabs-use-haptics
PS Jenkins bot: Approve (continuous-integration)
Olivier Tilloy: Approve
Diff: 30 lines (+7/-3)
1 file modified
src/app/webbrowser/TabItem.qml (+7/-3)
Revision history for this message
Olivier Tilloy (osomon) wrote :

The current implementation uses a plain MouseArea, it should use an AbstractButton indeed, and we would get the haptics effect for free (I think).

Changed in webbrowser-app (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Ugo Riboni (uriboni)
Bill Filler (bfiller)
Changed in canonical-devices-system-image:
milestone: none → backlog
assignee: nobody → Bill Filler (bfiller)
importance: Undecided → Medium
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: New → Confirmed
Ugo Riboni (uriboni)
Changed in webbrowser-app (Ubuntu):
status: Triaged → In Progress
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20151103-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20151103-0ubuntu1) xenial; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Olivier Tilloy ]
  * Update translation template.

  [ Ugo Riboni ]
  * Fix a bug preventing in some cases the address bar from getting
    focus when entering find in page mode. Also correctly hide the left
    hand side icons when in find in page mode. (LP: #1508130)
  * Focus the page when opening links with target="_blank". (LP:
    #1505724)
  * Prevent the address bar from being cleared when the actual url
    changes and the user has already started typing. (LP: #1487713)
  * Update the user script to remove the Facebook app banner. (LP:
    #1352783)
  * Use AbstractButton to handle some tab interactions so that haptics
    are used on touch. (LP: #1505725)

 -- Olivier Tilloy <email address hidden> Tue, 03 Nov 2015 11:56:19 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: backlog → ww46-2015
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.