Thumbnailer

Fails to generate thumbnails for filenames without extensions

Bug #1499341 reported by Michael Sheldon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Medium
Alejandro J. Cura
Canonical System Image ww46-2015 "ota8"
Thumbnailer
Fix Released
Medium
Michael Sheldon
thumbnailer (Ubuntu)
Fix Released
Medium
Michi Henning

Bug Description

Steps to reproduce:

 1) Download attached file "image" to /tmp/

 2) Run "thumbnailer-admin get /tmp/image"

Expected result:

 A thumbnail file should be generated

Actual result:

 thumbnailer-admin: Handler::check_finished(): no artwork for thumbnail: /tmp/image (0,0): NO ARTWORK

If you then rename /tmp/image to /tmp/image.jpg and run "thumbnailer-admin get /tmp/image.jpg" a thumbnail will be created correctly

Related branches

lp://staging/~michael-sheldon/thumbnailer/fix-1499341
PS Jenkins bot (community): Approve (continuous-integration)
Michi Henning (community): Approve
Diff: 33 lines (+23/-0)
1 file modified
src/thumbnailer.cpp (+23/-0)
Michi Henning (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 33 lines (+23/-0)
1 file modified
src/thumbnailer.cpp (+23/-0)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :
  • image Edit (2.6 KiB, application/octet-stream)
Michi Henning (michihenning)
Changed in thumbnailer:
assignee: nobody → Michael Sheldon (michael-sheldon)
status: New → Fix Committed
importance: Undecided → Medium
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:thumbnailer/devel at revision 282, scheduled for release in thumbnailer, milestone Unknown

Revision history for this message
Bill Filler (bfiller) wrote :

michi, alecu:
would be great to get another thumbnailer release for ota8 that includes this fix.

Changed in thumbnailer (Ubuntu):
assignee: nobody → Michi Henning (michihenning)
importance: Undecided → Medium
Changed in canonical-devices-system-image:
milestone: none → ww46-2015
assignee: nobody → Alejandro J. Cura (alecu)
importance: Undecided → Medium
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: New → In Progress
Revision history for this message
Michi Henning (michihenning) wrote :

Yes, we'll get this out the door. It turns out that a change in glib 2.22 broke this yet again. It's all about how glibc implements content type detection. James will be back Monday and I need some reviews from him. Once that's done, we can release. We should be able to get this into a silo Tuesday or Wednesday.

Revision history for this message
Michi Henning (michihenning) wrote :

It's in silo 40, if anyone wants to confirm.

Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Michi Henning (michihenning)
Changed in thumbnailer (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thumbnailer - 2.3+16.04.20151102.2-0ubuntu1

---------------
thumbnailer (2.3+16.04.20151102.2-0ubuntu1) xenial; urgency=medium

  [ Michi Henning ]
  * "thumbnailer-admin clear f" now also resets the network retry timeout.
  * API documentation and man page improvements.
  * Videos with embedded artwork now display the artwork thumbnail instead
    of an extracted still frame (LP: #1510801).
  * Added cancelled() accessor to Request class.
  * Requests made via the Qt and QML APIs are correctly rate-limited now.
  * Added trace-client key to gsettings.
  * Service log now shows statistics on start-up.
  * Resetting the stats now also resets the network failure retry timout.
  * Fix for cover art extraction if only a preview cover image is available.

  [ Michael Sheldon ]
  * Added more robust content type detection (LP: #1499341).

  [ CI Train Bot ]
  * debian/libthumbnailer-qt1.0.symbols: update to released version.
  * No-change rebuild.

 -- Michi Henning <email address hidden> Mon, 02 Nov 2015 12:36:56 +0000

Changed in thumbnailer (Ubuntu):
status: Fix Committed → Fix Released
Michi Henning (michihenning)
Changed in thumbnailer:
status: Fix Committed → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.