Ubuntu
ubuntu-system-settings package

Number containing # are incorrectly sent unencoded to url-dispatcher

Bug #1496845 reported by Jonas G. Drange
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Bill Filler
Canonical System Image ww46-2015 "ota8"
address-book-app (Ubuntu)
Invalid
High
Renato Araujo Oliveira Filho
dialer-app (Ubuntu)
Fix Released
High
Tiago Salem Herrmann
ubuntu-system-settings (Ubuntu)
Fix Released
Undecided
Jonas G. Drange

Bug Description

Reproduce:
* Open System Settings and call a SIM Service number containing a #, e.g. +47005#1
* Create a contact in address-book-app with the number “+47005#1” and call it.

What happens:
“+47005” appears in dialer

What should happen:
“+47005#1” should appear in dialer, i.e. affected apps needs to urlencode the number.

See original description

Related branches

lp://staging/~jonas-drange/ubuntu-system-settings/lp1496845
PS Jenkins bot: Needs Fixing (continuous-integration)
Ken VanDine: Approve
Diff: 13 lines (+2/-1)
1 file modified
plugins/phone/ServiceInfo.qml (+2/-1)
lp://staging/~tiagosh/dialer-app/fix-1496845
Gustavo Pichorim Boiko (community): Approve
PS Jenkins bot: Needs Fixing (continuous-integration)
Diff: 58 lines (+15/-7)
2 files modified
src/dialerapplication.cpp (+14/-7)
src/dialerapplication.h (+1/-0)
Jonas G. Drange (jonas-drange)
description: updated
Jonas G. Drange (jonas-drange)
summary: - SIM Service number containing # is (rightfully) eaten by url-dispatcher
+ Number containing # are incorrectly sent unencoded to url-dispatcher
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in address-book-app (Ubuntu):
status: New → Confirmed
Changed in ubuntu-system-settings (Ubuntu):
status: New → Confirmed
Revision history for this message
Peter Bittner (peter-bittner) wrote :

Original report on the mailing list: https://lists.launchpad.net/ubuntu-touch-coreapps/msg00894.html

Jonas G. Drange (jonas-drange)
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Jonas G. Drange (jonas-drange)
status: Confirmed → In Progress
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
assignee: nobody → Bill Filler (bfiller)
importance: Undecided → High
milestone: none → ww40-2015
status: New → In Progress
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Fixed in
 ubuntu-system-settings (0.3+15.04.20151002-0ubuntu1) vivid; urgency=medium
 .
   [ Sebastien Bacher ]
   * [hospot] include cmakefile hack to get files listed in qtcreator
   * [security-privacy] use the system location as well to look for trust
     store items, that's needed at least for unity8-dash which is not
     distributed as a click and doesn't a .local entry (LP: #1501428)
   * [sound] don't display silent mode warnings, sounds should just be
     played when user selected (LP: #1391502)
 .
   [ jonas-drange ]
   * [phone] encode numbers before passing them to url-dispatcher (LP:
     #1496845)
 .

Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+15.10.20151002-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.10.20151002-0ubuntu1) wily; urgency=medium

  [ Sebastien Bacher ]
  * [hospot] include cmakefile hack to get files listed in qtcreator
  * [security-privacy] use the system location as well to look for trust
    store items, that's needed at least for unity8-dash which is not
    distributed as a click and doesn't a .local entry (LP: #1501428)
  * [sound] don't display silent mode warnings, sounds should just be
    played when user selected (LP: #1391502)

  [ jonas-drange ]
  * [phone] encode numbers before passing them to url-dispatcher (LP:
    #1496845)

 -- Ken VanDine <email address hidden> Fri, 02 Oct 2015 17:52:49 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Sebastien Bacher (seb128) wrote :

It's not fix commited yet, the addressbook component still has the issue

Changed in canonical-devices-system-image:
status: Fix Committed → New
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → Confirmed
Changed in address-book-app (Ubuntu):
assignee: nobody → Bill Filler (bfiller)
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
milestone: ww40-2015 → ww46-2015
Bill Filler (bfiller)
Changed in address-book-app (Ubuntu):
assignee: Bill Filler (bfiller) → Renato Araujo Oliveira Filho (renatofilho)
importance: Undecided → High
Renato Araujo Oliveira Filho (renatofilho)
Changed in dialer-app (Ubuntu):
assignee: nobody → Tiago Salem Herrmann (tiagosh)
Sebastien Bacher (seb128)
Changed in dialer-app (Ubuntu):
importance: Undecided → High
status: New → In Progress
Revision history for this message
Peter Bittner (peter-bittner) wrote :

This issue appears to be fixed with OTA-7.

Renato Araujo Oliveira Filho (renatofilho)
Changed in address-book-app (Ubuntu):
status: Confirmed → Invalid
Bill Filler (bfiller)
Changed in canonical-devices-system-image:
milestone: ww46-2015 → ww02-2016
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww02-2016 → ww46-2015
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dialer-app - 0.1+16.04.20151111-0ubuntu1

---------------
dialer-app (0.1+16.04.20151111-0ubuntu1) xenial; urgency=medium

  [ Gustavo Pichorim Boiko ]
  * We really just want to get the index of the account in the active
    accounts list.

  [ Tiago Salem Herrmann ]
  * Avoid removing # and other characters from tel: uri's (LP: #1496845)
  * Fallback to original phone number when format() returns a blank
    string

 -- Gustavo Pichorim Boiko <email address hidden> Wed, 11 Nov 2015 15:17:07 +0000

Changed in dialer-app (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.