juju-core

config-changed error does not cause error state

Bug #1494542 reported by Michael Nelson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Andrew Wilkins
juju-core 1.26-alpha2
1.24
Fix Released
High
Tim Penhey
juju-core 1.24.7
1.25
Fix Released
High
Tim Penhey
juju-core 1.25-beta1

Bug Description

I'm testing a deploy in which, due to an error in a charm, the config-change hook failed, as I can verify by tailing the juju log:

http://paste.ubuntu.com/12332911/

yet juju status for the same service is not in an error state, but rather has:

$ juju status sca-app | grep agent-status -A5
        agent-status:
          current: executing
          message: running commands
          since: 11 Sep 2015 00:05:07Z
          version: 1.24.5.1
        agent-state: started

This leaves the unit in the 'started' state, but I can't do anything like debug-hooks (unit not in error state), upgrade-charm (seems to get queued, but not executed because of the running commands), as juju seems to be convinced that the unit is currently running commands.

$ juju --version
1.24.5-trusty-amd64

See original description
Tags: hooks
Michael Nelson (michael.nelson)
summary: - unit does not go to error state
+ config-changed error does not cause error state
description: updated
Aaron Bentley (abentley)
Changed in juju-core:
status: New → Triaged
importance: Undecided → High
milestone: none → 1.25-beta1
Alexis Bruemmer (alexis-bruemmer)
Changed in juju-core:
milestone: 1.25-beta1 → 1.25-beta2
Tim Penhey (thumper)
Changed in juju-core:
assignee: nobody → Tim Penhey (thumper)
milestone: 1.25-beta2 → 1.26-alpha1
status: Triaged → In Progress
Revision history for this message
Michael Nelson (michael.nelson) wrote :

I reproduced this using the same mojo spec and application code revisions, and have uploaded the machine-0.log and unit log to chinstrap.canonical.com:/home/michaeln/bug-1494542-logs.tgz . I can't see any credentials in there, but it does have exact configurations of our app servers etc. - not sure if that's something to put public on the bug.

Revision history for this message
Tim Penhey (thumper) wrote :

The problem is that the 'juju run' command that is executed immediately after the hook goes into an error state bumps the unit out of the error state and it says it is now running commands.

However when it has finished, it never sets the unit status back to what it was.

The fix is to return it to the previous state when the juju run command has completed.

Andrew Wilkins (axwalk)
Changed in juju-core:
assignee: Tim Penhey (thumper) → Andrew Wilkins (axwalk)
Curtis Hovey (sinzui)
tags: added: hooks
Curtis Hovey (sinzui)
Changed in juju-core:
status: In Progress → Fix Released
Revision history for this message
Andrew Wilkins (axwalk) wrote :

This has not been done for master yet.

Changed in juju-core:
status: Fix Released → In Progress
Revision history for this message
Andrew Wilkins (axwalk) wrote :

Proposed fix for master: https://github.com/juju/juju/pull/3537

Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 1.26-alpha1 → 1.26-alpha2
Andrew Wilkins (axwalk)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.