Murano

HOT-to-MuranoPL converter does not support some parameter types

Bug #1450536 reported by Alexander Tivelkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Kirill Zaitsev
Murano 1.0.1
Juno
Fix Committed
Undecided
Unassigned
Kilo
Fix Committed
Undecided
Unassigned

Bug Description

The converter which transforms HOT templates into MuranoPL classes fails to generate MuranoPL Input properties for heat template parameters having type 'comma_delimited_list'

Also, if the parameter has type 'json' the converter can successfully generate a MuranoPL class, but the generated UI definition does not contain a 'type' attribute for appropriate field, thus the application form cannot be rendered at UI side.

Alexander Tivelkov (ativelkov)
Changed in murano:
milestone: none → liberty-1
assignee: nobody → Alexander Tivelkov (ativelkov)
importance: Undecided → High
Serg Melikyan (smelikyan)
Changed in murano:
status: New → Confirmed
Alexander Tivelkov (ativelkov)
summary: - HOT-to-MuranoPL converter does not support all the parameter types
+ HOT-to-MuranoPL converter does not support some parameter types
Revision history for this message
Serg Melikyan (smelikyan) wrote :

Are these two types are only types that Murano does support?

Revision history for this message
Alexander Tivelkov (ativelkov) wrote :

Yes, all others are supported

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/179173

Changed in murano:
status: Confirmed → In Progress
OpenStack Infra (hudson-openstack)
Changed in murano:
assignee: Alexander Tivelkov (ativelkov) → Stan Lagun (slagun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/179173
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=2affdd5d7a83a2f31f21e8a3c415592cb61e79a2
Submitter: Jenkins
Branch: master

commit 2affdd5d7a83a2f31f21e8a3c415592cb61e79a2
Author: Alexander Tivelkov <email address hidden>
Date: Thu Apr 30 20:22:14 2015 +0300

    Fix for HOT parameter types conversion

    The HOT-to-MuranoPL converter did not support some types for Heat
    Template's input parameters.
    Type 'comma_delimited_list' was not supported at all which was leading
    to unhandled exceptions during package import operation.
    Type 'json' was suported, but the generated UI definition did not
    contain 'type' attribute for appropriate field, which was leading to
    unhadled exceptions when the UI form was about to be displayed.

    This patch fixes both these issues.

    Closes-Bug: #1450536

    Change-Id: I539514cc7cd884f98278cf5c990e8833e1b09259

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

boolean parameter is still not supported. see http://docs.openstack.org/developer/heat/template_guide/hot_spec.html#parameters-section for all types of parameters.

Changed in murano:
status: Fix Committed → Confirmed
assignee: Stan Lagun (slagun) → Kirill Zaitsev (kzaitsev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/185750

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano-dashboard (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/185751

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/185750
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=e89f3f4c3d7d39fe10fd8399a351e88f0a88bc8f
Submitter: Jenkins
Branch: master

commit e89f3f4c3d7d39fe10fd8399a351e88f0a88bc8f
Author: Kirill Zaitsev <email address hidden>
Date: Wed May 27 00:31:29 2015 +0300

    Add support for 'boolean' HOT parameter

    The HOT-to-MuranoPL converter did not support 'boolean' type as Heat
    Template input parameter. This lead to a
    400 'Unsupported parameter type boolean', during package uploads.

    This patch adds support for boolean type, adds .bool() to boolean field
    contracts and adds 'boolean' UI type during UI translation.

    Change-Id: I960473916e70f9e17e5b5b1c228b7efd1deb98b5
    Closes-Bug: #1450536

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/185751
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=cd380da63d95c8a546792c5de25cdc19a4070466
Submitter: Jenkins
Branch: master

commit cd380da63d95c8a546792c5de25cdc19a4070466
Author: Kirill Zaitsev <email address hidden>
Date: Wed May 27 00:38:26 2015 +0300

    Mark BooleanFields as non-required in dynamic_ui

    Due to the way django validates fields having a required=True fieild
    almoust never makes sense. This would mean that user would not be able
    to choose false for the boolean value, that the Field represents,
    because django would raise an error, stating, that the field is
    required.
    This is especially true for fields, generated for HOT template-packages.
    This patch sets required to False for dynamic_ui.

    Change-Id: Ibc36017e37bb7df9f7bde2c53265237b21276fd6
    Related-Bug: #1450536

Kirill Zaitsev (kzaitsev)
tags: added: kilo-backport-potential
Kirill Zaitsev (kzaitsev)
tags: added: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano-dashboard (stable/juno)

Related fix proposed to branch: stable/juno
Review: https://review.openstack.org/196034

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano-dashboard (stable/kilo)

Related fix proposed to branch: stable/kilo
Review: https://review.openstack.org/196035

Serg Melikyan (smelikyan)
Changed in murano:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/197307

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/197309

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/juno)

Reviewed: https://review.openstack.org/197309
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=ea7417075ca87aca1eb919bec065eae8b1f1de3f
Submitter: Jenkins
Branch: stable/juno

commit ea7417075ca87aca1eb919bec065eae8b1f1de3f
Author: Alexander Tivelkov <email address hidden>
Date: Thu Apr 30 20:22:14 2015 +0300

    Fix for HOT parameter types conversion

    The HOT-to-MuranoPL converter did not support some types for Heat
    Template's input parameters.
    Type 'comma_delimited_list' was not supported at all which was leading
    to unhandled exceptions during package import operation.
    Type 'json' was suported, but the generated UI definition did not
    contain 'type' attribute for appropriate field, which was leading to
    unhadled exceptions when the UI form was about to be displayed.

    Also adds support for boolean type, adds .bool() to boolean field
    contracts and adds 'boolean' UI type during UI translation.

    This patch fixes these issues.

    Co-Authored-By: Kirill Zaitsev <email address hidden>

    Closes-Bug: #1450536
    Change-Id: Ic1381b7ea874fb1e4923b5561de03ed9a18ea6d6

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/kilo)

Reviewed: https://review.openstack.org/197307
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=00db32d17c4e7cabfb9b875688c3255a3d273471
Submitter: Jenkins
Branch: stable/kilo

commit 00db32d17c4e7cabfb9b875688c3255a3d273471
Author: Alexander Tivelkov <email address hidden>
Date: Thu Apr 30 20:22:14 2015 +0300

    Fix for HOT parameter types conversion

    The HOT-to-MuranoPL converter did not support some types for Heat
    Template's input parameters.
    Type 'comma_delimited_list' was not supported at all which was leading
    to unhandled exceptions during package import operation.
    Type 'json' was suported, but the generated UI definition did not
    contain 'type' attribute for appropriate field, which was leading to
    unhadled exceptions when the UI form was about to be displayed.

    Also adds support for boolean type, adds .bool() to boolean field
    contracts and adds 'boolean' UI type during UI translation.

    This patch fixes these issues.

    Co-Authored-By: Kirill Zaitsev <email address hidden>

    Closes-Bug: #1450536
    Change-Id: Ic1381b7ea874fb1e4923b5561de03ed9a18ea6d6

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano-dashboard (stable/kilo)

Reviewed: https://review.openstack.org/196035
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=01280b6ae1aff6c2d4994aff433410251dd219f2
Submitter: Jenkins
Branch: stable/kilo

commit 01280b6ae1aff6c2d4994aff433410251dd219f2
Author: Kirill Zaitsev <email address hidden>
Date: Wed May 27 00:38:26 2015 +0300

    Mark BooleanFields as non-required in dynamic_ui

    Due to the way django validates fields having a required=True fieild
    almoust never makes sense. This would mean that user would not be able
    to choose false for the boolean value, that the Field represents,
    because django would raise an error, stating, that the field is
    required.
    This is especially true for fields, generated for HOT template-packages.
    This patch sets required to False for dynamic_ui.

    Change-Id: Ibc36017e37bb7df9f7bde2c53265237b21276fd6
    Related-Bug: #1450536
    (cherry picked from commit cd380da63d95c8a546792c5de25cdc19a4070466)

tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano-dashboard (stable/juno)

Reviewed: https://review.openstack.org/196034
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=c734507e687a788deba811399f756a3c488ea3cc
Submitter: Jenkins
Branch: stable/juno

commit c734507e687a788deba811399f756a3c488ea3cc
Author: Kirill Zaitsev <email address hidden>
Date: Wed May 27 00:38:26 2015 +0300

    Mark BooleanFields as non-required in dynamic_ui

    Due to the way django validates fields having a required=True fieild
    almoust never makes sense. This would mean that user would not be able
    to choose false for the boolean value, that the Field represents,
    because django would raise an error, stating, that the field is
    required.
    This is especially true for fields, generated for HOT template-packages.
    This patch sets required to False for dynamic_ui.

    Change-Id: Ibc36017e37bb7df9f7bde2c53265237b21276fd6
    Related-Bug: #1450536
    (cherry picked from commit cd380da63d95c8a546792c5de25cdc19a4070466)

tags: added: in-stable-juno
Serg Melikyan (smelikyan)
Changed in murano:
milestone: liberty-1 → 1.0.0
Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: 1.0.0 → 1.0.1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano 2015.1.1

This issue was fixed in the openstack/murano 2015.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/murano 2015.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.