Keyboard crashes if provided invalid surrounding data from a client
Bug #1444947 reported by
Michael Sheldon
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Critical
|
Bill Filler | ||
| ubuntu-keyboard |
Fix Released
|
Critical
|
Michael Sheldon | ||
| ubuntu-keyboard (Ubuntu) |
Fix Released
|
Undecided
|
Michael Sheldon | ||
| ubuntu-keyboard (Ubuntu RTM) |
Fix Released
|
Undecided
|
Michael Sheldon | ||
Bug Description
Steps to reproduce
1) Open the twitter login page in the browser
2) Type your username
3) Click on the password field
(Note the field will not show that it has focus or echo characters as you type. If you click again it will gain focus and the issue doesn't occur)
4) Type "hello123", only "123" will be entered due to another bug
5) Press backspace
Expected result
Text will change to "12"
Actual result
Keyboard segfaults due to Oxide claiming that there are 8 characters in the surrounding text when there are only 3.
Related branches
lp://staging/~michael-sheldon/ubuntu-keyboard/fix-oxide-password-crash
- PS Jenkins bot: Approve (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 55 lines (+33/-1)2 files modifiedsrc/view/abstracttexteditor.cpp (+1/-1)
tests/unittests/ut_repeat-backspace/ut_repeat-backspace.cpp (+32/-0)
lp://staging/~michael-sheldon/ubuntu-keyboard/fix-oxide-crash-rtm
- Ubuntu Phablet Team: Pending requested
-
Diff: 55 lines (+33/-1)2 files modifiedsrc/view/abstracttexteditor.cpp (+1/-1)
tests/unittests/ut_repeat-backspace/ut_repeat-backspace.cpp (+32/-0)
| Changed in ubuntu-keyboard: | |
| importance: | Undecided → Critical |
| status: | New → In Progress |
| assignee: | nobody → Michael Sheldon (michael-sheldon) |
| tags: | added: hotfix |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → Critical |
| status: | New → In Progress |
| description: | updated |
| Changed in canonical-devices-system-image: | |
| milestone: | none → ww17-2015 |
| Changed in ubuntu-keyboard: | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-keyboard (Ubuntu): | |
| status: | New → Fix Released |
| Changed in ubuntu-keyboard (Ubuntu RTM): | |
| status: | New → In Progress |
| Changed in ubuntu-keyboard (Ubuntu): | |
| assignee: | nobody → Michael Sheldon (michael-sheldon) |
| Changed in ubuntu-keyboard (Ubuntu RTM): | |
| assignee: | nobody → Michael Sheldon (michael-sheldon) |
| Changed in canonical-devices-system-image: | |
| milestone: | ww17-2015 → ww19-ota |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Bill Filler (bfiller) |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-keyboard (Ubuntu RTM): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-keyboard - 0.99.trunk.
---------------
ubuntu-keyboard (0.99.trunk.
[ CI Train Bot ]
* New rebuild forced.
[ Michael Sheldon ]
* Back port fix for keyboard crashing when clients send invalid
surrounding text/offset data. (LP: #1444947)
-- CI Train Bot <email address hidden> Mon, 27 Apr 2015 22:51:56 +0000