[list-modems] Don't display user-related information by default

I created the following pull-request which adds changes list-modems to obfuscate any fields that could be tied to a user ( Serial, SubscriberId, SubscriberNumbers, *Forwarded* numbers ) unless '-p' or '--private' is specified on the command-line.

https://github.com/rilmodem/ofono/pull/181

This bug was fixed in the package ofono - 1.12.bzr6896+15.10.20150521-0ubuntu1

---------------
ofono (1.12.bzr6896+15.10.20150521-0ubuntu1) wily; urgency=medium

  [ Ratchanan Srirattanamet ]
  * build, gril, rilmodem, qcommsimmodem, plugins/qcom-msim.c: add
    support for LG L90 Dual which uses a Qualcomm dual-SIM modem (LP: #1427788)

  [ Alfonso Sanchez-Beato ]
  * src/gprs.c: support for 'ResetContexts' (LP: #1338758)
    Adds a new ConnectionManager 'ResetContexts' DBus method
    which deletes all existing gprs contexts and forces
    re-provisioning to occur.
  * plugins/ubuntu-apndb.c: ignore 'ipv6' protocol
    This change causes APNs with an 'ipv6' protocol value
    to instead be provisioned with 'ip', forcing IPv4 to
    be used.

  [ Jonas Drange ]
  * doc/connman-api.txt: add metion of 'ia' gprs context type

  [ Tony Espy ]
  * test/set-context-property: add 'Preferred' support (LP: #1454756, #1454751)
    This change adds support for the 'Preferred' ( and 'Active')
    properties which both need to be DBus variant wrapped booleans.
    Also added support for multi-SIM which was lacking from this script.
  * test/list-modems: add privacy support (LP: #1438715)
    Obfuscate any properties which can be tied to the end-user
    ( eg. SubscriberNumbers, SubscriberIdentity, ... ).

 -- CI Train Bot <email address hidden> Thu, 21 May 2015 08:44:39 +0000

Re-opened and marked as InProgress.

Turns out it was wrong of me to change the default behavior of list-modems. This change broke the autopkg tests for python-dbusmock.

So... I've re-submitted a new pull request which reverses the semantics of -p. Specifying -p ( or --private ) will *obfuscate* the private fields now, not render them in cleartext. This reverts the scripts default behavior to displaying all the properties cleartext. If/when an end-user is asked for list-modems output for inclusion in a bug, we now will need to make sure to ask them to use the -p flag.

Here's the associated pull-request:

https://github.com/rilmodem/ofono/pull/189

Note, bug #1459983 has been marked a DUP of this. It details python-dbusmock autopkg test failures that were caused by the original change.

This bug was fixed in the package ofono - 1.12.bzr6900+15.10.20150702.3-0ubuntu1

---------------
ofono (1.12.bzr6900+15.10.20150702.3-0ubuntu1) wily; urgency=medium

  [Tony Espy]
  * test/rilmodem/sim: fix testing scripts for arale (LP: #1457775)
  * test: reverse meaning of list-modems -p (LP: #1438715)

  [ Alfonso Sanchez-Beato ]
  * gril: cleanup traces
  * src/gprs.c: set preferred for the used IA APN (LP: #1361864)
  * rilmodem, mtkmodem, plugins/ril.c, plugins/mtk.c: retry when a
    context deactivation request has finished with an error
  * build, include, plugins/c-ares-dns-client.c, src/dns-client.c,
    src/gprs.c: resolve MMS proxy/MMSC host name (LP: #1417976)

  [ Ratchanan Srirattanamet ]
  * build, rilmodem, qcommsimmodem, plugins/ril.c,
    src/radio-settings.c: add multi-sim support for qcommsimmodem

 -- CI Train Bot <email address hidden> Thu, 02 Jul 2015 17:04:18 +0000

This bug was fixed in the package ofono 1.12.bzr6900+15.04.20150702.3-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ofono (1.12.bzr6900+15.04.20150702.3-0ubuntu1) vivid; urgency=medium

  [Tony Espy]
  * test/rilmodem/sim: fix testing scripts for arale (LP: #1457775)
  * test: reverse meaning of list-modems -p (LP: #1438715)

  [ Alfonso Sanchez-Beato ]
  * gril: cleanup traces
  * src/gprs.c: set preferred for the used IA APN (LP: #1361864)
  * rilmodem, mtkmodem, plugins/ril.c, plugins/mtk.c: retry when a
    context deactivation request has finished with an error
  * build, include, plugins/c-ares-dns-client.c, src/dns-client.c,
    src/gprs.c: resolve MMS proxy/MMSC host name (LP: #1417976)

  [ Ratchanan Srirattanamet ]
  * build, rilmodem, qcommsimmodem, plugins/ril.c,
    src/radio-settings.c: add multi-sim support for qcommsimmodem

 -- CI Train Bot <email address hidden> Thu, 02 Jul 2015 17:04:18 +0000