[FFe] QML compilation cache patch needs adaptation for Qt 5.4
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
qtdeclarative-opensource-src (Ubuntu) |
Fix Released
|
Critical
|
Ricardo Mendoza |
Bug Description
-- FFe --
Since we're past the feature freeze, bringing this patch back needs an exception, even though it's a regression fix at the same time. Summary:
- The patch allows opt-in, environment variable controlled use of storing some cache data when loading QML files. Without the environment variable there are no changes.
- Not having the patch is a performance regression on application startup time on the phones from Qt 5.3.2.
- The patch already shipped in Qt 5.3.2, but needed adjustments for 5.4 that were not done on time when Qt 5.4 was otherwise ready to land before feature freeze, so the patch was commented out.
- The patch is also shipping on the sold Bq phones.
- The proposed changes are in the MP below, that is uncommenting the patch in debian/
As usual, we have a wide testing being done also on this rebased-to-Qt-5.4.0 patch.
Upstreaming is being considered now that the patch seems to work for our purposes. It might need more than code discussions since upstream developer is also selling a proprietary product that offers somewhat similar benefits.
-- Original bug report --
The environment variable controlled new functionality provided by QML compilation cache patch (landed for Qt 5.3.2) needs adaptation for Qt 5.4, as it does not currently apply.
Attachment shows a summary of the patch applying problems.
More information about Qt 5.4 at https:/
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Kubuntu Packagers: Pending requested
-
Diff: 896 lines (+294/-159)5 files modifieddebian/changelog (+10/-0)
debian/libqt5qml5.symbols (+6/-1)
debian/patches/QML-Compilation-unit-caching-and-JIT-changes.patch (+269/-156)
debian/patches/series (+1/-1)
debian/rules (+8/-1)
Changed in qtdeclarative-opensource-src (Ubuntu): | |
importance: | Undecided → Critical |
status: | New → Triaged |
description: | updated |
summary: |
- QML compilation cache patch needs adaptation for Qt 5.4 + [FFe] QML compilation cache patch needs adaptation for Qt 5.4 |
Changed in qtdeclarative-opensource-src (Ubuntu): | |
status: | Triaged → In Progress |
https:/ /launchpad. net/~ci- train-ppa- service/ +archive/ ubuntu/ landing- 026/+packages