Cannot drag up/down launcher if right-edge DDA area covers the whole panel
Bug #1417920 reported by
Michael Zanetti
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity8 (Ubuntu) |
Fix Released
|
Undecided
|
Daniel d'Andrada | ||
Vivid |
New
|
Undecided
|
Unassigned |
Bug Description
One way to easily reproduce this is to change the Launcher's DDA to be as wide as the Launcher itself. Then reveal the Launcher and try to drag it up/down. Instead of moving up/down it will hide again.
Related branches
lp://staging/~dandrader/unity8/ddaImprovements
- Michael Zanetti (community): Approve
- Albert Astals Cid (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Michał Sawicz: Pending requested
-
Diff: 5591 lines (+1769/-1521)49 files modifiedlibs/UbuntuGestures/CMakeLists.txt (+1/-0)
libs/UbuntuGestures/CandidateInactivityTimer.h (+1/-1)
libs/UbuntuGestures/TimeSource.h (+14/-4)
libs/UbuntuGestures/Timer.cpp (+67/-14)
libs/UbuntuGestures/Timer.h (+15/-3)
libs/UbuntuGestures/TouchRegistry.cpp (+12/-14)
libs/UbuntuGestures/TouchRegistry.h (+18/-4)
plugins/Ubuntu/Gestures/CMakeLists.txt (+1/-1)
plugins/Ubuntu/Gestures/Damper.cpp (+24/-0)
plugins/Ubuntu/Gestures/Damper.h (+2/-0)
plugins/Ubuntu/Gestures/DirectionalDragArea.cpp (+362/-363)
plugins/Ubuntu/Gestures/DirectionalDragArea.h (+34/-207)
plugins/Ubuntu/Gestures/DirectionalDragArea_p.h (+167/-0)
plugins/Ubuntu/Gestures/TouchDispatcher.cpp (+88/-53)
plugins/Ubuntu/Gestures/TouchDispatcher.h (+16/-9)
plugins/Ubuntu/Gestures/TouchGate.cpp (+87/-63)
plugins/Ubuntu/Gestures/TouchGate.h (+18/-5)
qml/Components/DragHandle.qml (+20/-35)
qml/Components/EdgeDragArea.qml (+0/-46)
qml/Dash/Dash.qml (+5/-12)
qml/Greeter/CoverPage.qml (+3/-2)
qml/Launcher/Launcher.qml (+7/-15)
qml/Panel/IndicatorsMenu.qml (+12/-2)
qml/Stages/PhoneStage.qml (+33/-43)
qml/Stages/TabletStage.qml (+19/-21)
qml/Tutorial/TutorialBottom.qml (+1/-1)
tests/libs/UbuntuGestures/tst_TouchRegistry.cpp (+68/-2)
tests/plugins/Ubuntu/Gestures/CMakeLists.txt (+3/-1)
tests/plugins/Ubuntu/Gestures/DownwardsLauncher.qml (+5/-19)
tests/plugins/Ubuntu/Gestures/GestureTest.cpp (+13/-3)
tests/plugins/Ubuntu/Gestures/GestureTest.h (+4/-0)
tests/plugins/Ubuntu/Gestures/LeftwardsLauncher.qml (+6/-19)
tests/plugins/Ubuntu/Gestures/RightwardsLauncher.qml (+5/-19)
tests/plugins/Ubuntu/Gestures/UpwardsLauncher.qml (+6/-19)
tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp (+496/-461)
tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.qml (+8/-1)
tests/plugins/Ubuntu/Gestures/tst_TouchDispatcher.cpp (+5/-6)
tests/plugins/Ubuntu/Gestures/tst_TouchGate.cpp (+56/-1)
tests/qmltests/Components/CMakeLists.txt (+3/-1)
tests/qmltests/Components/tst_DragHandle.cpp (+15/-13)
tests/qmltests/Components/tst_DragHandle.qml (+7/-0)
tests/qmltests/Components/tst_DragHandle/BidirectionalShowable.qml (+2/-2)
tests/qmltests/Components/tst_DragHandle/HorizontalShowable.qml (+4/-4)
tests/qmltests/Components/tst_DragHandle/VerticalShowable.qml (+4/-4)
tests/qmltests/Stages/tst_PhoneStage.qml (+8/-8)
tests/qmltests/Tutorial/tst_Tutorial.qml (+5/-1)
tests/qmltests/tst_Shell.qml (+14/-10)
tests/qmltests/tst_ShellWithPin.qml (+2/-2)
tests/utils/modules/Unity/Test/UnityTestCase.qml (+3/-7)
Changed in unity8 (Ubuntu): | |
status: | New → In Progress |
summary: |
- A DirectionalDragArea on top of a Flickable breaks the Flickable + Launcher DirectionalDragArea recognizes a vertical drag |
summary: |
- Launcher DirectionalDragArea recognizes a vertical drag + A rightwards EdgeDragArea recognizes a vertical drag |
To post a comment you must log in.
This actually has multiple causes:
1 - EdgeDragArea has very lax rules, so a rightwards DDA would recognize even a vertical drag if it's long enough (both in terms of time and of distance)
2 - If the EdgeDragArea inside the Launcher rejects a gesture it will cause Launcher to retract. Ie, bad logic in Launcher.qml