Mir

USC - mouse cursor on AMD graphics is drawing incorrectly

Bug #1417581 reported by Gerry Boland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Andreas Pokorny
Mir 0.13.0
0.12
Fix Released
High
Andreas Pokorny
Mir 0.12.1
mesa (Ubuntu)
New
Undecided
Unassigned
mir (Ubuntu)
Fix Released
High
Unassigned

Bug Description

I've a Lenovo Flex 2 14D, which has an AMD APU.

In Unity-System-Compositor, the mouse cursor does not draw correctly.

See previous version of this bug for visuals: https://bugs.launchpad.net/mir/+bug/1391975

See original description

Related branches

lp://staging/~andreas-pokorny/mir/fix-1417581
Gerry Boland (community): Approve (functional)
PS Jenkins bot (community): Approve (continuous-integration)
Daniel van Vugt: Approve
Alexandros Frantzis (community): Approve
Diff: 63 lines (+31/-3)
1 file modified
src/platforms/mesa/server/cursor.cpp (+31/-3)
lp://staging/mir/0.12
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Mir development team: Pending requested
Diff: 2349 lines (+1697/-127)
23 files modified
3rd_party/android-input/android/frameworks/base/services/input/InputDispatcher.cpp (+36/-31)
cmake/MirCommon.cmake (+2/-0)
debian/changelog (+22/-0)
src/CMakeLists.txt (+1/-1)
src/platforms/android/server/hwc_blanking_control.cpp (+14/-1)
src/platforms/mesa/server/cursor.cpp (+31/-3)
src/server/frontend/protobuf_message_processor.cpp (+42/-15)
src/server/frontend/protobuf_message_processor.h (+2/-1)
src/server/frontend/protobuf_responder.cpp (+9/-5)
src/server/frontend/protobuf_responder.h (+2/-0)
src/server/frontend/session_mediator.cpp (+25/-26)
src/server/frontend/session_mediator.h (+2/-0)
src/server/frontend/surface_tracker.cpp (+8/-1)
src/server/frontend/surface_tracker.h (+6/-3)
src/server/graphics/software_cursor.cpp (+8/-20)
src/server/graphics/software_cursor.h (+1/-1)
tests/acceptance-tests/throwback/test_client_input.cpp (+3/-2)
tests/unit-tests/frontend/test_protobuf_message_processor.cpp (+1/-1)
tests/unit-tests/graphics/android/test_hwc_configuration.cpp (+28/-13)
tests/unit-tests/graphics/test_software_cursor.cpp (+20/-0)
tests/unit-tests/test_fatal.cpp (+3/-3)
tools/valgrind_suppressions_armhf (+27/-0)
tools/valgrind_suppressions_glibc_2.21 (+1404/-0)
lp://staging/ubuntu/vivid-proposed/mir
lp://staging/ubuntu/wily-proposed/mir
Daniel van Vugt (vanvugt)
Changed in mir:
assignee: nobody → Daniel van Vugt (vanvugt)
status: New → In Progress
milestone: none → 0.12.0
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

GBM is giving us a stride of 256:
    size_t buffer_stride = gbm_bo_get_stride(buffer); // in bytes

But actually it only renders correctly if we double this (real stride is 512?).

Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.12.0 → none
assignee: Daniel van Vugt (vanvugt) → nobody
importance: Undecided → High
status: In Progress → Triaged
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.12.0
status: Triaged → In Progress
assignee: nobody → Andreas Pokorny (andreas-pokorny)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.12.0

Changed in mir:
status: In Progress → Fix Committed
Kevin DuBois (kdub)
Changed in mir:
milestone: 0.12.0 → 0.13.0
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Not a regression. No fully working solution ever existed on trunk till this fix landed.

summary: - [regression] USC - mouse cursor on AMD graphics is drawing incorrectly
+ USC - mouse cursor on AMD graphics is drawing incorrectly
description: updated
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu):
importance: Undecided → High
status: New → Triaged
Daniel van Vugt (vanvugt)
no longer affects: mesa (Ubuntu)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.12.1+15.04.20150324-0ubuntu1

---------------
mir (0.12.1+15.04.20150324-0ubuntu1) vivid; urgency=medium

  [ Alexandros Frantzis ]
  * New upstream release 0.12.1 (https://launchpad.net/mir/+milestone/0.12.1)
    - Bug fixes:
      . [regression] mali, powervr locks up with around the introduction or
        removal of a third overlay (LP: #1413211)
      . USC - mouse cursor on AMD graphics is drawing incorrectly
        (LP: #1417581)
      . mir_demo_server doesn't emit hover_exit events (LP: #1418569)
      . SessionMediator locks mutexes in one thread and unlocks them in
        another (LP: #1427976)
      . ProtobufResponder::send_response_result race (LP: #1428402)
      . Some protobuf Closure objects can access dead objects (LP: #1433330)
      . DisplayConfigurationOutput.physical_size_mm is undefined/zero
        (LP: #1430315)
      . vivid fails to build Mir as of 2015-03-22: error: #warning
        "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
        [-Werror=cpp] (LP: #1435127)
      . valgrind on armhf fails with with many errors (LP: #1435186)
 -- CI Train Bot <email address hidden> Tue, 24 Mar 2015 16:09:54 +0000

Changed in mir (Ubuntu):
status: Triaged → Fix Released
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.