Ubuntu
unity-scopes-api package

Parent scope is authorised when logging in to a child scope

Bug #1414560 reported by Marcus Tomlinson
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
Canonical System Image ww05-2015
unity-scopes-api (Ubuntu)
Fix Released
Undecided
Marcus Tomlinson
unity-scopes-api (Ubuntu RTM)
Fix Released
Undecided
Marcus Tomlinson
unity-scopes-shell (Ubuntu)
Fix Released
Undecided
Marcus Tomlinson
unity-scopes-shell (Ubuntu RTM)
Fix Released
Undecided
Marcus Tomlinson

Bug Description

When logging into a child scope from an aggregator, the parent scope is added to the ACL instead of the child scope. The aggregator should request authentication on behalf of the child scope in these cases.

To reproduce the bug:
  1. Ensure that signon-apparmor-extension is installed on the phone: "sudo apt-get install signon-apparmor-extension"
  2. Log into Facebook Photos from the Photos scope. (Tap "No Facebook Photos account configured")

What should happen:
Once focus is returned to the Photos scope, the scope should refresh, now displaying your personal Facebook photos.

What actually happens:
Focus returns to the Photos scope and nothing happens. Neither the Photos scope nor the Facebook Photos scope show your personal Facebook pictures, yet settings indicates the scopes are authenticated.

See original description

Related branches

lp://staging/~marcustomlinson/unity-scopes-api/fix_acl
Paweł Stołowski (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 53 lines (+6/-0)
2 files modified
src/scopes/internal/OnlineAccountClientImpl.cpp (+2/-0)
test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp (+4/-0)
lp://staging/~marcustomlinson/unity-scopes-shell/fix_acl
Paweł Stołowski (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 92 lines (+15/-9)
3 files modified
src/Unity/previewstack.cpp (+4/-2)
src/Unity/scope.cpp (+10/-6)
src/Unity/scope.h (+1/-1)
lp://staging/ubuntu/vivid-proposed/unity-scopes-api
lp://staging/~marcustomlinson/unity-scopes-api/fix_acl-rtm
Unity Team: Pending requested
Diff: 53 lines (+6/-0)
2 files modified
src/scopes/internal/OnlineAccountClientImpl.cpp (+2/-0)
test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp (+4/-0)
lp://staging/~marcustomlinson/unity-scopes-shell/fix_acl-rtm
Unity Team: Pending requested
Diff: 92 lines (+15/-9)
3 files modified
src/Unity/previewstack.cpp (+4/-2)
src/Unity/scope.cpp (+10/-6)
src/Unity/scope.h (+1/-1)
Marcus Tomlinson (marcustomlinson)
Changed in unity-scopes-api (Ubuntu):
assignee: nobody → Marcus Tomlinson (marcustomlinson)
Changed in unity-scopes-shell (Ubuntu):
assignee: nobody → Marcus Tomlinson (marcustomlinson)
Changed in unity-scopes-api (Ubuntu):
status: New → In Progress
Changed in unity-scopes-shell (Ubuntu):
status: New → In Progress
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scopes-shell - 0.5.4+15.04.20150126-0ubuntu1

---------------
unity-scopes-shell (0.5.4+15.04.20150126-0ubuntu1) vivid; urgency=low

  [ Marcus Tomlinson ]
  * Read scope ID from the OA details embedded in a log-in item (LP:
    #1414560)
 -- Ubuntu daily release <email address hidden> Mon, 26 Jan 2015 09:04:44 +0000

Changed in unity-scopes-shell (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scopes-api - 0.6.11+15.04.20150126-0ubuntu1

---------------
unity-scopes-api (0.6.11+15.04.20150126-0ubuntu1) vivid; urgency=low

  [ Marcus Tomlinson ]
  * Embed scope ID into the OA details of a log-in item (LP: #1414560)
 -- Ubuntu daily release <email address hidden> Mon, 26 Jan 2015 09:01:09 +0000

Changed in unity-scopes-api (Ubuntu):
status: In Progress → Fix Released
Marcus Tomlinson (marcustomlinson)
Changed in unity-scopes-api (Ubuntu RTM):
assignee: nobody → Marcus Tomlinson (marcustomlinson)
Changed in unity-scopes-shell (Ubuntu RTM):
assignee: nobody → Marcus Tomlinson (marcustomlinson)
Changed in unity-scopes-api (Ubuntu RTM):
status: New → In Progress
Changed in unity-scopes-shell (Ubuntu RTM):
status: New → In Progress
Marcus Tomlinson (marcustomlinson)
description: updated
description: updated
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

ok to land to fix usability issue

Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww05-2015
status: New → Confirmed
Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

This does improve the behavior, but it still has bugs.

Both the parent scope and child scope get authorized. This is fine, but the user cannot then change it so that only one scope or the other has access. The settings UI will allow just the one scope to be selected, but it saves the change to both. And it takes a few taps before it'll visually allow just one; at first, both checkboxes change in sync.

So, it's better than it was... but still needs further improvements.

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Hi Selene, so during the confusion of log-in buttons not working in aggregator scopes, a (incorrect) work-around to the problem was to also add the aggregator as a client to the online service (hence you see both FB Photos and Photos under the Facebook account).

Aggregator scopes should not be registering themselves as clients to services, only the scopes directly requiring access should. This bug fix correctly enforces that requirement. Therefore, The Photos scope needs to be updated to remove itself from the Facebook account clients list.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scopes-shell - 0.5.4+15.04.20150126~rtm-0ubuntu1

---------------
unity-scopes-shell (0.5.4+15.04.20150126~rtm-0ubuntu1) 14.09; urgency=low

  [ Marcus Tomlinson ]
  * Read scope ID from the OA details embedded in a log-in item (LP:
    #1414560)
 -- Ubuntu daily release <email address hidden> Mon, 26 Jan 2015 12:24:18 +0000

Changed in unity-scopes-shell (Ubuntu RTM):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scopes-api - 0.6.9+15.04.20150126~rtm-0ubuntu1

---------------
unity-scopes-api (0.6.9+15.04.20150126~rtm-0ubuntu1) 14.09; urgency=low

  [ CI Train Bot ]
  * Resync trunk
  * Resync trunk
  * Resync trunk

  [ Marcus Tomlinson ]
  * Embed scope ID into the OA details of a log-in item (LP: #1414560)
 -- Ubuntu daily release <email address hidden> Mon, 26 Jan 2015 12:20:46 +0000

Changed in unity-scopes-api (Ubuntu RTM):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.