ubuntu-download-manager

Download manager should support saving data URIs

Bug #1407745 reported by Michael Sheldon
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
Canonical System Image ww05-2015
ubuntu-download-manager
Fix Released
High
Manuel de la Peña
ubuntu-download-manager (Ubuntu RTM)
Fix Released
High
Unassigned

Bug Description

When passed a data URI (of the form data:<mime-type>;<encoding>,<data>) download manager currently reports a 403 HTTP error message. Instead it should decode the data, save it to a file and report the download as completed.

This can be tested in the browser by visiting http://images.google.com and attempting to download a thumbnail image which Google now encode as data URIs.

Tags: ww05

Related branches

lp://staging/~mandel/ubuntu-download-manager/support-data-uri
Michael Sheldon (community): Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 1154 lines (+613/-232)
5 files modified
src/downloads/priv/ubuntu/downloads/file_download.cpp (+319/-188)
src/downloads/priv/ubuntu/downloads/file_download.h (+3/-4)
tests/downloads/daemon/CMakeLists.txt (+28/-28)
tests/downloads/daemon/test_download.cpp (+254/-12)
tests/downloads/daemon/test_download.h (+9/-0)
Manuel de la Peña (mandel)
Changed in ubuntu-download-manager:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Manuel de la Peña (mandel)
Bill Filler (bfiller)
Changed in canonical-devices-system-image:
importance: Undecided → High
Changed in ubuntu-download-manager:
importance: Medium → High
Changed in ubuntu-download-manager (Ubuntu RTM):
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Since this happens on google images in addition to other sites should fix sooner than later

Changed in canonical-devices-system-image:
milestone: none → ww05-2015
status: New → Confirmed
Bill Filler (bfiller)
tags: added: ww05
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
Changed in ubuntu-download-manager (Ubuntu RTM):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-download-manager - 0.9+15.04.20150123~rtm-0ubuntu1

---------------
ubuntu-download-manager (0.9+15.04.20150123~rtm-0ubuntu1) 14.09; urgency=low

  [ Manuel de la Peña ]
  * Add support for data uris. (LP: #1407745)

ubuntu-download-manager (0.9+15.04.20141202-0ubuntu1) vivid; urgency=low

  [ Manuel de la Peña ]
  * Fix wrong bus used to query apparmor profile breaking download-
    manager.

ubuntu-download-manager (0.9+15.04.20141126-0ubuntu1) vivid; urgency=medium

  [ Manuel de la Pena ]
  * Fix issues with the network detection. Because of the new approach two
    dependencies have been dropped.
  * Add network manager as dependency.

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Fri, 23 Jan 2015 16:00:00 +0000

Changed in ubuntu-download-manager (Ubuntu RTM):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: In Progress → Fix Released
Revision history for this message
John McAleely (john.mcaleely) wrote :

does anyone know which rtm silo this is on.

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

John - This has already landed in RTM, so should be in the latest RTM-proposed image.

Manuel de la Peña (mandel)
Changed in ubuntu-download-manager:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.