Fullscreen Menus cannot relayout themselves
Bug #1398733 reported by
SirVer
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Won't Fix
|
Medium
|
GunChleoc | ||
Bug Description
Now that we can change into fullscreen with 'f' everywhere it becomes apparent to the user that fullscreen menus never relayout themselves. The fix is very easy:
Either:
- Each UI element must be hold on to as a member.
- A layout() method puts them into the correct place. This will be called on resolution changes.
Or:
- The menus are switched to using UI::Box which can already layout themselves. This will make working with them in the future also easier. This is more work.
Related branches
lp://staging/~widelands-dev/widelands/fsmenu_fullscreen_4_options
- kaputtnik (community): Approve (testing)
- Klaus Halfmann: Needs Information
-
Diff: 811 lines (+277/-160)9 files modifiedsrc/ui_basic/checkbox.cc (+37/-15)
src/ui_basic/checkbox.h (+4/-8)
src/ui_basic/dropdown.cc (+33/-11)
src/ui_basic/dropdown.h (+4/-0)
src/ui_basic/listselect.cc (+1/-0)
src/ui_basic/spinbox.cc (+65/-46)
src/ui_basic/spinbox.h (+6/-0)
src/ui_fsmenu/options.cc (+116/-73)
src/ui_fsmenu/options.h (+11/-7)
lp://staging/~widelands-dev/widelands/fsmenu_fullscreen_1_main_menus
- Tino: Approve
-
Diff: 562 lines (+159/-96)12 files modifiedsrc/ui_basic/box.cc (+9/-1)
src/ui_basic/box.h (+1/-0)
src/ui_fsmenu/base.cc (+5/-0)
src/ui_fsmenu/base.h (+5/-0)
src/ui_fsmenu/main.cc (+50/-45)
src/ui_fsmenu/main.h (+2/-2)
src/ui_fsmenu/main_menu.cc (+11/-1)
src/ui_fsmenu/main_menu.h (+8/-4)
src/ui_fsmenu/multiplayer.cc (+33/-21)
src/ui_fsmenu/multiplayer.h (+2/-2)
src/ui_fsmenu/singleplayer.cc (+31/-18)
src/ui_fsmenu/singleplayer.h (+2/-2)
lp://staging/~widelands-dev/widelands/fsmenu_fullscreen_2_about
- Tino: Approve
-
Diff: 162 lines (+58/-41)4 files modifiedsrc/ui_basic/fileview_panel.cc (+24/-10)
src/ui_basic/fileview_panel.h (+4/-0)
src/ui_fsmenu/about.cc (+23/-26)
src/ui_fsmenu/about.h (+7/-5)
lp://staging/~widelands-dev/widelands/fsmenu_fullscreen_3_mapselect
- TiborB: Approve
-
Diff: 667 lines (+183/-105)20 files modifiedsrc/editor/ui_menus/main_menu_save_map.cc (+1/-1)
src/ui_basic/table.cc (+39/-12)
src/ui_fsmenu/campaign_select.cc (+8/-0)
src/ui_fsmenu/campaign_select.h (+4/-0)
src/ui_fsmenu/internet_lobby.cc (+4/-0)
src/ui_fsmenu/internet_lobby.h (+2/-0)
src/ui_fsmenu/launch_mpg.cc (+4/-0)
src/ui_fsmenu/launch_mpg.h (+2/-0)
src/ui_fsmenu/launch_spg.cc (+4/-0)
src/ui_fsmenu/launch_spg.h (+2/-0)
src/ui_fsmenu/load_map_or_game.cc (+22/-25)
src/ui_fsmenu/load_map_or_game.h (+10/-8)
src/ui_fsmenu/loadgame.cc (+4/-0)
src/ui_fsmenu/loadgame.h (+2/-0)
src/ui_fsmenu/mapselect.cc (+42/-32)
src/ui_fsmenu/mapselect.h (+5/-1)
src/ui_fsmenu/netsetup_lan.cc (+4/-0)
src/ui_fsmenu/netsetup_lan.h (+2/-0)
src/wui/mapdetails.cc (+20/-22)
src/wui/mapdetails.h (+2/-4)
lp://staging/~widelands-dev/widelands/campaignselect_box
- Toni Förster: Approve
- Klaus Halfmann: Approve (review compile, testplay)
-
Diff: 2711 lines (+1143/-949)39 files modifieddata/campaigns/atl01.wmf/scripting/mission_thread.lua (+1/-2)
data/campaigns/bar01.wmf/scripting/mission_thread.lua (+1/-2)
data/campaigns/bar02.wmf/scripting/mission_thread.lua (+1/-2)
data/campaigns/campaigns.lua (+127/-141)
data/campaigns/dummy.wmf/elemental (+1/-0)
data/campaigns/emp01.wmf/scripting/mission_thread.lua (+1/-1)
data/campaigns/emp02.wmf/scripting/mission_thread.lua (+1/-2)
data/campaigns/emp03.wmf/scripting/mission_thread.lua (+1/-1)
data/campaigns/emp04.wmf/scripting/mission_thread.lua (+1/-3)
data/campaigns/tutorials.lua (+12/-28)
src/base/i18n.cc (+9/-0)
src/base/i18n.h (+11/-2)
src/graphic/text_layout.cc (+1/-0)
src/graphic/text_layout.h (+2/-0)
src/logic/CMakeLists.txt (+0/-11)
src/logic/filesystem_constants.h (+2/-1)
src/scripting/CMakeLists.txt (+0/-1)
src/scripting/lua_game.cc (+10/-30)
src/scripting/lua_game.h (+1/-2)
src/ui_basic/table.cc (+3/-3)
src/ui_basic/table.h (+2/-8)
src/ui_fsmenu/CMakeLists.txt (+12/-1)
src/ui_fsmenu/campaign_select.cc (+44/-397)
src/ui_fsmenu/campaign_select.h (+10/-90)
src/ui_fsmenu/campaigndetails.cc (+82/-0)
src/ui_fsmenu/campaigndetails.h (+41/-0)
src/ui_fsmenu/campaigns.cc (+198/-158)
src/ui_fsmenu/campaigns.h (+59/-13)
src/ui_fsmenu/scenario_select.cc (+230/-0)
src/ui_fsmenu/scenario_select.h (+65/-0)
src/ui_fsmenu/scenariodetails.cc (+74/-0)
src/ui_fsmenu/scenariodetails.h (+41/-0)
src/wlapplication.cc (+12/-9)
src/wui/CMakeLists.txt (+2/-1)
src/wui/load_or_save_game.cc (+4/-6)
src/wui/mapauthordata.h (+72/-0)
src/wui/mapdata.cc (+7/-7)
src/wui/mapdata.h (+1/-27)
src/wui/mapdetails.h (+1/-0)
| Changed in widelands: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| description: | updated |
Revision history for this message
| SirVer (sirver) wrote | #1 |
Revision history for this message
| kaputtnik (franku) wrote | #2 |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #3 |
| Changed in widelands: | |
| milestone: | none → build20-rc1 |
| Changed in widelands: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → GunChleoc (gunchleoc) |
| tags: | added: ui |
| Changed in widelands: | |
| milestone: | build20-rc1 → build21-rc1 |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #4 |
| Changed in widelands: | |
| status: | In Progress → Won't Fix |
To post a comment you must log in.
This has implications also for child windows. See bug 1398733.