Double-buffered surfaces may lag or freeze if event driven and not constantly redrawing
Bug #1395581 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Daniel van Vugt | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
qtmir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Double-buffered surfaces may lag or freeze if event driven and not constantly redrawing. This is buffers_
Related branches
lp://staging/~vanvugt/mir/fix-buffers_ready_for_compositor
- PS Jenkins bot (community): Approve (continuous-integration)
- Kevin DuBois (community): Approve
- Alan Griffiths: Abstain
- Alberto Aguirre (community): Approve
-
Diff: 874 lines (+297/-63)34 files modifiedexamples/render_overlays.cpp (+0/-5)
include/platform/mir/graphics/renderable.h (+0/-1)
include/server/mir/compositor/scene.h (+10/-0)
include/server/mir/scene/surface.h (+1/-0)
platform-ABI-sha1sums (+1/-1)
server-ABI-sha1sums (+3/-3)
src/include/server/mir/compositor/buffer_stream.h (+1/-1)
src/server/compositor/buffer_bundle.h (+1/-1)
src/server/compositor/buffer_queue.cpp (+10/-6)
src/server/compositor/buffer_queue.h (+1/-1)
src/server/compositor/buffer_stream_surfaces.cpp (+2/-2)
src/server/compositor/buffer_stream_surfaces.h (+1/-1)
src/server/compositor/multi_threaded_compositor.cpp (+12/-1)
src/server/graphics/software_cursor.cpp (+0/-5)
src/server/input/touchspot_controller.cpp (+0/-5)
src/server/scene/basic_surface.cpp (+12/-4)
src/server/scene/basic_surface.h (+1/-0)
src/server/scene/surface_stack.cpp (+31/-2)
src/server/scene/surface_stack.h (+2/-0)
src/server/symbols.map (+1/-0)
tests/include/mir_test_doubles/fake_renderable.h (+0/-5)
tests/include/mir_test_doubles/mock_buffer_bundle.h (+1/-1)
tests/include/mir_test_doubles/mock_buffer_stream.h (+3/-3)
tests/include/mir_test_doubles/mock_renderable.h (+0/-3)
tests/include/mir_test_doubles/mock_scene.h (+3/-0)
tests/include/mir_test_doubles/stub_buffer_stream.h (+4/-1)
tests/include/mir_test_doubles/stub_renderable.h (+0/-5)
tests/include/mir_test_doubles/stub_scene.h (+5/-1)
tests/include/mir_test_doubles/stub_scene_surface.h (+1/-0)
tests/integration-tests/test_exchange_buffer.cpp (+1/-1)
tests/integration-tests/test_surface_stack_with_compositor.cpp (+5/-4)
tests/unit-tests/compositor/test_buffer_queue.cpp (+66/-0)
tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+85/-0)
tests/unit-tests/scene/test_surface_stack.cpp (+33/-0)
lp://staging/~vanvugt/qtmir/fix-buffers_ready_for_compositor
- Gerry Boland (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 75 lines (+9/-10)3 files modifiedsrc/modules/Unity/Application/mirsurfaceitem.cpp (+8/-8)
tests/modules/common/mock_renderable.h (+0/-2)
tests/modules/common/mock_surface.h (+1/-0)
Superseded
for merging
into
lp://staging/qtmir/devel-mir-next
- Mir development team: Pending requested
-
Diff: 75 lines (+9/-10)3 files modifiedsrc/modules/Unity/Application/mirsurfaceitem.cpp (+8/-8)
tests/modules/common/mock_renderable.h (+0/-2)
tests/modules/common/mock_surface.h (+1/-0)
Changed in mir: | |
milestone: | 0.10.0 → 0.11.0 |
Changed in mir: | |
milestone: | 0.11.0 → 0.12.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The fix for this bug, while trivial, is now blocked by Android bug 1391261.