Ubuntu
python-distutils-extra package

Glade *.ui files not recognized due to comment line

Bug #1393247 reported by marmuta on 2014-11-16

10

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	python-distutils-extra (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

Glade 3.18 likes to insert a comment as the second line that upsets auto.py. Onboard's package fails to build due to this, unless we remember to remove the offending line after every change. Could you have a look?

$ cd onboard
$ ./setup.py build
...
WARNING: the following files are not recognized by DistUtilsExtra.auto:
... many ...
settings.ui

This fixes it for me:

*** /tmp/auto.py 2014-11-16 21:03:04.244604628 +0100
--- /usr/lib/python3/dist-packages/DistUtilsExtra/auto.py 2014-11-16 21:03:26.812605563 +0100
***************
*** 305,310 ****
--- 305,311 ----
          fd = open(f, 'rb')
          firstlines = fd.readline()
          firstlines += b'\n' + fd.readline()
+ firstlines += b'\n' + fd.readline()
          fd.close()
          if b'<interface' in firstlines or b'<ui version=' in firstlines:
              src_mark(src, f)

Ubuntu Vivid
python3-distutils-extra 2.38-1build1
glade 3.18.3-1

Related branches

lp://staging/python-distutils-extra

Revision history for this message

marmuta (marmuta) wrote on 2014-11-16:

#1

glade file with comment in second line Edit (216.4 KiB, text/xml)

Revision history for this message

marmuta (marmuta) wrote on 2016-02-01:

#2

It just bit me again:
https://answers.launchpad.net/onboard/+question/284286
Could someone have a look at this, please? It's not hard to fix at all.

Ubuntu Xenial
python3-distutils-extra 2.38-1build1
glade 3.18.3-1

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#3

I added marmuta's solution provided in the bug description as a patch to the python-distutils-extra package currently shipping in the development version of xenial.

Afterwards, I tested it against revision 2020 of the trunk branch of Onboard. Onboard was build without error while using the patched version of python-distutils-extra. However, I don't know if the patch might break other things.

I will add the relevant files to this bug thread.

Thanks in advance to anybody looking at this.

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#4

python-distutils-extra_2.38.orig.tar.gz Edit (27.1 KiB, application/x-tar)

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#5

python-distutils-extra_2.38-1build2.debian.tar.xz Edit (15.3 KiB, application/octet-stream)

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#6

python-distutils-extra_2.38-1build2.dsc Edit (1.7 KiB, text/plain)

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#7

python-distutils-extra_2.38-1build2_source.build Edit (2.7 KiB, text/plain)

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#8

python-distutils-extra_2.38-1build2_source.changes Edit (1.9 KiB, text/plain)

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#9

onboard_1.1.2+2020.orig.tar.gz Edit (8.5 MiB, application/x-tar)

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#10

onboard_1.1.2+2020-0ppa~xenial1.debian.tar.xz Edit (16.8 KiB, application/octet-stream)

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#11

onboard_1.1.2+2020-0ppa~xenial1_source.build Edit (3.4 KiB, text/plain)

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#12

onboard_1.1.2+2020-0ppa~xenial1_source.changes Edit (1.7 KiB, text/plain)

Revision history for this message

Francesco Fumanti (frafu) wrote on 2016-02-02:

#13

If you want me to also prepare packages of python-distutils-extra for trusty, vivid and wily, please let me know in this bug thread or by contacting me.

Revision history for this message

Martin Pitt (pitti) wrote on 2016-02-03:

#14

Committed with a test case, thank you!

affects:	python-distutils-extra → python-distutils-extra (Ubuntu)
Changed in python-distutils-extra (Ubuntu):
status:	New → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-02-03:

#15

This bug was fixed in the package python-distutils-extra - 2.39-1

---------------
python-distutils-extra (2.39-1) unstable; urgency=medium

  * test/auto.py: Show exactly which modules are missing. Thanks Daniel Macks!
    (LP: #1303550)
  * Ignore comment in second line when parsing *.ui files. Thanks marmuta!
    (LP: #1393247)
  * Drop obsolete X-Python-Version.
  * Convert build systemd to pybuild.
  * Bump Standards-Version to 3.9.6.
  * debian/copyright: Rename field to "Format:".

-- Martin Pitt <email address hidden> Wed, 03 Feb 2016 09:56:55 +0100

Changed in python-distutils-extra (Ubuntu):
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.