Ubuntu
media-hub package

Media Hub not exporting MPRIS controls

Bug #1373313 reported by Nick Dedekind
48
This bug affects 12 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
John McAleely
Canonical System Image ww46-2015 "ota8"
Ubuntu Music App
Invalid
Undecided
Unassigned
indicator-sound (Ubuntu)
Fix Released
High
Xavi Garcia
media-hub (Ubuntu)
Fix Released
High
Jim Hodapp

Bug Description

Pressing the previous or next button in the indicator sound menu does nothing.

Related branches

lp://staging/~xavi-garcia-mena/indicator-sound/next-play-prev-buttons-bug-1373313
Xavi Garcia: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 488 lines (+269/-85)
7 files modified
debian/changelog (+18/-0)
src/media-player-mpris.vala (+22/-0)
src/media-player.vala (+4/-0)
src/mpris2-interfaces.vala (+4/-1)
src/sound-menu.vala (+61/-6)
tests/media-player-mock.vala (+6/-0)
tests/sound-menu.cc (+154/-78)
Charles Kerr (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 538 lines (+275/-91)
7 files modified
debian/changelog (+24/-6)
src/media-player-mpris.vala (+22/-0)
src/media-player.vala (+4/-0)
src/mpris2-interfaces.vala (+4/-1)
src/sound-menu.vala (+61/-6)
tests/media-player-mock.vala (+6/-0)
tests/sound-menu.cc (+154/-78)
lp://staging/~xavi-garcia-mena/indicator-sound/mpris-bug-1373313
PS Jenkins bot (community): Approve (continuous-integration)
Xavi Garcia: Approve
Diff: 462 lines (+251/-85)
6 files modified
src/media-player-mpris.vala (+22/-0)
src/media-player.vala (+4/-0)
src/mpris2-interfaces.vala (+4/-1)
src/sound-menu.vala (+61/-6)
tests/media-player-mock.vala (+6/-0)
tests/sound-menu.cc (+154/-78)
Revision history for this message
Lars Karlitski (larsu) wrote :

I can't reproduce this with other players.

Does calling org.mpris.MediaPlayer2.Player.Next manually on the media hub advance to the next song?

Changed in indicator-sound:
status: New → Incomplete
Revision history for this message
Jim Hodapp (jhodapp) wrote :

@Lars What other players have you tried? Calling Next via MPRIS is not fully implemented yet in media-hub.

Changed in media-hub:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Thomas Voß (thomas-voss)
tags: added: rtm14 touch-2014-10-09
Revision history for this message
Lars Karlitski (larsu) wrote :

Rhythmbox, Banshee, and Spotify.

If Next() is not yet implemented in media-hub, then this is unlikely to be a bug in indicator-sound.

Changed in indicator-sound:
status: Incomplete → Invalid
Revision history for this message
Jim Hodapp (jhodapp) wrote :

@Lars: media-hub is not used on the desktop yet...this would be directly talking to such apps.

Revision history for this message
Victor Tuson Palau (vtuson) wrote :

this seems like a desktop bug. Let me know if I got it wrong and we can re-tag it for rtm

tags: removed: rtm14 touch-2014-10-09
Revision history for this message
Jim Hodapp (jhodapp) wrote :

@Victor: this is both a desktop and mobile bug

Łukasz Zemczak (sil2100)
tags: added: lt-age-20141001 lt-category-visible lt-prio-high
Łukasz Zemczak (sil2100)
tags: added: lt-date-20141001
removed: lt-age-20141001
Brendan Donegan (brendan-donegan)
summary: - Previous & New buttons not hooked up in indicator
+ Previous & Next buttons not hooked up in indicator
Ted Gould (ted)
summary: - Previous & Next buttons not hooked up in indicator
+ Previous & Next buttons not hooked up in media-hub
David Planella (dpm)
tags: added: rtm14
Łukasz Zemczak (sil2100)
tags: added: lt-whitelisted
Jim Hodapp (jhodapp)
Changed in media-hub:
status: Triaged → In Progress
assignee: Thomas Voß (thomas-voss) → Jim Hodapp (jhodapp)
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: none → ww26-2015
no longer affects: indicator-sound
Jim Hodapp (jhodapp)
Changed in media-hub:
status: In Progress → Triaged
Jim Hodapp (jhodapp)
summary: - Previous & Next buttons not hooked up in media-hub
+ indicator-sound does not display media controls and the controls aren't
+ fully working
Changed in music-app:
status: New → Invalid
Changed in indicator-sound (Ubuntu):
status: New → Confirmed
importance: Undecided → High
Changed in canonical-devices-system-image:
status: New → Confirmed
Revision history for this message
Ted Gould (ted) wrote :

Changed title. I use the indicator-sound ones everyday with Rhythmbox, they work fine.

summary: - indicator-sound does not display media controls and the controls aren't
- fully working
+ Media Hub not exporting MPRIS controls
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Yeah they do work, but there's changes to the controls that will be necessary such as not displaying next/previous buttons when has_next() and has_previous() return false. The new title is fine but doesn't quite capture the extent of the changes, hence this comment.

Revision history for this message
John McAleely (john.mcaleely) wrote :

so, are the changes to the controls in #8 something we need before progressing media-hub?

Changed in canonical-devices-system-image:
assignee: nobody → John McAleely (john.mcaleely)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

No there's nothing blocking media-hub's progress other than finishing up the background playlist support (actively being worked on). The indicator-sound changes could be done in parallel or slightly after, but these changes should be ready for the next OTA release.

Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww26-2015 → ww34-2015
importance: Undecided → High
Jim Hodapp (jhodapp)
affects: media-hub → ubuntu
affects: ubuntu → media-hub (Ubuntu)
Changed in media-hub (Ubuntu):
status: Triaged → In Progress
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
Revision history for this message
John McAleely (john.mcaleely) wrote :

@jim, does this one close when silo48 lands?

Revision history for this message
Jim Hodapp (jhodapp) wrote :

@john: no not yet, MPRIS controls will not be enabled with silo 48 landing yet. This will be the next landing in a separate silo after I've had time to debug why the MPRIS controls don't seem to do anything after the interface has been re-enabled in media-hub.

Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

I've been looking at this issue and I've found that Rhythmbox returns false for both properties: CanGoNext and CanGoPrevious when the player is not playing anything, after pressing play it returns true to both properties and next and previous buttons do what we expect.
Banshee returns true even if the player is not yet playing anything and starts playing when the previous or next buttons are clicked.

The question here wold be: What should we do in the case of Rhythmbox?

Should we show the next and previous buttons although we know that they are going to do nothing until something is playing?

Should we consider this as a bug of Rhythmbox?

The question about if showing the buttons or not in this case I guess is something to be answered by the desing team.

John McAleely (john.mcaleely)
Changed in canonical-devices-system-image:
milestone: ww34-2015 → ww40-2015
Revision history for this message
Sebastien Bacher (seb128) wrote :

@Xavi, not allowing to do next/previous when nothing is playing seems logical to me? but yeah, seems like one for design...

Revision history for this message
Jim Hodapp (jhodapp) wrote :

I believe the next/previous buttons should be greyed out or visually disabled somehow when CanGoNext/CanGoPrevious are true. This will be a lot better than displaying the buttons that look fully functional even when they're not.

Jim Hodapp (jhodapp)
Changed in indicator-sound (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Xavi Garcia (xavi-garcia-mena)
Jim Hodapp (jhodapp)
Changed in media-hub (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
John McAleely (john.mcaleely) wrote :

OK, so we've broken out the indicator work into bug #1488569. Landing the MPRIS controls is stalled until that bug is fixed.

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

no really this time

Changed in canonical-devices-system-image:
milestone: ww40-2015 → ww46-2015
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Don't jinx it until QA passes the silo. ;)

Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-sound - 12.10.2+15.10.20151019-0ubuntu1

---------------
indicator-sound (12.10.2+15.10.20151019-0ubuntu1) wily; urgency=medium

  [ Xavi Garcia Mena ]
  * Wily branch for MPRIS controls (LP: #1373313)

 -- Alfonso Sanchez-Beato <email address hidden> Mon, 19 Oct 2015 07:54:05 +0000

Changed in indicator-sound (Ubuntu):
status: In Progress → Fix Released
Jim Hodapp (jhodapp)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
Changed in media-hub (Ubuntu):
status: Fix Committed → Fix Released
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: Fix Released → Fix Committed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.