Mir

[regression] mir demo servers segfault on shutdown

Bug #1371619 reported by Kevin DuBois
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Kevin DuBois
Mir 0.8.0
mir (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

the mir_demo_servers have started segfaulting once they are sent sigterm. The backtrace isn't very useful.
This seems to be caused by change 1924 (the touchspot change), and seems to do with the changes to the way gralloc is accessed.

This only affects 'stable device' so it seems like its in the same ballpark as: #1370555

Tags: regression

Related branches

lp://staging/~kdub/mir/fix-1371619
Cemil Azizoglu (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Daniel van Vugt: Needs Information
Alexandros Frantzis (community): Approve
Diff: 169 lines (+80/-5)
5 files modified
src/platform/graphics/android/device_quirks.cpp (+21/-4)
src/platform/graphics/android/device_quirks.h (+3/-0)
src/platform/graphics/android/platform.cpp (+15/-1)
src/platform/graphics/android/platform.h (+2/-0)
tests/unit-tests/graphics/android/test_device_detection.cpp (+39/-0)
lp://staging/~vanvugt/mir/revert-r1924
Rejected for merging into lp://staging/mir
PS Jenkins bot (community): Approve (continuous-integration)
Mir development team: Pending requested
Diff: 3409 lines (+90/-2077)
72 files modified
include/platform/mir/graphics/platform.h (+0/-3)
include/platform/mir/options/configuration.h (+0/-1)
include/server/mir/default_server_configuration.h (+2/-5)
include/server/mir/input/cursor_listener.h (+2/-2)
platform-ABI-sha1sums (+2/-2)
playground/demo-shell/demo_compositor.cpp (+1/-6)
playground/demo-shell/demo_renderer.cpp (+3/-8)
playground/demo-shell/demo_renderer.h (+1/-7)
server-ABI-sha1sums (+4/-5)
src/include/platform/mir/graphics/buffer_writer.h (+0/-44)
src/include/platform/mir/graphics/native_platform.h (+0/-3)
src/include/server/mir/compositor/scene_element.h (+0/-4)
src/include/server/mir/input/input_targets.h (+8/-23)
src/include/server/mir/input/touch_visualizer.h (+2/-6)
src/include/server/mir/scene/legacy_scene_change_notification.h (+0/-2)
src/include/server/mir/scene/observer.h (+0/-4)
src/platform/graphics/android/CMakeLists.txt (+0/-1)
src/platform/graphics/android/display.cpp (+1/-1)
src/platform/graphics/android/platform.cpp (+0/-6)
src/platform/graphics/android/platform.h (+0/-1)
src/platform/graphics/mesa/CMakeLists.txt (+0/-1)
src/platform/graphics/mesa/buffer_allocator.cpp (+1/-1)
src/platform/graphics/mesa/buffer_writer.cpp (+0/-40)
src/platform/graphics/mesa/buffer_writer.h (+0/-43)
src/platform/graphics/mesa/native_platform.cpp (+0/-5)
src/platform/graphics/mesa/native_platform.h (+0/-1)
src/platform/graphics/mesa/platform.cpp (+0/-6)
src/platform/graphics/mesa/platform.h (+0/-1)
src/platform/graphics/mesa/shm_buffer.cpp (+0/-13)
src/platform/graphics/mesa/shm_buffer.h (+0/-2)
src/platform/options/default_configuration.cpp (+1/-3)
src/platform/symbols.map (+0/-1)
src/server/graphics/default_configuration.cpp (+0/-10)
src/server/graphics/nested/nested_platform.cpp (+0/-5)
src/server/graphics/nested/nested_platform.h (+0/-1)
src/server/input/CMakeLists.txt (+0/-1)
src/server/input/android/android_input_registrar.cpp (+0/-4)
src/server/input/android/android_input_registrar.h (+0/-1)
src/server/input/android/android_input_target_enumerator.cpp (+4/-4)
src/server/input/android/android_input_target_enumerator.h (+3/-3)
src/server/input/android/input_sender.cpp (+5/-9)
src/server/input/android/input_sender.h (+0/-1)
src/server/input/cursor_controller.cpp (+3/-8)
src/server/input/cursor_controller.h (+3/-3)
src/server/input/default_configuration.cpp (+10/-16)
src/server/input/touchspot_controller.cpp (+0/-166)
src/server/input/touchspot_controller.h (+0/-77)
src/server/input/touchspot_image.c (+0/-1034)
src/server/scene/basic_surface.cpp (+1/-0)
src/server/scene/default_configuration.cpp (+2/-2)
src/server/scene/legacy_scene_change_notification.cpp (+0/-5)
src/server/scene/surface_stack.cpp (+0/-78)
src/server/scene/surface_stack.h (+3/-16)
src/server/symbols.map (+1/-4)
tests/acceptance-tests/test_nested_mir.cpp (+1/-6)
tests/acceptance-tests/test_touchspot_visualization.cpp (+0/-2)
tests/include/mir_test_doubles/null_platform.h (+2/-7)
tests/include/mir_test_doubles/stub_input_targets.h (+5/-16)
tests/include/mir_test_doubles/stub_scene_element.h (+0/-5)
tests/include/mir_test_doubles/stub_touch_visualizer.h (+0/-6)
tests/integration-tests/input/android/test_android_cursor_listener.cpp (+1/-1)
tests/integration-tests/input/android/test_android_input_manager.cpp (+1/-1)
tests/integration-tests/input/test_nested_input.cpp (+1/-1)
tests/mir_test_framework/stubbed_server_configuration.cpp (+0/-13)
tests/unit-tests/frontend/test_session_mediator.cpp (+0/-1)
tests/unit-tests/graphics/mesa/test_shm_buffer.cpp (+1/-1)
tests/unit-tests/graphics/nested/test_nested_platform.cpp (+0/-5)
tests/unit-tests/input/CMakeLists.txt (+0/-1)
tests/unit-tests/input/android/test_android_input_target_enumerator.cpp (+4/-5)
tests/unit-tests/input/test_cursor_controller.cpp (+11/-12)
tests/unit-tests/input/test_touchspot_controller.cpp (+0/-199)
tests/unit-tests/scene/test_surface_stack.cpp (+0/-96)
lp://staging/ubuntu/utopic-proposed/mir
Kevin DuBois (kdub)
Changed in mir:
importance: Undecided → High
summary: - mir demo servers segfault on shutdown
+ [regression] mir demo servers segfault on shutdown
Cemil Azizoglu (cemil-azizoglu)
tags: added: regression
Revision history for this message
Kevin DuBois (kdub) wrote :

Seems the change in 1924 caused the android buffer allocator on this device to opened twice, where as before it was only opened once. So there isn't really a bug contained in 'the content' of rev1924, but rather it changed the lifetime of the buffer allocator in such a way that it exposed a bug in this device's driver. It does look like a dup of lp: #1370555

Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.8.0
Daniel van Vugt (vanvugt)
Changed in mir:
status: New → In Progress
assignee: nobody → Kevin DuBois (kdub)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.8.0

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Invalid for Ubuntu. The bug was never released (it regressed and was fixed entirely in the 0.8 series before the 0.8.0 release).

Changed in mir (Ubuntu):
status: New → Invalid
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.5 KiB)

This bug was fixed in the package mir - 0.8.0+14.10.20141010-0ubuntu1

---------------
mir (0.8.0+14.10.20141010-0ubuntu1) utopic; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.8.0 (https://launchpad.net/mir/+milestone/0.8.0)
    - Enhancements:
      . Less sensitivity to ABI breaks - many headers unused by external
        projects are now hidden and not installed by -dev packaes. If you
        require any headers that are missing, just ask.
      . Touchspots: --enable-touchspots to servers; visually shows touch
        locations (warning: This affects performance LP: #1373692).
      . Client performance reporting: Any Mir client can now get accurate
        performance information (frame rate, render time, buffer lag etc)
        logged to stdout. Just set env MIR_CLIENT_PERF_REPORT=log
      . Further improved touch responsiveness, with less lag and smoother
        scrolling (so long as you don't enable touchspots).
      . Slightly faster builds using precompiled headers.
      . Turn hardware overlays on by default. When in use, this halves the
        CPU usage of a Mir server. Already enabled in unity-system-compositor.
      . More scripting to detect ABI breaks.
      . Improved src/ tree consistency (renamed "src/shared" to "src/common").
      . Improved fatal signal design: Changed from SIGTERM to SIGHUP delivered
        to clients on unexpected server disconnection.
      . Improved library/package design to allow concurrent installations
        of different Mir versions without conflicts.
      . Fd reception code is now common to client and server.
    - ABI summary: Servers need rebuilding, but clients do not;
      . Mirclient ABI unchanged at 8
      . Mircommon ABI bumped to 2
      . Mirplatform ABI bumped to 3
      . Mirserver ABI bumped to 26
    - API changes between Mir 0.7 and 0.8:
      . Lots of headers removed from the public SDK! We have only hidden
        headers not known to be used by any known projects. Please let us
        know if anything is missing - https://bugs.launchpad.net/mir/+filebug
      . graphics::Platform - interface changed significantly.
      . Lots of server API changes to support touchspots.
      . File descriptors now passed as type Fd instead of int32_t.
    - Bug fixes:
      . [regression] Mir deb packages with versioned names cannot be installed
        simultaneously any more (LP: #1293944)
      . A frozen client can hang the whole server (LP: #1350207)
      . QtMir FTBFS: fatal error: mir/input/input_channel.h: No such file or
        directory (LP: #1365934)
      . [regression] platform-api fails to build against Mir 0.8 (LP: #1368354)
      . Mir FTBFS with gcc 4.9.1-14 (utopic update):
        auto_unblock_thread.h:44:46: error: no matching function for call to
        ‘std::thread::thread(<brace-enclosed initializer list>)’ (LP: #1369389)
      . [regression] Compositing is jerky and stutters during touch events
        (LP: #1372850)
      . unit test fails: AndroidInputReceiverSetup.slow_raw_input_doesnt_cause_
        frameskipping (LP: #1373826)
      . intermittent hang in TestClientInput (LP: #1338612)
      . TestClientInput.scene_obscure_mo...

Read more...

Changed in mir (Ubuntu):
status: Invalid → Fix Released
Daniel van Vugt (vanvugt)
Changed in mir (Ubuntu):
status: Fix Released → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.