Mir

[regression] platform-api fails to build against Mir 0.8

Bug #1368354 reported by Kevin DuBois
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Critical
Kevin DuBois
platform-api
Won't Fix
Undecided
Unassigned
mir (Ubuntu)
Invalid
Undecided
Unassigned
mir (Ubuntu RTM)
Invalid
Undecided
Unassigned

Bug Description

Building platform-api under sbuild with packages generated from lp:mir/devel fails to build because of:

[ 38%] Building CXX object src/ubuntu/application/common/mirclient/CMakeFiles/ubuntu_application_api_mirclient.dir/ubuntu_application_api_mirclient.cpp.o
cd /«BUILDDIR»/platform-api-2.2.0+14.10.20140829/obj-arm-linux-gnueabihf/src/ubuntu/application/common/mirclient && /usr/bin/arm-linux-gnueabihf-g++-4.9 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fvisibility=hidden --std=c++11 -fPIC -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/include -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/android/include -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/src -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/obj-arm-linux-gnueabihf/include -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/src/ubuntu/application/../../bridge -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/src/ubuntu/application/common -I/usr/include/mirclient -I/usr/include/mircommon -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/obj-arm-linux-gnueabihf/src/ubuntu/application/common/mirclient -o CMakeFiles/ubuntu_application_api_mirclient.dir/ubuntu_application_api_mirclient.cpp.o -c /«BUILDDIR»/platform-api-2.2.0+14.10.20140829/src/ubuntu/application/common/mirclient/ubuntu_application_api_mirclient.cpp
/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/src/ubuntu/application/common/mirclient/ubuntu_application_api_mirclient.cpp:37:32: fatal error: mir/client/private.h: No such file or directory
 #include <mir/client/private.h>

It seems the rpc channel is used by them for some clipboard functionality:
http://bazaar.launchpad.net/~phablet-team/platform-api/trunk/view/head:/src/ubuntu/application/common/mirclient/ubuntu_application_api_mirclient.cpp#L37

Tags: regression

Related branches

Revision history for this message
Kevin DuBois (kdub) wrote :

Seems just to be some overprivatization will reintroduce the header. Issue would exist from lp:mir/devel rev 1891 and up.

description: updated
Changed in mir:
status: New → In Progress
Revision history for this message
Kevin DuBois (kdub) wrote :

a few more headers are needed too:

[ 48%] Building CXX object src/ubuntu/application/common/mirserver/CMakeFiles/ubuntu_application_api_mirserver.dir/ubuntu_application_api_mirserver.cpp.o
cd /«BUILDDIR»/platform-api-2.2.0+14.10.20140829/obj-arm-linux-gnueabihf/src/ubuntu/application/common/mirserver && /usr/bin/arm-linux-gnueabihf-g++-4.9 -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fvisibility=hidden --std=c++11 -fPIC -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/include -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/android/include -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/src -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/obj-arm-linux-gnueabihf/include -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/src/ubuntu/application/../../bridge -I/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/src/ubuntu/application/common -I/usr/include/mirserver -I/usr/include/mirclient -I/usr/include/mircommon -I/usr/include/mirplatform -o CMakeFiles/ubuntu_application_api_mirserver.dir/ubuntu_application_api_mirserver.cpp.o -c /«BUILDDIR»/platform-api-2.2.0+14.10.20140829/src/ubuntu/application/common/mirserver/ubuntu_application_api_mirserver.cpp
/«BUILDDIR»/platform-api-2.2.0+14.10.20140829/src/ubuntu/application/common/mirserver/ubuntu_application_api_mirserver.cpp:44:35: fatal error: mir/graphics/platform.h: No such file or directory

Revision history for this message
Daniel van Vugt (vanvugt) wrote : Re: [regression] platform-api fails to build because of moved header

Thanks. It seems in testing external projects I forgot platform API... kind of. Since I intentionally did not move any client toolkit headers I assumed no clients/toolkits could be affected by the change. But I didn't expect to see any toolkits like this using non-toolkit headers.

summary: - platform-api fails to build because of moved header
+ [regression] platform-api fails to build because of moved header
tags: added: regression
summary: - [regression] platform-api fails to build because of moved header
+ [regression] platform-api fails to build against Mir 0.8
Changed in mir:
importance: High → Critical
Changed in platform-api:
importance: Undecided → Critical
Changed in platform-api:
status: New → Won't Fix
importance: Critical → Undecided
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir/devel at revision 1912, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Invalid for Ubuntu. The bug was never released (it regressed and was fixed entirely in the 0.8 series before the 0.8.0 release).

Changed in mir (Ubuntu):
status: New → Invalid
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.5 KiB)

This bug was fixed in the package mir - 0.8.0+14.10.20141010-0ubuntu1

---------------
mir (0.8.0+14.10.20141010-0ubuntu1) utopic; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.8.0 (https://launchpad.net/mir/+milestone/0.8.0)
    - Enhancements:
      . Less sensitivity to ABI breaks - many headers unused by external
        projects are now hidden and not installed by -dev packaes. If you
        require any headers that are missing, just ask.
      . Touchspots: --enable-touchspots to servers; visually shows touch
        locations (warning: This affects performance LP: #1373692).
      . Client performance reporting: Any Mir client can now get accurate
        performance information (frame rate, render time, buffer lag etc)
        logged to stdout. Just set env MIR_CLIENT_PERF_REPORT=log
      . Further improved touch responsiveness, with less lag and smoother
        scrolling (so long as you don't enable touchspots).
      . Slightly faster builds using precompiled headers.
      . Turn hardware overlays on by default. When in use, this halves the
        CPU usage of a Mir server. Already enabled in unity-system-compositor.
      . More scripting to detect ABI breaks.
      . Improved src/ tree consistency (renamed "src/shared" to "src/common").
      . Improved fatal signal design: Changed from SIGTERM to SIGHUP delivered
        to clients on unexpected server disconnection.
      . Improved library/package design to allow concurrent installations
        of different Mir versions without conflicts.
      . Fd reception code is now common to client and server.
    - ABI summary: Servers need rebuilding, but clients do not;
      . Mirclient ABI unchanged at 8
      . Mircommon ABI bumped to 2
      . Mirplatform ABI bumped to 3
      . Mirserver ABI bumped to 26
    - API changes between Mir 0.7 and 0.8:
      . Lots of headers removed from the public SDK! We have only hidden
        headers not known to be used by any known projects. Please let us
        know if anything is missing - https://bugs.launchpad.net/mir/+filebug
      . graphics::Platform - interface changed significantly.
      . Lots of server API changes to support touchspots.
      . File descriptors now passed as type Fd instead of int32_t.
    - Bug fixes:
      . [regression] Mir deb packages with versioned names cannot be installed
        simultaneously any more (LP: #1293944)
      . A frozen client can hang the whole server (LP: #1350207)
      . QtMir FTBFS: fatal error: mir/input/input_channel.h: No such file or
        directory (LP: #1365934)
      . [regression] platform-api fails to build against Mir 0.8 (LP: #1368354)
      . Mir FTBFS with gcc 4.9.1-14 (utopic update):
        auto_unblock_thread.h:44:46: error: no matching function for call to
        ‘std::thread::thread(<brace-enclosed initializer list>)’ (LP: #1369389)
      . [regression] Compositing is jerky and stutters during touch events
        (LP: #1372850)
      . unit test fails: AndroidInputReceiverSetup.slow_raw_input_doesnt_cause_
        frameskipping (LP: #1373826)
      . intermittent hang in TestClientInput (LP: #1338612)
      . TestClientInput.scene_obscure_mo...

Read more...

Changed in mir (Ubuntu):
status: Invalid → Fix Released
Changed in mir (Ubuntu):
status: Fix Released → Invalid
Changed in mir (Ubuntu RTM):
status: New → Invalid
Changed in mir (Ubuntu RTM):
status: Invalid → Fix Released
Changed in mir (Ubuntu RTM):
status: Fix Released → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.