Ubuntu UX

[SDK] Bottom edge behaviour needs refining

Bug #1368811 reported by Jouni Helminen on 2014-09-12

This bug affects 3 people

	Status	Importance	Assigned to	Milestone
Canonical System Image	Fix Released	Undecided	Zoltan Balogh	Canonical System Image ww02-2016 "ota9"
Ubuntu UX	Fix Released	Critical	Olga Kemmet
ubuntu-ui-toolkit (Ubuntu RTM)	Fix Released	Critical	Zsombor Egri

Bug Description

- Move the bottom edge hint into the SDK so it's behavour is consistent across apps, and make the hiding of the bottom edge hint less aggressive.
- When the user grabs the bottom edge, leave the tab visible until the user releases
- Find a way to make it possible to pull down screens accessed via the bottom edge to make the gesture reversible.

-------------- UX comment --------------

The spec for the bottom edge was updated into the UI toolkit documentation.
https://docs.google.com/document/d/1nFm8xiYhKXXuEO_IvMXoD0lASbYzYXva1BWMVanU3iw/edit?pli=1#heading=h.y7e1o2x66nvr

See original description

Tags:

Related branches

lp://staging/~zsombi/ubuntu-ui-toolkit/bottomEdge

Merged into lp://staging/ubuntu-ui-toolkit/staging at revision 1731

PS Jenkins bot: Approve (continuous-integration) on 2015-11-30

Tim Peeters: Approve on 2015-11-30

Diff: 4292 lines (+3826/-40)

47 files modified

components.api (+48/-0)
examples/ubuntu-ui-toolkit-gallery/BottomEdgePage.qml (+177/-14)
examples/ubuntu-ui-toolkit-gallery/Template.qml (+1/-0)
examples/ubuntu-ui-toolkit-gallery/TemplateRow.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/gallery-logging.config (+1/-0)
src/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+0/-2)
src/Ubuntu/Components/1.3/PageTreeNode.qml (+0/-4)
src/Ubuntu/Components/ComponentModule.pro (+1/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/BottomEdgeStyle.qml (+125/-0)
src/Ubuntu/Components/Themes/Ambiance/Ambiance.pro (+2/-1)
src/Ubuntu/Components/Themes/Ambiance/qmldir (+2/-0)
src/Ubuntu/Components/plugin/plugin.cpp (+6/-0)
src/Ubuntu/Components/plugin/plugin.pri (+9/-2)
src/Ubuntu/Components/plugin/ucaction.h (+6/-5)
src/Ubuntu/Components/plugin/ucbottomedge.cpp (+1059/-0)
src/Ubuntu/Components/plugin/ucbottomedge.h (+120/-0)
src/Ubuntu/Components/plugin/ucbottomedge_p.h (+111/-0)
src/Ubuntu/Components/plugin/ucbottomedgehint.cpp (+1/-1)
src/Ubuntu/Components/plugin/ucbottomedgehint.h (+2/-0)
src/Ubuntu/Components/plugin/ucbottomedgeregion.cpp (+253/-0)
src/Ubuntu/Components/plugin/ucbottomedgeregion.h (+78/-0)
src/Ubuntu/Components/plugin/ucbottomedgestyle.cpp (+65/-0)
src/Ubuntu/Components/plugin/ucbottomedgestyle.h (+60/-0)
src/Ubuntu/Components/plugin/ucstyleditembase.cpp (+21/-5)
src/Ubuntu/Components/plugin/ucstyleditembase.h (+1/-0)
src/Ubuntu/Components/plugin/ucstyleditembase_p.h (+2/-0)
src/Ubuntu/Test/plugin/uctestextras.cpp (+136/-3)
src/Ubuntu/Test/plugin/uctestextras.h (+6/-0)
tests/unit_x11/tst_bottomedge/AddCustomRegionOnCompleted.qml (+41/-0)
tests/unit_x11/tst_bottomedge/AddCustomRegionOwnedByOtherBottomEdge.qml (+39/-0)
tests/unit_x11/tst_bottomedge/AddCustomRegionUsingDataProperty.qml (+33/-0)
tests/unit_x11/tst_bottomedge/AddCustomRegionUsingRegionsProperty.qml (+33/-0)
tests/unit_x11/tst_bottomedge/AlternateDefaultRegionContent.qml (+53/-0)
tests/unit_x11/tst_bottomedge/AlternateRegionContent.qml (+47/-0)
tests/unit_x11/tst_bottomedge/AutoCollapseInPageHeader.qml (+45/-0)
tests/unit_x11/tst_bottomedge/AutoCollapseInPageWithPageHeader.qml (+44/-0)
tests/unit_x11/tst_bottomedge/BottomEdgeInItem.qml (+36/-0)
tests/unit_x11/tst_bottomedge/ClearCustomRegions.qml (+42/-0)
tests/unit_x11/tst_bottomedge/Defaults.qml (+28/-0)
tests/unit_x11/tst_bottomedge/DifferentSizes.qml (+34/-0)
tests/unit_x11/tst_bottomedge/LastItem.qml (+46/-0)
tests/unit_x11/tst_bottomedge/LeanActiveRegionChange.qml (+45/-0)
tests/unit_x11/tst_bottomedge/OverlappingRegions.qml (+46/-0)
tests/unit_x11/tst_bottomedge/ShorterBottomEdge.qml (+39/-0)
tests/unit_x11/tst_bottomedge/tst_bottomedge.cpp (+856/-0)
tests/unit_x11/tst_bottomedge/tst_bottomedge.pro (+23/-0)
tests/unit_x11/unit_x11.pro (+2/-1)

lp://staging/~zsombi/ubuntu-ui-toolkit/lambdaSegfault

Merged into lp://staging/ubuntu-ui-toolkit/staging at revision 1739

Tim Peeters: Approve on 2015-12-04

PS Jenkins bot: Approve (continuous-integration) on 2015-12-03

Jouni Helminen (jounihelminen) on 2014-09-12

Changed in ubuntu-ux:
assignee:	nobody → Jouni Helminen (jounihelminen)

Revision history for this message

Jouni Helminen (jounihelminen) wrote on 2014-09-19:

Unable to tag, this should be OTA

tags:	added: ota
tags:	added: ota-1 removed: ota

Giorgio Venturi (giorgio-venturi-deactivatedaccount) on 2014-09-19

Changed in ubuntu-ux:
status:	New → Triaged
importance:	Undecided → Medium

Revision history for this message

Tim Peeters (tpeeters) wrote on 2014-09-22:

I think this needs some good input from design first. For example, do you have ideas on where/how to swipe down something that you swiped in from the bottom edge? Top-edge swipe is already for indicators.

Also, I think the third point is a separate (follow-up) bug for the first two. Please separate the bugs as much as possible, and let's use a tag "bottom-edge" to group them. Thanks :)

tags:	added: bottom-edge
Changed in ubuntu-ui-toolkit:
status:	New → Incomplete
importance:	Undecided → Medium

Giorgio Venturi (giorgio-venturi-deactivatedaccount) on 2014-10-02

summary:

- Bottom edge behaviour needs refining
+ [SDK] Bottom edge behaviour needs refining

Zsombor Egri (zsombi) on 2014-10-13

Changed in ubuntu-ui-toolkit:
milestone:	none → upcoming-15.04

Zoltan Balogh (bzoltan) on 2014-11-24

Changed in ubuntu-ui-toolkit (Ubuntu):
assignee:	nobody → Tim Peeters (tpeeters)
importance:	Undecided → Medium
status:	New → Incomplete

Zoltan Balogh (bzoltan) on 2014-11-24

no longer affects:

ubuntu-ui-toolkit

Jouni Helminen (jounihelminen) on 2015-03-18

Changed in ubuntu-ux:
status:	Triaged → In Progress

John Lea (johnlea) on 2015-04-08

Changed in ubuntu-ux:
status:	In Progress → Triaged

Jouni Helminen (jounihelminen) on 2015-08-03

Changed in ubuntu-ux:
status:	Triaged → Fix Committed
status:	Fix Committed → In Progress

Tim Peeters (tpeeters) on 2015-10-08

Changed in ubuntu-ui-toolkit (Ubuntu):
assignee:	Tim Peeters (tpeeters) → nobody
assignee:	nobody → Zsombor Egri (zsombi)

Olga Kemmet (olga-kemmet) on 2015-10-09

Changed in ubuntu-ux:
assignee:	Jouni Helminen (jounihelminen) → nobody
assignee:	nobody → Olga Kemmet (olga-kemmet)

Olga Kemmet (olga-kemmet) on 2015-10-19

Changed in ubuntu-ux:
status:	In Progress → Fix Committed
description:	updated

Revision history for this message

Zsombor Egri (zsombi) wrote on 2015-11-19:

Raised to Critical, should be included in OTA-9

Changed in ubuntu-ui-toolkit (Ubuntu):
importance:	Medium → Critical
tags:	added: convergence removed: ota-1
Changed in ubuntu-ui-toolkit (Ubuntu):
status:	Incomplete → In Progress

Timo Jyrinki (timo-jyrinki) on 2015-11-19

Changed in canonical-devices-system-image:
milestone:	none → ww02-2016

Zsombor Egri (zsombi) on 2015-11-19

Changed in canonical-devices-system-image:
status:	New → In Progress

Timo Jyrinki (timo-jyrinki) on 2015-11-19

Changed in canonical-devices-system-image:
assignee:	nobody → Zoltan Balogh (bzoltan)

Olga Kemmet (olga-kemmet) on 2015-11-20

Changed in ubuntu-ux:
importance:	Medium → Critical

Zsombor Egri (zsombi) on 2015-12-03

Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status:	New → In Progress
assignee:	nobody → Zsombor Egri (zsombi)
importance:	Undecided → Critical

Zoltan Balogh (bzoltan) on 2015-12-05

no longer affects:

ubuntu-ui-toolkit (Ubuntu)

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2015-12-11:

Download full text (6.8 KiB)

This bug was fixed in the package ubuntu-ui-toolkit 1.3.1742+15.04.20151209-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ubuntu-ui-toolkit (1.3.1742+15.04.20151209-0ubuntu1) vivid; urgency=medium

  [ Zoltán Balogh ]
  * Enable building the UITK tests in any case.
  * Remove Q_Q(UCStyledItemBase) because of unused variable warning.
  * Resolve Trusty specific compiler issue not resolving QPointer data on
    connections.
  * Use only the object name when selecting sections and labels in tests.

  [Zsombor Egri ]
  * Update BottomEdge with UI/UX agreed during the sprint. Fixes LP: #1368811.
  * BottomEdge component. Fixes LP: #1368811.
  * Remove build failure on Xenial caused by deprecated Qt functions.
  * Fix BottomEdgeHint consumes activeFocusOnPress handling. Fixes LP: #1517777
  * Migrate DirectionalDragArea from Unity8, named as SwipeArea. Original code
    (from lp:unity8) by: Daniel d'Andrada <email address hidden>.
  * Delete QQuickView when the application quits. Fixing segfault caused by the
    dangling objects in GestireDetector.
  * BottomEdgeHint API changes, deprecating state property, introducing locked
    property to drive visuals lock and click handling.
  * Fixing CheckBox and Switch getting checked property altered after clicked()
    signal is emitted. Fixes LP: #1510919.
  * Add ListItem.swipeEnabled property to block swiping when overlay MouseArea
    is used to drag content. Fixes swiping when leading/trailing actions list
    is empty. Fixes LP: #1500409, LP: #1500416.
  * Follow the new design in BottomEdgeHint.
  * Provide import version information for StyledItem and remove theme.version
    obsolete property.
  * Use QQuickItemChangeListener to listen parent changes, skipping the meta
    object model. Convert UCThemingExtension into a Q_INTERFACE so object_cast<>
    can work with it saving the need to memorise on an item whether it is an
    extended item or not.
  * Set mouseAttached to false to revert regression in UITK gallery.
  * Remove BottomEdgeHint from UITK gallery's MainPage.qml which occludes with
    the bottom-up dragging of the ListView.

  [ Benjamin Zeller ]
  * Avoid unnecessary updates for i18n strings.
  * "MathUtils.clamp, min value should not be bigger than the max value".
    Fixes LP: #1520557.
  * Move MathUtils to Cpp.

  [ Loïc Molinari ]
  * UbuntuShape - Fixed deprecation logging issues.
  * This fix prevents logging a deprecation warning for "image", "color" and
    "gradientColor" properties when the import version is less than 1.3. The
    logging of properties used internally (through the old image wrapper) have
    been removed too since the user might not even have used them.
    Fixes LP: #1519414.

This bug was fixed in the package ubuntu-ui-toolkit 1.3.1742+15.04.20151209-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ubuntu-ui-toolkit (1.3.1742+15.04.20151209-0ubuntu1) vivid; urgency=medium

[Zsombor Egri ]
  * Update BottomEdge with UI/UX agreed during the sprint. Fixes LP: #1368811.
  * BottomEdge component. Fixes LP: #1368811.
  * Remove build failure on Xenial caused by deprecated Qt functions.
  * Fix BottomEdgeHint consumes activeFocusOnPress handling. Fixes LP: #1517777
  * Migrate DirectionalDragArea from Unity8, named as SwipeArea. Original code
    (from lp:unity8) by: Daniel d'Andrada <daniel.dandrada@canonical.com>.
  * Delete QQuickView when the application quits. Fixing segfault caused by the
    dangling objects in GestireDetector.
  * BottomEdgeHint API changes, deprecating state property, introducing locked
    property to drive visuals lock and click handling.
  * Fixing CheckBox and Switch getting checked property altered after clicked()
    signal is emitted. Fixes LP: #1510919.
  * Add ListItem.swipeEnabled property to block swiping when overlay MouseArea
    is used to drag content. Fixes swiping when leading/trailing actions list
    is empty. Fixes LP: #1500409, LP: #1500416.
  * Follow the new design in BottomEdgeHint.
  * Provide import version information for StyledItem and remove theme.version
    obsolete property.
  * Use QQuickItemChangeListener to listen parent changes, skipping the meta
    object model. Convert UCThemingExtension into a Q_INTERFACE so object_cast<>
    can work with it saving the need to memorise on an item whether it is an
    extended item or not.
  * Set mouseAttached to false to revert regression in UITK gallery.
  * Remove BottomEdgeHint from UITK gallery's MainPage.qml which occludes with
    the bottom-up dragging of the ListView.

[ Benjamin Zeller ]
  * Avoid unnecessary updates for i18n strings.
  * "MathUtils.clamp, min value should not be bigger than the max value".
    Fixes LP: #1520557.
  * Move MathUtils to Cpp.

[ Christian Dywan ]
  * Enable gallery target in qmake.
  * Don't set activeFocusOnPress on TextField but on child only.
    Fixes LP: #1486274, LP: #1513897.
  * Make runtest.sh work out of the box again.
  * Explicitly handle keyboard anchoring in dialog foreground.
    Fixes LP: #1376763.
  * Remove GestureDetector in favor of SwipeArea in BottomEdgeHint. Also make
    possible to assign Action to the component. Fixes LP: #1517771, LP: #1517798
  * Enforce !activeFocusOnPress on TextField primary/secondaryItem.
    Fixes LP: #1513897.
  * Only run ActivityIndicator if visible. Fixes LP: #1513450.
  * Use wait_select_single for _get_button in Popover CPO.
  * Include composite types in .api again.
  * More forgiving QML plugin/ version discovery.
  * Update toolkit and gallery po templates. Fixes LP: #1512924.
  * Improve handling of list types in apicheck.
  * Smaller handlers, entirely draggable caret. Fixes LP: #1450222.
  * Special-case leaked QQuickImageBase properties. Fixes LP: #1473890.
  * Don't use UniqueConnection in the image extension
  * Sync the height of the Page header with the other subheaders in the
    AdaptivePageLayout.

[ Tim Peeters ]
  * Add extension property to PageHeader.
  * Don't set the header.moving property when flickable contents height changes
    but the header does not actually move. Fixes LP: #1514143.
  * Fix the icon color in the AppHeader. Fixes LP: #1515593.
  * Use PageHeader in the UITK gallery.
  * Ensure PageHeader style works properly with run-time theme changes.
  * Add a back action to the Page.header automatically in PageStack and
    AdaptivePageLayout.
  * Add a navigationActions property to PageHeader.
  * Fix links to Page in the documentation.
  * Fix several header CPO related issues.
  * Only select visible header label instance in checkPageHeader().

[ Florian Boucault ]
  * DraggingArea: import Ubuntu.Components so that MathUtils is available and
    no warning is output.

[ Brendan Donegan ]
  * Account for presence of OSK in Flickable helpers and add a test for the same

[ Andrea Bernabei ]
  * ListItemLayout: set QML context of the predefined labels. Fixes lp1514173.
    Fixes LP: #1514173.
  * Add the ignoreSynthesizedEvents property. When the property is enabled, the
    Mouse filter ignores any synthesized mouse event, such as those created by
    the touch-to-mouse events synthesis. Enabling this property makes it
    possible to only trigger the hovering logic ONLY when using a mouse, and not
    when using a touchscreen (as it happens when using MouseArea).

[ Timo Jyrinki ]
  * Change HandlerType from int[2] to QVector<int> to make it work with Qt 5.5
    Fixes LP: #1484004, LP: #1450346
  * Workaround 'emit' declaration in Qt 5.5 Fixes LP: #1507910
  * Build depend on libxkbcommon-dev Fixes LP: #1508447

[ CI Train Bot ]
  * No-change rebuild.

ubuntu-ui-toolkit (1.3.1705+16.04.20151120.1-0ubuntu2) xenial; urgency=medium

* Rebuild against Qt 5.5.1.
  * Cherry-pick required patches from staging branch:
    - externalimagetype.patch (LP: #1473890)
    - hack-qt55-int.patch (LP: #1484004)
    - workaround_emit.patch (LP: #1507910)

ubuntu-ui-toolkit (1.3.1705+16.04.20151120.1-0ubuntu1) xenial; urgency=medium

[ Timo Jyrinki ]
  * Update toolkit and gallery po templates and fixes LP: #1517829 (LP:
    #1517829)

[ Zoltán Balogh ]
  * Update toolkit and gallery po templates and fixes LP: #1517829 (LP:
    #1517829)

ubuntu-ui-toolkit (1.3.1705+16.04.20151118-0ubuntu1) xenial; urgency=medium

[ Zoltán Balogh ]
  * Update toolkit and gallery po templates

ubuntu-ui-toolkit (1.3.1705+16.04.20151103-0ubuntu1) xenial; urgency=medium

[ Zsombor Egri ]
  * Fix Sections sync with PageHeadSections selectedIndex changes. (LP:
    #1511839)

ubuntu-ui-toolkit (1.3.1705+16.04.20151031-0ubuntu1) xenial; urgency=medium

[ CI Train Bot ]
  * Resync trunk. added: po/vi.po

[ Christian Dywan ]
  * Smaller handlers, entirely draggable caret (LP: #1450222)

[ Zsombor Egri ]
  * Switch and CheckBox fix when checked is not toggled when clicked()
    signal is emitted. (LP: #1510919)

-- Zoltan Balogh <zoltan.balogh@canonical.com>  Wed, 09 Dec 2015 14:44:07 +0000

Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status:	In Progress → Fix Released

Jean-Baptiste Lallement (jibel) on 2015-12-11

Changed in canonical-devices-system-image:
status:	In Progress → Fix Committed

Revision history for this message

John Dolz (jdolz) wrote on 2016-01-03:

That Google docs link cannot be read without a Google account, which I don't have. Is there a public copy?

Revision history for this message

Andrea Bernabei (faenil) wrote on 2016-01-06:

Hi John,

the spec is currently an internal document dedicated to SDK devs.
I was told they will be moved to a public space once they're considered "final".

It would be great to also find a way to have them open from the start, to encourage contributions from the community, although that's always somewhat tricky to do properly.

Pat McGowan (pat-mcgowan) on 2016-01-27

Changed in canonical-devices-system-image:
status:	Fix Committed → Fix Released

Zsombor Egri (zsombi) on 2016-12-15

Changed in ubuntu-ux:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #1291477

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.