Ubuntu UI Toolkit

Editing alarm sounds doesn't actually change them

Bug #1364949 reported by Dave Morley on 2014-09-03

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Indicator Date and Time	Fix Released	Critical	Charles Kerr
Ubuntu UI Toolkit	Fix Released	Critical	Zsombor Egri	Ubuntu UI Toolkit 10.09
indicator-datetime (Ubuntu)	Fix Released	Undecided	Unassigned
qtorganizer5-eds (Ubuntu)	Invalid	Undecided	Unassigned
ubuntu-ui-toolkit (Ubuntu)	Fix Released	Undecided	Unassigned
Vivid	Fix Released	Undecided	Unassigned
ubuntu-ui-toolkit (Ubuntu RTM)	New	Undecided	Unassigned

Bug Description

STEPS:
1. Open the clock app
2. Swipe up from the bottom
3. Click on the + symbol
4. Save an alarm for a few minutes time leave everything on default settings
5. Click on save
6. Click on the alarm
7. Change the sound of the alram
8. Click on save
9. Let the alarm go off

EXPECTED:
I expected the sound I chose to play

ACTUAL:
The default harps played instead.

Tags:

Related branches

lp://staging/~zsombi/ubuntu-ui-toolkit/alarm-sound-update-fix

Merged into lp://staging/ubuntu-ui-toolkit/staging at revision 1239

PS Jenkins bot: Approve (continuous-integration) on 2014-09-05

Cris Dywan: Approve on 2014-09-04

Nekhelesh Ramananthan: Pending requested 2014-09-04

lp://staging/~zsombi/ubuntu-ui-toolkit/alarm-update-fixes

Merged into lp://staging/ubuntu-ui-toolkit/staging at revision 1283

PS Jenkins bot: Approve (continuous-integration) on 2014-10-08

Cris Dywan: Approve on 2014-10-07

lp://staging/~charlesk/indicator-datetime/lp-1364949-honor-changes-to-alarm-sounds

Merged into lp://staging/indicator-datetime/13.10 at revision 385

Antti Kaijanmäki (community): Approve on 2014-10-07

Brendan Donegan (brendan-donegan) on 2014-09-03

tags:

added: exploratory rtm14 testcase

Dave Morley (davmor2) on 2014-09-03

tags:

added: flo krillin mako manta
removed: rtm14

Nekhelesh Ramananthan (nik90) on 2014-09-03

Changed in ubuntu-clock-app:
status:	New → Confirmed
importance:	Undecided → Medium
milestone:	none → rtm

Nekhelesh Ramananthan (nik90) on 2014-09-03

tags:

added: rtm14

Nekhelesh Ramananthan (nik90) on 2014-09-03

Changed in ubuntu-ui-toolkit:
status:	New → Confirmed
Changed in ubuntu-clock-app:
status:	Confirmed → Invalid

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2014-09-03:

Just is the task.ics file that after updating the alarm. http://paste.ubuntu.com/8223955/ The interesting part is the two alarm sounds that are present in that file for one alarm.

no longer affects:

ubuntu-clock-app

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2014-09-03:

Another interesting tidbit, just before the alarm.save() function is called in the clock app, I outputted the alarm.sound property which correctly shows the sound chosen by the user indicating that something went wrong after the save() function call.

Zsombor Egri (zsombi) on 2014-09-04

Changed in ubuntu-ui-toolkit:
importance:	Undecided → Critical
assignee:	nobody → Zsombor Egri (zsombi)

Zsombor Egri (zsombi) on 2014-09-04

Changed in ubuntu-ui-toolkit:
status:	Confirmed → In Progress

Revision history for this message

Zsombor Egri (zsombi) wrote on 2014-09-04:

The sound is saved in the organiser event description as well to keep the sound URL even of the audible reminder is removed. The problem is that when only the alarm sound is changed, the audible reminder wasn't updated. So the error.

Zoltan Balogh (bzoltan) on 2014-09-12

Changed in ubuntu-ui-toolkit:
milestone:	none → september-2014

Zsombor Egri (zsombi) on 2014-09-12

Changed in ubuntu-ui-toolkit:
status:	In Progress → Fix Committed

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2014-09-29:

This bug still appears to be there

Revision history for this message

Zsombor Egri (zsombi) wrote on 2014-09-30:

Don't know what happened recently in EDS backend, but all I find now is that I cannot run the Alarm unit tests twice consecutively so I get the same results. One run produces 4 failures, then depending on how soon I run the next I get 1-4 failures... And between these the sound update fails once...

Revision history for this message

Zsombor Egri (zsombi) wrote on 2014-09-30:

EDS backend seems got some changes and/or some unimplemented things.

First, when UITK Alarm tests are run, which are all asynchronous, I have to add 400 msec wait time after each request wait completion, otherwise tests are failing randomly.

Second, when I update the type in an alarm, I'm getting an organizer item ID that has not been registered so far, and comparison is done using the QOrganizerItemId comparison. See paste bin [1]. However, when the sound is updated, I do get the changes perfectly, see [2]. But the IDs are still different for some reason.

Third, tags saving aint seem to work on EDS either. See logs for it in [2]. Note ALARMTAG and DISABLEDTAG logs show false, which is bad.

[1] http://pastebin.ubuntu.com/8464441/
[2] http://pastebin.ubuntu.com/8464733/
[3] http://pastebin.ubuntu.com/8464690/

Zsombor Egri (zsombi) on 2014-10-01

Changed in ubuntu-ui-toolkit:
status:	Fix Committed → In Progress

Zoltan Balogh (bzoltan) on 2014-10-01

Changed in ubuntu-ui-toolkit:
milestone:	september-2014 → 10.09

Pat McGowan (pat-mcgowan) on 2014-10-03

tags:

added: touch-2014-10-09

Revision history for this message

Zsombor Egri (zsombi) wrote on 2014-10-07:

Charles, no matter what sound I set in the tests, indicator plays the same "Suru arpeggio" sound. I guess you are aware of this, but we got this bug re-opened because of that.

Changed in indicator-datetime:
importance:	Undecided → Critical
assignee:	nobody → Charles Kerr (charlesk)

Charles Kerr (charlesk) on 2014-10-07

Changed in indicator-datetime:
status:	New → In Progress

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-08:

Fix committed into lp:ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status:	In Progress → Fix Committed

Thomas Strehl (strehl-t) on 2014-10-09

tags:

added: touch-2014-10-16
removed: touch-2014-10-09

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-10-10:

This bug was fixed in the package indicator-datetime - 13.10.0+14.10.20141009-0ubuntu1

---------------
indicator-datetime (13.10.0+14.10.20141009-0ubuntu1) utopic; urgency=low

  [ Charles Kerr ]
  * Fix appointment comparison function to include the audio_url field
    in its test. (LP: #1364949)
-- Ubuntu daily release <email address hidden> Thu, 09 Oct 2014 13:35:53 +0000

Changed in indicator-datetime (Ubuntu):
status:	New → Fix Released

Ted Gould (ted) on 2014-10-10

Changed in indicator-datetime:
status:	In Progress → Fix Released

Olli Ries (ories) on 2014-10-10

tags:	added: touch-2014-10-23 removed: touch-2014-10-16
tags:	added: touch-2014-10-16 removed: touch-2014-10-23

Zsombor Egri (zsombi) on 2014-10-18

Changed in qtorganizer5-eds (Ubuntu):
status:	New → Invalid

Tim Peeters (tpeeters) on 2014-10-24

Changed in ubuntu-ui-toolkit:
status:	Fix Committed → Fix Released

Robert Bruce Park (robru) on 2015-07-16

Changed in ubuntu-ui-toolkit (Ubuntu):
status:	New → Fix Released

Robert Bruce Park (robru) on 2015-07-16

Changed in ubuntu-ui-toolkit (Ubuntu Vivid):
status:	New → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Related blueprints

Alarms RTM

Remote bug watches

Bug watches keep track of this bug in other bug trackers.