Reviews mixed for languages like zh_{TW,CN}
Bug #1321154 reported by
Michael Vogt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scope-click (Ubuntu) |
Fix Released
|
High
|
dobey | ||
Bug Description
The current click scope is using the language part of the locale to submit reviews to the rnr-server. This works for most locales, but there are some exception where a more specific string must be send.
For zh_{CN,TW} its not enough to send zh as there are differences between the character sets (traditional vs simplified).
There was also pt/pt_BR in the past where the full pt_BR string was send. This may not/no longer be needed, input from a i18n expert or a native speaker would be good.
Related branches
lp://staging/~mvo/unity-scope-click/get-language-base-exceptions
- dobey (community): Disapprove
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 47 lines (+14/-1)3 files modifiedscope/click/configuration.cpp (+6/-0)
scope/tests/test_configuration.cpp (+7/-0)
scope/tests/test_reviews.cpp (+1/-1)
lp://staging/~dobey/unity-scope-click/full-langs
- PS Jenkins bot (community): Approve (continuous-integration)
- Alejandro J. Cura (community): Approve
- Paweł Stołowski (community): Needs Fixing
-
Diff: 140 lines (+66/-4)5 files modifiedlibclickscope/click/configuration.cpp (+15/-0)
libclickscope/click/configuration.h (+2/-0)
libclickscope/tests/test_configuration.cpp (+12/-0)
scope/click/reviews.cpp (+9/-2)
scope/tests/test_reviews.cpp (+28/-2)
| summary: |
- Do not mix reviews for locales like zh_{TW,CN} + Reviews mixed for languages like zh_{TW,CN} |
| description: | updated |
| Changed in unity-scope-click (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Rodney Dawes (dobey) |
| importance: | Undecided → High |
| Changed in unity-scope-click (Ubuntu): | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity-scope-click (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package unity-scope-click - 0.1+14.
---------------
unity-scope-click (0.1+14.
[ Rodney Dawes ]
* Handle some languages differently when submitting reviews. (LP:
#1321154). Add runtime dependency on ubuntu-sdk-libs for the
frameworks list. (LP: #1320975). Support hal+json in the search
request. Fix issues in autopilot tests. Port autopilot tests to
python3. Add README and HACKING files. (LP: #1226111). Translations
updates. . (LP: #1321154, #1226111, #1320975)
-- Ubuntu daily release <email address hidden> Fri, 23 May 2014 15:00:36 +0000