Ubuntu
lshw package

lshw doesn't deal w/ device-tree endianness

Bug #1308760 reported by dann frazier on 2014-04-16

This bug affects 1 person

	Status	Importance	Assigned to
lshw	Unknown	Unknown	ezix-trac #645
lshw (Debian)	Fix Released	Unknown	debbugs #746616
lshw (Ubuntu)	Fix Released	Medium	Brian Murray
Trusty	Fix Released	Undecided	Unassigned

Bug Description

[Impact]
lshw parses /proc/device-tree to read system properties on device-tree-based platforms. But, on little endian systems like armhf and arm64, it doesn't properly convert the data, which should always be big endian. This can cause incorrect data to be reported. For instance, a 1GHz cpu might be reported as 13MHz because lshw reads a frequency of 0xca9a3b (13MHz) instead of 0x3b9aca00 (1GHz).
[Test Case]
Run lshw on an HP m800 cartridge and examine the cpu frequency.
[Regression Potential]
We're changing parsing code, so there's a possibility that we break that code on systems that currently work in trusty. I tested on a big endian system to make sure it didn't break things there (powerpc), and found the output to be byte-for-byte identical before and after the patch.

See original description

Tags:

Related branches

lp://staging/~dannf/ubuntu/trusty/lshw/lp1308760

lp://staging/~dannf/ubuntu/utopic/lshw/devtree-fixes

Merged into lp://staging/ubuntu/utopic/lshw at revision 29

Brian Murray: Approve on 2014-09-02

lp://staging/ubuntu/utopic/lshw

lp://staging/ubuntu/utopic-proposed/lshw

lp://staging/ubuntu/trusty-proposed/lshw

Revision history for this message

Thomas Palmer (thomas-palmer-n) wrote on 2014-04-21:

project owner has emailed me and said an update was checked into subversion. I will check out new subversion code and give it a try

Revision history for this message

Thomas Palmer (thomas-palmer-n) wrote on 2014-04-21:

lshw project owner accepted my patch. Please pull latest from project git/svn

dann frazier (dannf) on 2014-06-09

description:

updated

Bug Watch Updater (bug-watch-updater) on 2014-08-03

Changed in lshw (Debian):
status:	Unknown → New

Brian Murray (brian-murray) on 2014-09-02

Changed in lshw (Ubuntu):
status:	New → Triaged
importance:	Undecided → Medium

Brian Murray (brian-murray) on 2014-09-02

Changed in lshw (Ubuntu):
assignee:	nobody → Brian Murray (brian-murray)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-09-02:

This bug was fixed in the package lshw - 02.16-2ubuntu2

---------------
lshw (02.16-2ubuntu2) utopic; urgency=medium

* Fix endianness issues with device-tree (LP: #1308760)
* Add DDR3 support for systems described by device-tree (LP: #1351921)
-- dann frazier <email address hidden> Sun, 03 Aug 2014 14:54:54 +0200

Changed in lshw (Ubuntu):
status:	Triaged → Fix Released

Revision history for this message

Chris J Arges (arges) wrote on 2014-10-20: Please test proposed package

Hello dann, or anyone else affected,

Accepted lshw into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lshw/02.16-2ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in lshw (Ubuntu Trusty):
status:	New → Fix Committed
tags:	added: verification-needed

Revision history for this message

dann frazier (dannf) wrote on 2014-10-21:

diff between trusty & trusty-proposed lshw on an m800 Edit (3.2 KiB, text/plain)

dann frazier (dannf) on 2014-10-28

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-10-28:

This bug was fixed in the package lshw - 02.16-2ubuntu1.1

---------------
lshw (02.16-2ubuntu1.1) trusty-proposed; urgency=medium

* Fix endianness issues with device-tree (LP: #1308760)
* Add DDR3 support for systems described by device-tree (LP: #1351921)
-- dann frazier <email address hidden> Thu, 16 Oct 2014 16:26:33 -0600

Changed in lshw (Ubuntu Trusty):
status:	Fix Committed → Fix Released

Revision history for this message

Chris J Arges (arges) wrote on 2014-10-28: Update Released

The verification of the Stable Release Update for lshw has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Bug Watch Updater (bug-watch-updater) on 2016-08-21