Compiz

Scale should not select a window when clicking on an empty area

Bug #1308112 reported by Marco Trevisan (Treviño) on 2014-04-15

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Compiz	Fix Released	Medium	Marco Trevisan (Treviño)	Compiz 0.9.12.0
0.9.11	Fix Released	Medium	Marco Trevisan (Treviño)	Compiz 0.9.11.2
compiz (Ubuntu)	Fix Released	Medium	Marco Trevisan (Treviño)
Trusty	Fix Released	Undecided	Unassigned

Bug Description

[Impact]
Scale selects a window also if the action has been cancelled

[Test Case]
Make sure the "Click on empty area" setting in scale plugin is set to "Terminate Scale"

1. Open some windows
2. Press Super+W to initiate scale
3. Highlight via keyboard or mouse a previously non-focused window
4. Click on an empty area of your screen
5. The scale should be terminated and the previously focused window should still be the
one with keyboard focus.

[Regression Potential]
Regression potential is basically none here, we just made sure that the mouse/keyboard-selected (hovered or highlighted) window is not focused of the scaling action has been cancelled.

-----

Make sure the "Click on empty area" setting in scale plugin is set to "Show Desktop" or "Terminate Scale" (latter is better for testing)

1) Trigger scale
2) Select via keyboard or mouse a previously non-focused window
3) Click on an empty area of your screen

Expected result:
4) Scale is terminated, and the scale-selected window is not focused (while it's still focused the one it was before scaling)

Actual result:
4) Scale is terminated, but the scale-selected window is now focused

See original description

Tags:

Related branches

lp://staging/~3v1n0/compiz/scale-dndtarget-workarea-shape

Merged into lp://staging/compiz/0.9.11 at revision 3861

Christopher Townsend (community): Approve on 2014-04-21

PS Jenkins bot (community): Approve (continuous-integration) on 2014-04-17

lp://staging/~compiz-team/compiz/0.9.11.2

Merged into lp://staging/compiz/0.9.11 at revision 3864

Stephen M. Webb: Approve on 2014-07-11

PS Jenkins bot (community): Approve (continuous-integration) on 2014-07-11

lp://staging/ubuntu/trusty-proposed/compiz

Marco Trevisan (Treviño) (3v1n0) on 2014-06-07

Changed in compiz:
status:	In Progress → Fix Committed

Christopher Townsend (townsend) on 2014-06-10

Changed in compiz:
milestone:	0.9.11.0 → 0.9.12.0

Christopher Townsend (townsend) on 2014-06-18

Changed in compiz (Ubuntu):
status:	New → Fix Released
importance:	Undecided → Medium
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)

Marco Trevisan (Treviño) (3v1n0) on 2014-07-15

description:

updated

Revision history for this message

Chris J Arges (arges) wrote on 2014-07-15: Please test proposed package

Hello Marco, or anyone else affected,

Accepted compiz into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/compiz/1:0.9.11.2+14.04.20140714-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in compiz (Ubuntu Trusty):
status:	New → Fix Committed
tags:	added: verification-needed

Revision history for this message

Sami Jaktholm (sjakthol) wrote on 2014-07-16:

The version from trusty-proposed works.

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-07-22:

This bug was fixed in the package compiz - 1:0.9.11.2+14.04.20140714-0ubuntu1

---------------
compiz (1:0.9.11.2+14.04.20140714-0ubuntu1) trusty; urgency=medium

[ Chris Townsend ]
* Bump version to 0.9.11.2.

  [ Marco Trevisan (Treviño) ]
  * Scale: use XShape extension to exclude dnd input in the screen-parts
    outside workArea This will work property also in multi-monitor,
    without requiring multiple X windows for each output device. Also
    don't terminate the scale unless a drag-n-drop action is not really
    over. Add a spinner that shows up over a window, during the DnD
    timeout. Plus, make sure we terminate the scale without focusing the
    selected icon when cancelling it and some code cleanup (LP: #607796)
    (LP: #727904) (LP: #1308112)

[ Ubuntu daily release ]
* New rebuild forced
-- Ubuntu daily release <email address hidden> Mon, 14 Jul 2014 14:36:56 +0000

Changed in compiz (Ubuntu Trusty):
status:	Fix Committed → Fix Released

Revision history for this message

Adam Conrad (adconrad) wrote on 2014-07-22: Update Released

The verification of the Stable Release Update for compiz has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Stephen M. Webb (bregma) on 2014-11-06

Changed in compiz:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.