Allow unity-panel.menuitem to paint window title text for maximized window in new Unity Decorator(Trusty)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu theme |
Fix Committed
|
Medium
|
Marco Trevisan (Treviño) | ||
Unity |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
ubuntu-themes (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) |
Bug Description
Some themes (Greybird, Elementary) use dark-panel & light window title-bar (When it is not maximized). As new Unity window decorator uses same title-bar foreground color for both normal & maximized windows, window title on unity-panel is not properly visible as it becomes dark-text on dark-panel. I have attached a screenshot.
This forces theme developer to use use same background color for both unity-panel & un-maximized windows, which breaks theme design. The idea is that theme-developers like to think unity-panel as a panel & not just a title-bar for maximized window.
According to https:/
UnityDecoration.top {
color: @dark_fg_color
}
And when this is set, the color set in .unity-
.unity-panel .menuitem {
border-width: 0 1px;
color: @panel_fg_color; # this does not affect window title text anymore.
}
This color (OR unity.panel foreground color in UnityPanelWidget) should be used to paint the window tile text for maximized window, as it used to be in old compiz-decorator.
Related branches
- Brandon Schaefer (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 48 lines (+15/-5)2 files modifiedAmbiance/gtk-3.0/apps/unity.css (+5/-0)
Radiance/gtk-3.0/apps/unity.css (+10/-5)
- PS Jenkins bot (community): Approve (continuous-integration)
- Brandon Schaefer (community): Approve
-
Diff: 371 lines (+82/-101)7 files modifiedpanel/PanelIndicatorEntryView.cpp (+14/-71)
panel/PanelIndicatorEntryView.h (+0/-1)
panel/PanelMenuView.cpp (+5/-1)
unity-shared/DecorationStyle.cpp (+16/-16)
unity-shared/DecorationStyle.h (+3/-1)
unity-shared/PanelStyle.cpp (+42/-9)
unity-shared/PanelStyle.h (+2/-2)
summary: |
- Allow .unity-panel.menuitem to paint window title text for maximized + Allow unity-panel.menuitem to paint window title text for maximized window in new Unity Decorator(Trusty) |
Changed in unity: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity: | |
milestone: | none → 7.2.0 |
Changed in unity (Ubuntu): | |
status: | New → In Progress |
Changed in ubuntu-themes: | |
importance: | Undecided → Medium |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
status: | New → In Progress |
Changed in unity: | |
milestone: | 7.2.0 → 7.2.1 |
status: | In Progress → Fix Committed |
Changed in ubuntu-themes: | |
status: | In Progress → Fix Committed |
Changed in unity: | |
milestone: | 7.2.1 → 7.2.0 |
status: | Fix Committed → Fix Released |
Khurshid Alam is correct. According to the Unity theming documenation for Trusty 14.04 the panel text should be set by the UnityPanelWidget as follows:
UnityPanelWidget, color: shade (@dark_bg_color, 1.5);
.unity-panel {
background-
color: @dark_fg_color; /* Text color */ <--- ***SHOULD BE SET HERE***
}
but it is actually being set by the UnityDecoration "top" code here:
/* This will theme the top decoration, so the whole space above the window */ bottom- width: 0; color: shade (@dark_bg_color, 1.5); /* Decoration background */
UnityDecoration.top {
border: 1px solid shade (@bg_color, 0.5);
border-
border-radius: 8px 8px 0 0; /* Corner radius, only the top ones should be */
padding: 1px 8px 0 8px; /* This padding will be applied to the content of the top layout */
background-
color: @dark_fg_color; /* The foreground color will be used to paint the text */ <--- ***ACTUALLY BEING SET HERE ***
text-shadow: 1px 0 #333, -1px 0 #333, 0 1px #333, 0 -1px #333;
}
This makes it impossible to use a dark panel with light window treatment as the title color for light window treatment is dark making the panel label (e.g. "Ubuntu Desktop") and maximized title unreadable on a dark panel.
In short the panel text color should be set by the unity panel widget class not by the unity decoration class.
Since this problem is already bug reported I will not open another bug report but track progress under this bug report number.
Thanks,
B.Bogert