Ironic

PXE deploy_utils.deploy() failing silently

Bug #1286053 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Lucas Alvares Gomes
Ironic 2014.1 "icehouse"

Bug Description

When the PXE driver invoke the deploy() method from the deploy_utils module it's not logging the exceptions it's raising[1]. There's a comment saying that the exceptions are being logged within the deploy() method itself but it's not true for all the errors[2], and even if it wanted it couldn't, some errors like TypeError (e.g if the deploy() function is called with less parameters than it's requires) is going to fail silently. So my suggestion is to us to start logging the exceptions raised by the deploy() on the PXE driver as well.

[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L724
[2] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L195-L222

See original description
Lucas Alvares Gomes (lucasagomes)
Changed in ironic:
importance: Undecided → High
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77121

Changed in ironic:
status: New → In Progress
Lucas Alvares Gomes (lucasagomes)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/77121
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=8c88fd034b77aa3d2852d951cdc7836c4909ee5e
Submitter: Jenkins
Branch: master

commit 8c88fd034b77aa3d2852d951cdc7836c4909ee5e
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Feb 28 10:07:49 2014 +0000

    Log deploy_utils.deploy() erros in the PXE driver

    When the PXE driver invoke deploy_utils.deploy() it wasn't logging the
    exceptions raised by this call. There was a comment saying that it was
    being logged within the deploy() method itself, but it wasn't true for
    all the exceptions it could raise, also, some of errors e.g TypeError
    where not all parameters are being passed to the deploy() function can't
    be logging by the function called itself and would fail silently. So
    this patch is adding a log in the PXE module to fix this problem.

    Change-Id: Ifbbc0f3cbd5c280d04249cee811d1dc478548975
    Closes-Bug: #1286053

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.