| 2014-02-28 10:13:41 |
Lucas Alvares Gomes |
description |
When the PXE driver invoke the deploy() method from the deploy_utils module it's not logging the exceptions it's raising[1]. There's a comment saying that the exceptions are being logged within the deploy() method itself but it's not true for all the errors[2], and even if it wanted it couldn't, some errors like SyntaxError (e.g if the deploy() function is called with less parameters than it's requires) is going to fail silently. So my suggestion is to us to start logging the exceptions raised by the deploy() on the PXE driver as well.
[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L724
[2] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L195-L222 |
When the PXE driver invoke the deploy() method from the deploy_utils module it's not logging the exceptions it's raising[1]. There's a comment saying that the exceptions are being logged within the deploy() method itself but it's not true for all the errors[2], and even if it wanted it couldn't, some errors like TypeError (e.g if the deploy() function is called with less parameters than it's requires) is going to fail silently. So my suggestion is to us to start logging the exceptions raised by the deploy() on the PXE driver as well.
[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L724
[2] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L195-L222 |
|
