evince/eog crash when using untrusted X11
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libgrip |
Fix Released
|
High
|
Stephen M. Webb | ||
geis (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
libgrip (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
evince/eog crash when using untrusted X11 connection (ssh -X with ForwardX11Trusted no) .
Somehow geis->backend ends up being NULL in this case, and it crashes in geis_backend_
if (!geis->backend)
return NULL;
This causes then a crash later in libgrip in the function 'processed_
GeisFilter window_filter = geis_filter_
if (NULL == window_filter)
return;
Not sure if there are better ways, but this seems to fix it for me.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Brandon Schaefer (community): Approve
-
Diff: 43 lines (+6/-0)1 file modifiedsrc/gripgesturemanager.c (+6/-0)
Changed in libgrip: | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Stephen M. Webb (bregma) |
Changed in libgrip: | |
milestone: | none → 0.3.8 |
Changed in libgrip: | |
status: | Triaged → In Progress |
Changed in libgrip: | |
status: | Fix Committed → Fix Released |
Thank you for fixing this in libgrip. Could you also apply the necessary change to geis?