StateSaver doesn't work when app is closed via SIGINT or SIGTERM

Bug #1259498 reported by Ugo Riboni
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
High
Zsombor Egri
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When apps are closes on the desktop by sending them a SIGINT or SIGTERM signal, the StateSaver doens't save the app state.
Since these signals are catchable by applications, it should be possible for StateSaver to register handlers for them, save and then quit.

Related branches

Changed in ubuntu-ui-toolkit:
status: New → In Progress
assignee: nobody → Florian Boucault (fboucault)
importance: Undecided → High
Revision history for this message
Florian Boucault (fboucault) wrote :
Changed in ubuntu-ui-toolkit:
importance: High → Medium
status: In Progress → Confirmed
assignee: Florian Boucault (fboucault) → nobody
Revision history for this message
Ugo Riboni (uriboni) wrote :

It is important to respond to these signals because at the moment they are the main way to terminate an application when writing an autopilot test that requires the app to be restarted.
On the desktop this can be worked around by sending the app CTRL+F4 but on the device at the moment there's no standard way to terminate the app except sending it a signal.

Revision history for this message
Zsombor Egri (zsombi) wrote :

Actually this is important for the case when upstart stops an app from the application scope. Importance risen to Critical.

Changed in ubuntu-ui-toolkit:
milestone: none → february-2014
importance: Medium → Critical
assignee: nobody → Zsombor Egri (zsombi)
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
importance: Critical → High
Revision history for this message
Zsombor Egri (zsombi) wrote :

It has been decided that SIGTERM clears the states saved, therefore only SIGINT will do state saving.

Changed in ubuntu-ui-toolkit:
milestone: february-2014 → march-2014
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
milestone: march-2014 → april-2014
milestone: april-2014 → march-2014
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.46+14.04.20140331-0ubuntu1

---------------
ubuntu-ui-toolkit (0.1.46+14.04.20140331-0ubuntu1) trusty; urgency=low

  [ Zoltán Balogh ]
  * Separate the online and offline documentation and install the QtC
    help file

  [ Zsombor Egri ]
  * Move state data file to temp folder (LP: #1276760)
  * StateSaver does cleanup if the app is closed due to SIGTERM. This is
    needed as upstart sends this signal when the application is closed
    from app scope. SIGINT saves the state. (LP: #1259498)
  * MainView binding loop fix when backgroundColor is changed runtime.
    (LP: #1204453)

  [ Loïc Molinari ]
  * [Perf metrics] Considered number of CPU cores for CPU usage.

  [ tpeeters ]
  * Add useDeprecatedToolbar property to MainView which can be used to
    disable the current toolbar. Unsetting that property will in future
    also enable new features in the header. (LP: #1273184)
  * Close panel on contents press instead of click, so that composed
    events are not eaten by the InverseMouseArea of the Panel. (LP:
    #1295720)

  [ Christian Dywan ]
  * Treat QML warnings as fatal except for explicitly listed tests
 -- Ubuntu daily release <email address hidden> Mon, 31 Mar 2014 18:26:59 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.